verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#5834 - billingDataAutoFillBic #1821

Merged
jsegarra merged 12 commits from 5834-billingDataAutoFillBic into dev 2024-02-06 16:36:36 +00:00
Conversation 0 Commits 12 Files Changed 3 +23 -1
alexm commented 2023-11-03 08:29:18 +00:00
Member
Copy Link
No description provided.
alexm added 6 commits 2023-11-03 08:29:20 +00:00
gitea/salix/pipeline/head Build queued... Details
2cdebcd69f check bank entity refs 5834
gitea/salix/pipeline/head There was a failure building this commit Details
0536486b8c ref #5834 fix locale
alexm changed title from 5834-billingDataAutoFillBic to WIP: 5834-billingDataAutoFillBic 2023-11-03 08:29:23 +00:00
alexm changed title from WIP: 5834-billingDataAutoFillBic to 5834-billingDataAutoFillBic 2023-11-03 08:29:26 +00:00
alexm changed title from 5834-billingDataAutoFillBic to WIP: 5834-billingDataAutoFillBic 2023-11-03 08:29:31 +00:00
alexm reviewed 2023-11-03 08:40:17 +00:00
back/models/bank-entity.js Outdated
@ -10,4 +10,20 @@ module.exports = Self => {
Self.validatesUniquenessOf('bic', {
message: 'This BIC already exist.'
});
alexm commented 2023-11-03 08:40:17 +00:00
Author
Member
Copy Link

Con esto en el back ya valdria

Con esto en el back ya valdria
jsegarra commented 2024-01-30 14:04:41 +00:00
Member
Copy Link

Entiendo que deberian estar las 2 validaciones del campo bic

Entiendo que deberian estar las 2 validaciones del campo bic
jsegarra added 1 commit 2024-01-12 11:54:22 +00:00
jsegarra added 1 commit 2024-01-12 12:05:25 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
fe4c529bfe refs #5834 perf: remove front code
jsegarra changed title from WIP: 5834-billingDataAutoFillBic to WIP: #5834 - billingDataAutoFillBic 2024-01-30 14:04:56 +00:00
jsegarra requested review from jsegarra 2024-01-30 14:06:10 +00:00
jsegarra changed title from WIP: #5834 - billingDataAutoFillBic to #5834 - billingDataAutoFillBic 2024-01-30 14:06:25 +00:00
jsegarra added 1 commit 2024-01-30 14:06:30 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7ebdf59d97 Merge branch 'dev' into 5834-billingDataAutoFillBic
jsegarra requested changes 2024-01-31 07:22:47 +00:00
back/models/bank-entity.js Outdated
@ -11,2 +11,4 @@
message: 'This BIC already exist.'
});
Self.validateAsync('bic', checkBic, {
jsegarra commented 2024-01-31 07:22:44 +00:00
Member
Copy Link

He hecho pruebas y he visto que si envias countryFk a null da error y este no es informativo al usuario.

Propuesta, añadir en bank-entity.js esta validación
Self.validatesPresenceOf('countryFk', { message: 'CountryFK cannot be empty' });

He hecho pruebas y he visto que si envias countryFk a null da error y este no es informativo al usuario. Propuesta, añadir en bank-entity.js esta validación ` Self.validatesPresenceOf('countryFk', { message: 'CountryFK cannot be empty' });`
jsegarra added 2 commits 2024-02-05 06:25:26 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
22f9d7d7a2 Merge branch 'dev' into 5834-billingDataAutoFillBic
jsegarra added 1 commit 2024-02-06 16:35:13 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4d6e631fca Merge branch 'dev' into 5834-billingDataAutoFillBic
jsegarra scheduled this pull request to auto merge when all checks succeed 2024-02-06 16:35:23 +00:00
jsegarra approved these changes 2024-02-06 16:35:29 +00:00
jsegarra merged commit a8a5ddd889 into dev 2024-02-06 16:36:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1821
No description provided.
Delete Branch "5834-billingDataAutoFillBic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?