verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #6291 validateTin #1836

Merged
carlossa merged 12 commits from 6291-comprobarDNI into dev 2024-01-09 14:03:21 +00:00
Conversation 0 Commits 12 Files Changed 2 +30 -3
carlossa commented 2023-11-14 11:37:34 +00:00
Member
Copy Link
No description provided.
carlossa added 1 commit 2023-11-14 11:37:35 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b57106af48 refs #6291 validateTin
carlossa added 1 commit 2023-11-21 15:25:39 +00:00
gitea/salix/pipeline/head This commit looks good Details
7c6798c564 refs #6291 dni vn-user
carlossa added 1 commit 2023-12-13 12:55:19 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
6416891918 refs #6291 tinIsValid worker
carlossa added 1 commit 2023-12-18 11:32:56 +00:00
gitea/salix/pipeline/head This commit looks good Details
22a9ffc163 refs #6291 dni
carlossa added 2 commits 2023-12-21 14:06:54 +00:00
gitea/salix/pipeline/head This commit looks good Details
c4ff4c1984 refs #6291 tin valid
carlossa requested review from jsegarra 2023-12-21 14:07:51 +00:00
jsegarra requested changes 2023-12-22 07:19:12 +00:00
modules/worker/back/models/worker.js Outdated
@ -26,0 +40,4 @@
const client = (await Self.findById(this.id, {
include: {relation: 'client'}}))?.client();
if (client) {
const countryCode = client.fi?.toLowerCase().substring(0, 2);
jsegarra commented 2023-12-22 07:18:57 +00:00
Member
Copy Link

El nombre de la variable es correcto?
Porque lo llamas countryCode pero no usas referencias a country

El nombre de la variable es correcto? Porque lo llamas countryCode pero no usas referencias a country
carlossa commented 2023-12-26 12:54:07 +00:00
Author
Member
Copy Link

Es como se hacia también en client, por continuar la misma dinámica

Es como se hacia también en client, por continuar la misma dinámica
jsegarra commented 2024-01-02 06:22:47 +00:00
Member
Copy Link

Entiendo, pero cuando creas un worker(pej), crea también el cliente y es en ese modelo donde se guardan los datos que usas en el worker, por eso digo, que siendo otro model a l mejor necesita otro nombre.

Entiendo, pero cuando creas un worker(pej), crea también el cliente y es en ese modelo donde se guardan los datos que usas en el worker, por eso digo, que siendo otro model a l mejor necesita otro nombre.
jsegarra marked this conversation as resolved
jsegarra requested changes 2023-12-22 07:33:24 +00:00
modules/worker/back/models/worker.js Outdated
@ -26,0 +36,4 @@
};
const country = await Self.app.models.Country.findOne(filter);
const code = country ? country.code.toLowerCase() : null;
jsegarra commented 2023-12-22 07:32:57 +00:00
Member
Copy Link

Creo que se puede simplificar
const code = country?.code?.toLowerCase() ?? null;
Y después de esto, quizás emitiría un error

Creo que se puede simplificar const code = country?.code?.toLowerCase() ?? null; Y después de esto, quizás emitiría un error
carlossa marked this conversation as resolved
carlossa added 1 commit 2023-12-26 14:02:58 +00:00
gitea/salix/pipeline/head This commit looks good Details
c77715d865 refs #6291 validation original
carlossa added 1 commit 2024-01-03 12:44:07 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
3fbead7473 refs #6291 fix tinIsValid
carlossa requested review from jsegarra 2024-01-04 11:00:45 +00:00
jgallego changed title from WIP: refs #6291 validateTin to refs #6291 validateTin 2024-01-04 11:44:00 +00:00
carlossa added 1 commit 2024-01-08 08:54:36 +00:00
jsegarra approved these changes 2024-01-09 08:43:47 +00:00
carlossa added 1 commit 2024-01-09 08:46:07 +00:00
gitea/salix/pipeline/head This commit looks good Details
a22de3ab25 Merge branch 'dev' into 6291-comprobarDNI
carlossa requested review from alexm 2024-01-09 09:13:09 +00:00
alexm approved these changes 2024-01-09 13:35:00 +00:00
carlossa added 1 commit 2024-01-09 13:49:38 +00:00
gitea/salix/pipeline/head This commit looks good Details
16d7a20798 Merge branch 'dev' into 6291-comprobarDNI
carlossa added 1 commit 2024-01-09 13:59:54 +00:00
gitea/salix/pipeline/head This commit looks good Details
55f9519ebd Merge branch 'dev' into 6291-comprobarDNI
carlossa scheduled this pull request to auto merge when all checks succeed 2024-01-09 14:00:06 +00:00
carlossa merged commit 6647649f5e into dev 2024-01-09 14:03:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1836
No description provided.
Delete Branch "6291-comprobarDNI"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?