verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

6434-signInLog_issue #1839

Merged
alexm merged 5 commits from 6434-signInLog_issue into test 2023-11-15 12:12:31 +00:00
Conversation 0 Commits 5 Files Changed 6 +75 -6
jsegarra commented 2023-11-15 08:41:56 +00:00
Member
Copy Link
No description provided.
jsegarra added 3 commits 2023-11-15 08:41:56 +00:00
jsegarra requested review from jgallego 2023-11-15 08:42:05 +00:00
jsegarra requested review from alexm 2023-11-15 08:42:05 +00:00
alexm requested changes 2023-11-15 08:45:55 +00:00
back/models/vn-user.js
@ -128,0 +129,4 @@
if (userToken.username !== user) {
console.error('ERROR!!! - Signin with other user', userToken, user);
throw new UserError('Try again');
alexm commented 2023-11-15 08:45:53 +00:00
Member
Copy Link

Per a aço tenim traduccio? Sino li aplegara Try again al usuari.
I jo possaria algo mes descriptiu com ns "Algo ha salido mal, vuelva a intentarlo"

Per a aço tenim traduccio? Sino li aplegara Try again al usuari. I jo possaria algo mes descriptiu com ns "Algo ha salido mal, vuelva a intentarlo"
jsegarra commented 2023-11-15 08:56:08 +00:00
Author
Member
Copy Link

La traducción ya está definida en el fichero loopback/locale/es.json

La traducción ya está definida en el fichero loopback/locale/es.json
jsegarra marked this conversation as resolved
db/changes/234801/00-createSignInLogTable.sql Outdated
@ -0,0 +1,19 @@
alexm commented 2023-11-15 08:43:30 +00:00
Member
Copy Link

La carpeta creat una de la rama de test 234603

La carpeta creat una de la rama de test 234603
jsegarra commented 2023-11-15 09:03:34 +00:00
Author
Member
Copy Link

Ya lo he cambiado

Ya lo he cambiado
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2023-11-15 09:02:57 +00:00
gitea/salix/pipeline/head This commit looks good Details
4d677ccc89 refs #6434 perf: rename folder db/changes version
jsegarra requested review from alexm 2023-11-15 09:48:19 +00:00
alexm approved these changes 2023-11-15 09:49:07 +00:00
Dismissed
jgallego requested changes 2023-11-15 10:47:30 +00:00
modules/account/back/models/sign_in-log.json
@ -0,0 +10,4 @@
"id": {
"id": true,
"type": "string",
"forceId": false
jgallego commented 2023-11-15 10:47:27 +00:00
Owner
Copy Link

esta linea jo no la pondria, no aporta nada, y si algun dia necesitamos poner fixtures podria chocar.
Solemos poner el autoincrement en la tabla.

esta linea jo no la pondria, no aporta nada, y si algun dia necesitamos poner fixtures podria chocar. Solemos poner el autoincrement en la tabla.
jsegarra commented 2023-11-15 10:52:55 +00:00
Author
Member
Copy Link

Cierto, es una propiedad que no aplica al tipo string.
Subida la modificación

Cierto, es una propiedad que no aplica al tipo string. Subida la modificación
jsegarra added 1 commit 2023-11-15 10:51:06 +00:00
gitea/salix/pipeline/head This commit looks good Details
f7b0882978 refs #6434 feat: remove forceId property
jsegarra dismissed alexm’s review 2023-11-15 10:51:06 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra requested review from jgallego 2023-11-15 11:03:43 +00:00
alexm approved these changes 2023-11-15 11:23:10 +00:00
jgallego approved these changes 2023-11-15 12:11:19 +00:00
alexm merged commit 51f881427d into test 2023-11-15 12:12:31 +00:00
alexm deleted branch 6434-signInLog_issue 2023-11-15 12:12:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1839
No description provided.
Delete Branch "6434-signInLog_issue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?