verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6434 - Usuario accede como otro usuario #1843

Merged
jsegarra merged 18 commits from 6434-signInLog_issue_MASTER into master 2023-11-16 11:06:51 +00:00
Conversation 0 Commits 18 Files Changed 5 +35 -11
jsegarra commented 2023-11-15 12:42:45 +00:00
Member
Copy Link
No description provided.
jsegarra added 3 commits 2023-11-15 12:50:15 +00:00
gitea/salix/pipeline/head This commit looks good Details
58edcb9055 refs #6434 feat: save token in db for each login
jsegarra changed title from WIP: Usuario accede como otro usuario to Usuario accede como otro usuario 2023-11-15 12:51:52 +00:00
jsegarra requested review from jgallego 2023-11-15 12:52:04 +00:00
jsegarra requested review from alexm 2023-11-15 12:52:04 +00:00
jsegarra changed title from Usuario accede como otro usuario to #6434 - Usuario accede como otro usuario 2023-11-15 12:52:20 +00:00
alexm approved these changes 2023-11-15 12:52:40 +00:00
Dismissed
alexm added 1 commit 2023-11-15 13:50:24 +00:00
gitea/salix/pipeline/head This commit looks good Details
ac3d23579a Merge branch 'master' into 6434-signInLog_issue_MASTER
alexm requested changes 2023-11-15 14:13:18 +00:00
modules/account/back/models/sign_in-log.json Outdated
@ -0,0 +8,4 @@
},
"properties": {
"id": {
"id": true,
alexm commented 2023-11-15 14:13:16 +00:00
Member
Copy Link

Quitar esta linea dado que como falla se le podra dar el mismo token a dos personas

Quitar esta linea dado que como falla se le podra dar el mismo token a dos personas
jsegarra marked this conversation as resolved
jgallego requested changes 2023-11-15 14:16:01 +00:00
loopback/locale/es.json Outdated
@ -323,3 +322,3 @@
"The ticket is in preparation": "El ticket [{{ticketId}}]({{{ticketUrl}}}) del comercial {{salesPersonId}} está en preparación",
"The amount cannot be less than the minimum": "La cantidad no puede ser menor que la cantidad mímina",
"quantityLessThanMin": "La cantidad no puede ser menor que la cantidad mímina"
"quantityLessThanMin": "La cantidad no puede ser menor que la cantidad mímina",
jgallego commented 2023-11-15 14:15:08 +00:00
Owner
Copy Link

mínima

mínima
alexm marked this conversation as resolved
jsegarra added 1 commit 2023-11-15 14:18:16 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
13720291b2 refs #6434 perf: remove unique in token column
jsegarra dismissed alexm’s review 2023-11-15 14:18:16 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra requested review from alexm 2023-11-15 14:18:26 +00:00
jsegarra requested review from jgallego 2023-11-15 14:18:27 +00:00
alexm approved these changes 2023-11-16 06:23:48 +00:00
Dismissed
alexm added 1 commit 2023-11-16 06:30:40 +00:00
alexm dismissed alexm’s review 2023-11-16 06:30:40 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2023-11-16 06:30:51 +00:00
Dismissed
jgallego requested changes 2023-11-16 06:44:31 +00:00
db/changes/234202/00-createSignInLogTable.sql Outdated
@ -0,0 +8,4 @@
/*!40101 SET @saved_cs_client = @@character_set_client */;
/*!40101 SET character_set_client = utf8 */;
CREATE TABLE `account`.`signInLog` (
`id` varchar(10) NOT NULL ,
jgallego commented 2023-11-16 06:43:53 +00:00
Owner
Copy Link

id autoincrement
y añade una descripcion a la tabla
"log para depurar el error de los inicios de sesión cruzados" por ejemplo

id autoincrement y añade una descripcion a la tabla "log para depurar el error de los inicios de sesión cruzados" por ejemplo
jsegarra commented 2023-11-16 07:47:47 +00:00
Author
Member
Copy Link

El campo id AUTO_INCREMENT está añadido así como la descripción

El campo id AUTO_INCREMENT está añadido así como la descripción
jsegarra marked this conversation as resolved
jsegarra added 3 commits 2023-11-16 07:31:10 +00:00
gitea/salix/pipeline/head This commit looks good Details
e73836cbdb refs #6434 feat: remove primary key constraint
jsegarra dismissed alexm’s review 2023-11-16 07:31:10 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra requested review from jgallego 2023-11-16 07:34:04 +00:00
jsegarra added 1 commit 2023-11-16 07:42:25 +00:00
gitea/salix/pipeline/head This commit looks good Details
d032b3a527 refs #6434 perf: add description to signInLog table
jsegarra added 1 commit 2023-11-16 07:47:17 +00:00
gitea/salix/pipeline/head This commit looks good Details
144b26cf4c refs #6434 perf: signInLog table id column AI
alexm approved these changes 2023-11-16 07:53:02 +00:00
Dismissed
jsegarra added 1 commit 2023-11-16 08:15:13 +00:00
jsegarra added 1 commit 2023-11-16 08:21:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
67f5be474d refs #6434 perf: rename db/changes current folder
jsegarra dismissed alexm’s review 2023-11-16 08:21:30 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2023-11-16 08:44:38 +00:00
Dismissed
jsegarra added 2 commits 2023-11-16 09:30:11 +00:00
gitea/salix/pipeline/head This commit looks good Details
386b556216 refs #6434 feat: new test user signIn with email
jsegarra dismissed alexm’s review 2023-11-16 09:30:11 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2023-11-16 09:43:08 +00:00
gitea/salix/pipeline/head This commit looks good Details
abf772ae87 refs #6434 feat: check if signIn inserts signInLog
alexm approved these changes 2023-11-16 09:54:29 +00:00
Dismissed
jsegarra requested review from alexm 2023-11-16 10:49:31 +00:00
jgallego removed review request for alexm 2023-11-16 10:51:16 +00:00
jsegarra requested review from alexm 2023-11-16 10:52:27 +00:00
jsegarra added 2 commits 2023-11-16 10:57:06 +00:00
gitea/salix/pipeline/head This commit looks good Details
a73453e9ed refs #6434 feat: remove old sql file
jsegarra dismissed alexm’s review 2023-11-16 10:57:06 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jgallego approved these changes 2023-11-16 10:59:10 +00:00
jgallego removed review request for alexm 2023-11-16 10:59:15 +00:00
alexm approved these changes 2023-11-16 11:00:10 +00:00
jsegarra merged commit adc1cd887b into master 2023-11-16 11:06:51 +00:00
jsegarra deleted branch 6434-signInLog_issue_MASTER 2023-11-16 11:06:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1843
No description provided.
Delete Branch "6434-signInLog_issue_MASTER"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?