verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#5878 - FiscalData validations #1851

Merged
carlossa merged 58 commits from 5858-fiscalData-validations into dev 2024-02-28 13:53:34 +00:00
Conversation 0 Commits 58 Files Changed 10 +44 -40
jsegarra commented 2023-11-21 11:45:38 +00:00
Member
Copy Link
No description provided.
jsegarra changed title from WIP: 5858-FiscalData validations to WIP: #5858-FiscalData validations 2023-11-24 11:46:28 +00:00
jsegarra changed title from WIP: #5858-FiscalData validations to WIP: #5858 - FiscalData validations 2023-11-24 11:47:48 +00:00
jsegarra changed title from WIP: #5858 - FiscalData validations to WIP: #5878 - FiscalData validations 2023-11-24 11:48:25 +00:00
jsegarra added 1 commit 2023-11-25 20:11:44 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
273db31c05 refs #5858 feat: approach to print bad field in model
jsegarra added 1 commit 2023-11-25 20:14:08 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
626c000ebb refs #5878 perf: add translation
jsegarra added 1 commit 2023-11-27 07:07:23 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
8b3565d885 refs #5878 test: add new tests
jsegarra added 1 commit 2023-11-27 07:12:04 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f8bf2e02de refs #5878 test: fix
jsegarra added 2 commits 2023-11-27 09:47:54 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
334c5f03a5 refs #5878 feat: validate params in supplier model
jsegarra added 3 commits 2023-11-27 14:07:20 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
ce3da6841c refs #5878 feat: new middleware to validate body
jsegarra added 2 commits 2023-11-29 14:03:18 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
e5e97a047f refs #5878 perf: front validations
jsegarra added 2 commits 2023-12-11 06:36:55 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
94147bd2b2 refs #5858 feat: handle Error from middleware
jsegarra added 1 commit 2023-12-11 06:38:56 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f9ea77fa39 refs #5858 perf: change UserError message
jsegarra added 1 commit 2023-12-11 06:54:52 +00:00
gitea/salix/pipeline/head This commit looks good Details
c8ca855ba9 refs #5858 perf: revert changes
jsegarra added 1 commit 2023-12-14 06:22:12 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
464e3dd591 Merge branch 'dev' into 5858-fiscalData-validations
jsegarra added 3 commits 2023-12-15 11:40:06 +00:00
gitea/salix/pipeline/head This commit looks good Details
8d5e174a64 refs #5878 perf: move validation to other folder
jsegarra added 3 commits 2023-12-21 12:14:13 +00:00
jsegarra added 3 commits 2024-01-02 09:52:20 +00:00
jsegarra added 1 commit 2024-01-03 06:38:42 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
40a269c358 refs #5878 perf: handle when locale not founded
jsegarra added 1 commit 2024-01-04 09:52:04 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
2c91b5b701 refs #5878 perf: change require file
jsegarra added 3 commits 2024-01-15 09:51:49 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
0ca0ea804c refs #5878 feat mapMethods approach
jsegarra added 1 commit 2024-01-17 10:26:42 +00:00
jsegarra added 1 commit 2024-01-18 11:45:19 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1bb0b1b471 Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix into 5858-fiscalData-validations
jsegarra added 1 commit 2024-02-14 08:45:28 +00:00
jsegarra added 2 commits 2024-02-14 09:15:27 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
5918c14d41 refs #5878 feat: replace by any
carlossa added 2 commits 2024-02-20 12:14:31 +00:00
carlossa added 2 commits 2024-02-20 12:19:08 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f3f0360059 refs #5858 fix conflicts
carlossa added 1 commit 2024-02-20 12:44:49 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
62ccbb3074 refs #5858 fix error
carlossa added 1 commit 2024-02-20 12:48:06 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e7f8b7282b refs #5858 remove clean pr
carlossa requested review from alexm 2024-02-20 13:03:15 +00:00
carlossa changed title from WIP: #5878 - FiscalData validations to #5878 - FiscalData validations 2024-02-20 13:03:21 +00:00
jsegarra added 1 commit 2024-02-20 13:14:53 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
ed5197be13 Merge branch 'dev' into 5858-fiscalData-validations
alexm requested changes 2024-02-21 08:56:21 +00:00
modules/client/back/methods/client/updateFiscalData.js Outdated
@ -23,3 +23,3 @@
{
arg: 'fi',
type: 'string'
type: 'any'
alexm commented 2024-02-21 08:56:19 +00:00
Member
Copy Link

Pero asi se pierden los tipos

Pero asi se pierden los tipos
jsegarra commented 2024-02-21 12:14:44 +00:00
Author
Member
Copy Link

Diría que esto no hay que cambiarlo a any
@carlossa Recuerda que lo cambiamos porque teníamos un if que hemos eliminado.
Revísalo porfavor

Diría que esto no hay que cambiarlo a any @carlossa Recuerda que lo cambiamos porque teníamos un if que hemos eliminado. Revísalo porfavor
carlossa marked this conversation as resolved
package.json Outdated
@ -21,6 +21,7 @@
"form-data": "^4.0.0",
"fs-extra": "^5.0.0",
"ftps": "^1.2.0",
"glob": "^10.3.10",
alexm commented 2024-02-21 08:56:01 +00:00
Member
Copy Link

?

?
jsegarra commented 2024-02-21 12:13:16 +00:00
Author
Member
Copy Link

Esto queda por quitar @carlossa

Esto queda por quitar @carlossa
carlossa marked this conversation as resolved
carlossa added 3 commits 2024-02-23 12:52:22 +00:00
carlossa added 1 commit 2024-02-23 12:54:08 +00:00
carlossa added 1 commit 2024-02-23 13:31:12 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
d4459291b6 refs #5878 fix
carlossa added 1 commit 2024-02-23 13:33:27 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
00a8b3dc4b refs #5878 fix
carlossa added 1 commit 2024-02-27 08:28:04 +00:00
carlossa added 1 commit 2024-02-27 08:31:01 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c0988f8d11 fix json
carlossa requested review from alexm 2024-02-27 08:32:32 +00:00
jsegarra added 1 commit 2024-02-27 10:47:10 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b697a1ad32 Merge branch 'dev' into 5858-fiscalData-validations
carlossa added 1 commit 2024-02-27 12:01:39 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
482805de4b Merge branch 'dev' into 5858-fiscalData-validations
carlossa added 2 commits 2024-02-28 13:05:19 +00:00
alexm approved these changes 2024-02-28 13:08:16 +00:00
carlossa added 1 commit 2024-02-28 13:20:54 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
831da1344a fix jenkins
carlossa added 1 commit 2024-02-28 13:25:53 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7044a84354 fix puppeteer
carlossa added 1 commit 2024-02-28 13:30:11 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
d4133580c4 fix pnpm
carlossa added 1 commit 2024-02-28 13:50:55 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
7316673a0b fix pnpm
carlossa merged commit 10e8e03e4e into dev 2024-02-28 13:53:34 +00:00
carlossa deleted branch 5858-fiscalData-validations 2024-02-28 13:53:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1851
No description provided.
Delete Branch "5858-fiscalData-validations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?