verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#5835 getTotals fixed #1854

Merged
jorgep merged 7 commits from 5835-fixGetTotals into dev 2023-11-24 09:56:22 +00:00
Conversation 0 Commits 7 Files Changed 1 +9 -6
jorgep commented 2023-11-22 08:00:33 +00:00
Member
Copy Link
No description provided.
jorgep added the
CR / Tests passed
 label 2023-11-22 08:00:33 +00:00
jorgep added 1 commit 2023-11-22 08:00:33 +00:00
gitea/salix/pipeline/head This commit looks good Details
a27bb53089 refs #5835 getTotals fixed
jorgep requested review from jgallego 2023-11-22 08:00:42 +00:00
jgallego requested changes 2023-11-23 09:00:28 +00:00
modules/invoiceIn/back/methods/invoice-in/getTotals.js Outdated
@ -34,0 +32,4 @@
LEFT JOIN (
SELECT SUM(iit.taxableBase) totalTaxableBase,
CAST(
SUM(COALESCE(iit.taxableBase * (1 + (ti.PorcentajeIva / 100)), iit.taxableBase))
jgallego commented 2023-11-23 09:00:03 +00:00
Owner
Copy Link

si hay dos valores, no pongas coalesce, pon ifnull que es mas claro

si hay dos valores, no pongas coalesce, pon ifnull que es mas claro
jorgep marked this conversation as resolved
jorgep added 1 commit 2023-11-23 10:28:59 +00:00
jorgep added 1 commit 2023-11-23 10:33:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
6b2c1e09de refs #5835 refactor
jorgep requested review from jgallego 2023-11-23 10:34:16 +00:00
jgallego approved these changes 2023-11-23 11:30:35 +00:00
jorgep added 1 commit 2023-11-23 12:04:07 +00:00
gitea/salix/pipeline/head This commit looks good Details
f4a1d09ef8 Merge branch 'dev' into 5835-fixGetTotals
jorgep added 2 commits 2023-11-23 12:23:21 +00:00
jorgep changed title from refs #5835 getTotals fixed to #5835 getTotals fixed 2023-11-23 12:40:34 +00:00
jorgep added 1 commit 2023-11-24 09:15:33 +00:00
jorgep merged commit 74dd64126a into dev 2023-11-24 09:56:22 +00:00
jorgep deleted branch 5835-fixGetTotals 2023-11-24 09:56:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1854
No description provided.
Delete Branch "5835-fixGetTotals"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?