verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#2687 - Travel CloneWithEntries #1887

Merged
jsegarra merged 20 commits from 2687_travel_cloneWithEntries into dev 2024-01-24 10:55:20 +00:00
Conversation 1 Commits 20 Files Changed 7 +224 -112
jsegarra commented 2023-12-11 13:51:47 +00:00
Member
Copy Link
No description provided.
jsegarra added 5 commits 2023-12-12 06:34:41 +00:00
gitea/salix/pipeline/head This commit looks good Details
8bd9becb74 refs #2687 feat: remove procedure argument
jsegarra added 3 commits 2023-12-15 06:35:28 +00:00
jsegarra changed title from WIP: #2687 - Travel CloneWithEntries to #2687 - Travel CloneWithEntries 2023-12-15 06:35:43 +00:00
jsegarra requested review from alexm 2023-12-15 06:35:51 +00:00
jsegarra added 1 commit 2023-12-15 06:40:52 +00:00
gitea/salix/pipeline/head This commit looks good Details
98a98e0d9e refs #2687 perf: remove force test
jsegarra reviewed 2023-12-15 06:43:24 +00:00
db/changes/235201/00-update_procedure_TravelCloneWithEntries.sql Outdated
@ -0,0 +27,4 @@
DECLARE vEvaNotes VARCHAR(255);
DECLARE vDone BOOL;
DECLARE vAuxEntryFk INT;
DECLARE vTx BOOLEAN DEFAULT !@@in_transaction;
jsegarra commented 2023-12-15 06:43:24 +00:00
Author
Member
Copy Link

He añadido esta variable

He añadido esta variable
jsegarra reviewed 2023-12-15 06:43:38 +00:00
db/changes/235201/00-update_procedure_TravelCloneWithEntries.sql Outdated
@ -0,0 +38,4 @@
DECLARE EXIT HANDLER FOR SQLEXCEPTION
BEGIN
CALL util.tx_rollback(vTx);
jsegarra commented 2023-12-15 06:43:38 +00:00
Author
Member
Copy Link

He modificado ROLLBACK por esto

He modificado ROLLBACK por esto
jsegarra reviewed 2023-12-15 06:43:54 +00:00
db/changes/235201/00-update_procedure_TravelCloneWithEntries.sql Outdated
@ -0,0 +42,4 @@
RESIGNAL;
END;
CALL util.tx_start(vTx);
jsegarra commented 2023-12-15 06:43:54 +00:00
Author
Member
Copy Link

He modificado START TRANSACTION por esto

He modificado START TRANSACTION por esto
jsegarra reviewed 2023-12-15 06:44:05 +00:00
db/changes/235201/00-update_procedure_TravelCloneWithEntries.sql Outdated
@ -0,0 +80,4 @@
SET @isModeInventory = FALSE;
CLOSE vRsEntry;
CALL util.tx_commit(vTx);
jsegarra commented 2023-12-15 06:44:05 +00:00
Author
Member
Copy Link

He modificado COMMIT por esto

He modificado COMMIT por esto
jsegarra requested review from juan 2023-12-15 06:44:23 +00:00
alexm approved these changes 2024-01-02 07:37:00 +00:00
Dismissed
db/changes/235201/00-update_procedure_TravelCloneWithEntries.sql Outdated
@ -0,0 +1,85 @@
DROP PROCEDURE IF EXISTS vn.travel_cloneWithEntries;
alexm commented 2024-01-02 07:36:13 +00:00
Member
Copy Link

Cambiar version

Cambiar version
jsegarra commented 2024-01-02 11:10:44 +00:00
Author
Member
Copy Link

La versión correcta, sería la 240001 o la 240101?

La versión correcta, sería la 240001 o la 240101?
jsegarra marked this conversation as resolved
jsegarra added 2 commits 2024-01-02 12:01:04 +00:00
gitea/salix/pipeline/head This commit looks good Details
9165b921ca refs #2687 perf: change db/changes folder
jsegarra dismissed alexm’s review 2024-01-02 12:01:04 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jgallego removed review request for juan 2024-01-19 09:12:24 +00:00
jgallego changed title from #2687 - Travel CloneWithEntries to WIP: #2687 - Travel CloneWithEntries 2024-01-19 09:12:26 +00:00
jgallego requested review from jgallego 2024-01-19 09:12:39 +00:00
jsegarra added 1 commit 2024-01-22 09:01:33 +00:00
gitea/salix/pipeline/head This commit looks good Details
95398485dc Merge branch 'dev' into 2687_travel_cloneWithEntries
jsegarra added 1 commit 2024-01-22 09:22:55 +00:00
gitea/salix/pipeline/head This commit looks good Details
39453492a0 refs #2687 feat update db/change version
jsegarra changed title from WIP: #2687 - Travel CloneWithEntries to #2687 - Travel CloneWithEntries 2024-01-22 09:25:55 +00:00
jsegarra added 1 commit 2024-01-22 11:08:12 +00:00
gitea/salix/pipeline/head This commit looks good Details
7f43a45955 Merge branch 'dev' into 2687_travel_cloneWithEntries
jgallego requested changes 2024-01-22 11:44:57 +00:00
db/changes/240601/00-util_tx_rollback.sql Outdated
@ -0,0 +3,4 @@
DELIMITER $$
$$
CREATE DEFINER=`root`@`localhost` PROCEDURE `util`.`tx_rollback`(tx BOOL)
BEGIN
jgallego commented 2024-01-22 11:44:41 +00:00
Owner
Copy Link

pon una descripcion en cada uno para que la gente sepa que hace

pon una descripcion en cada uno para que la gente sepa que hace
jsegarra marked this conversation as resolved
jsegarra added 2 commits 2024-01-23 07:35:11 +00:00
jsegarra requested review from jgallego 2024-01-23 07:36:36 +00:00
jgallego requested changes 2024-01-23 09:25:43 +00:00
jgallego left a comment
Owner
Copy Link

@alexm que confirme pero faltaran los grants para que las funciones de util puedan ser ejectuadas por todos

@alexm que confirme pero faltaran los grants para que las funciones de util puedan ser ejectuadas por todos
db/changes/240601/00-update_procedure_TravelCloneWithEntries.sql Outdated
@ -0,0 +17,4 @@
* @param vTravelFk travel plantilla a clonar
* @param vDateStart fecha del shipment del nuevo travel
* @param vDateEnd fecha del landing del nuevo travel
* @param vWarehouseOutFk fecha del salida del nuevo travel
jgallego commented 2024-01-23 09:19:17 +00:00
Owner
Copy Link

no es una fecha, es un almacen

no es una fecha, es un almacen
jsegarra commented 2024-01-23 10:24:24 +00:00
Author
Member
Copy Link

Corregido fe714aef22
Nota: está también comentado como fecha en el structure.sql

Corregido fe714aef220bff5b10a06631cf131a1e7e5119ac Nota: está también comentado como fecha en el structure.sql
guillermo commented 2024-01-23 10:32:56 +00:00
Member
Copy Link

GRANT EXECUTE ON PROCEDURE util.tx_commit TO guest;
GRANT EXECUTE ON PROCEDURE util.tx_rollback TO guest;
GRANT EXECUTE ON PROCEDURE util.tx_start TO guest;

`GRANT EXECUTE ON PROCEDURE util.tx_commit TO guest;` `GRANT EXECUTE ON PROCEDURE util.tx_rollback TO guest;` `GRANT EXECUTE ON PROCEDURE util.tx_start TO guest;`
jsegarra marked this conversation as resolved
db/changes/240601/00-util_tx_commit.sql Outdated
@ -0,0 +3,4 @@
DELIMITER $$
$$
/*
Procedimiento para confirmar los cambios asociados a una transacción
jgallego commented 2024-01-23 09:17:13 +00:00
Owner
Copy Link

falta *

falta *
jsegarra commented 2024-01-23 10:23:50 +00:00
Author
Member
Copy Link

Corregido 056dddd212

Corregido 056dddd21229f2c8911c0917555e24bea5a254ad
jsegarra marked this conversation as resolved
jsegarra added 2 commits 2024-01-23 10:23:47 +00:00
gitea/salix/pipeline/head This commit looks good Details
056dddd212 refs #2687 perf: generate comments
jsegarra added 1 commit 2024-01-23 10:53:42 +00:00
gitea/salix/pipeline/head This commit looks good Details
b5d883cdbe refs #2687 feat: add grant privileges for guest
jsegarra commented 2024-01-23 10:55:21 +00:00
Author
Member
Copy Link

@alexm @jgallego

Te refieres a ejecutar las líneas de este fichero? b5d883cdbe/db/changes/240601/00-grant_privileges_util_tx.sql

@alexm @jgallego Te refieres a ejecutar las líneas de este fichero? https://gitea.verdnatura.es/verdnatura/salix/src/commit/b5d883cdbeb742187a923ca70ca12f1923cb4714/db/changes/240601/00-grant_privileges_util_tx.sql
jgallego requested changes 2024-01-23 14:41:52 +00:00
db/changes/240601/00-util_tx_commit.sql Outdated
@ -0,0 +1,16 @@
DELIMITER $$
$$
/**
jgallego commented 2024-01-23 14:41:48 +00:00
Owner
Copy Link

los cambios van dentro del create

los cambios van dentro del create
jsegarra commented 2024-01-23 15:41:55 +00:00
Author
Member
Copy Link

Exacto.
He cogido un archivo creado por un compañero y he visto otro fallo. Había un salto de línea entre END y

Exacto. He cogido un archivo creado por un compañero y he visto otro fallo. Había un salto de línea entre END y $$
jsegarra commented 2024-01-23 15:42:08 +00:00
Author
Member
Copy Link

Corregido cddd8f7d94

Corregido cddd8f7d94713f985c624ae9dfa1d839310dacf2
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2024-01-23 15:40:37 +00:00
gitea/salix/pipeline/head This commit looks good Details
cddd8f7d94 refs #2687 perf: improve comments
jsegarra requested review from jgallego 2024-01-23 15:42:30 +00:00
jgallego approved these changes 2024-01-24 05:28:45 +00:00
alexm approved these changes 2024-01-24 10:39:29 +00:00
jsegarra merged commit 05aaed5565 into dev 2024-01-24 10:55:20 +00:00
jsegarra deleted branch 2687_travel_cloneWithEntries 2024-01-24 10:55:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1887
No description provided.
Delete Branch "2687_travel_cloneWithEntries"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?