verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

#6434 - signIn_issue #1892

Merged
jsegarra merged 20 commits from 6434-signIn_issue into dev 2023-12-22 09:36:33 +00:00
Conversation 0 Commits 20 Files Changed 4 +16 -15
jsegarra commented 2023-12-13 12:30:33 +00:00
Member
Copy Link
No description provided.
jsegarra added 8 commits 2023-12-13 12:30:34 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
5c777c705f refs #6434 feat: add new error message
gitea/salix/pipeline/head There was a failure building this commit Details
7f82243ce6 refs #6434 feat: create signInLog table
gitea/salix/pipeline/head There was a failure building this commit Details
add3a81032 refs #6434 feat: remove recursively fn
gitea/salix/pipeline/head Build queued... Details
5b3645a641 refs #6434 fix: bad merge
gitea/salix/pipeline/head There was a failure building this commit Details
5f93b8c440 refs #6434 fix: bad merge
gitea/salix/pipeline/head There was a failure building this commit Details
5a36fabf05 refs #6434 feat: insert record just when fail
jsegarra added 1 commit 2023-12-13 12:31:48 +00:00
gitea/salix/pipeline/head Build queued... Details
11b54d66af refs #6434 fix: bad merge
jsegarra added 1 commit 2023-12-13 12:31:55 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
8a66391cd5 Merge branch 'dev' into 6434-signIn_issue
jsegarra requested review from juan 2023-12-13 12:32:18 +00:00
jsegarra requested review from jgallego 2023-12-13 12:32:18 +00:00
jsegarra requested review from alexm 2023-12-13 12:32:18 +00:00
jsegarra changed title from WIP: #6434 - signIn_issue to #6434 - signIn_issue 2023-12-13 12:32:20 +00:00
jgallego approved these changes 2023-12-13 13:53:45 +00:00
Dismissed
alexm refused to review 2023-12-13 14:14:44 +00:00
jsegarra added 1 commit 2023-12-19 07:06:45 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
5151cdca48 Merge branch 'dev' into 6434-signIn_issue
juan requested changes 2023-12-20 08:59:47 +00:00
back/models/vn-user.js Outdated
@ -147,0 +144,4 @@
owner: isOwner
});
}
throw new UserError('Try again');
juan commented 2023-12-20 08:59:37 +00:00
Owner
Copy Link

El throw también debería ir dentro del if.

El `throw` también debería ir dentro del `if`.
😕 1
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2023-12-20 09:25:23 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
c3b91e1719 Merge branch 'dev' into 6434-signIn_issue
jsegarra dismissed jgallego’s review 2023-12-20 09:25:24 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2023-12-20 09:27:29 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
57b3d96628 refs #6434 fix: bad throw error
jsegarra added 1 commit 2023-12-20 10:59:41 +00:00
gitea/salix/pipeline/head This commit looks good Details
cb35c36328 refs #6434 test: update tests
jsegarra requested review from juan 2023-12-20 11:04:02 +00:00
jsegarra added 1 commit 2023-12-20 13:29:37 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
748d4724b5 Merge branch 'dev' into 6434-signIn_issue
jsegarra added 1 commit 2023-12-21 06:58:16 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
3c8ff346e2 Merge branch 'dev' into 6434-signIn_issue
jsegarra added 2 commits 2023-12-21 08:03:04 +00:00
jsegarra added 1 commit 2023-12-21 09:10:23 +00:00
gitea/salix/pipeline/head This commit looks good Details
dc661f298b refs #6434 test: update tests
juan approved these changes 2023-12-22 09:08:16 +00:00
jsegarra added 1 commit 2023-12-22 09:26:03 +00:00
gitea/salix/pipeline/head This commit looks good Details
ec1befcfb0 Merge branch 'dev' into 6434-signIn_issue
jsegarra merged commit 703e16ffcd into dev 2023-12-22 09:36:33 +00:00
jsegarra deleted branch 6434-signIn_issue 2023-12-22 09:36:33 +00:00
alexm reviewed 2024-01-02 07:05:48 +00:00
back/methods/vn-user/specs/renew-token.spec.js
@ -32,0 +30,4 @@
it('should renew token', async() => {
const mockDate = new Date(startingTime + 26600000);
jasmine.clock().mockDate(mockDate);
console.log(startingTime, mockDate)
alexm commented 2024-01-02 07:05:48 +00:00
Member
Copy Link

Console.log.
Lo he visto una vez mergeado en dev. Lo quito directamente de la rama

Console.log. Lo he visto una vez mergeado en dev. Lo quito directamente de la rama
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
juan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1892
No description provided.
Delete Branch "6434-signIn_issue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?