verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

Send message to comercial by RocketChat #1897

Merged
jsegarra merged 10 commits from 5499_claim_rocketMessage_comercial into dev 2024-01-11 07:00:13 +00:00
Conversation 0 Commits 10 Files Changed 6 +137 -26
jsegarra commented 2023-12-20 05:50:38 +00:00
Member
Copy Link
No description provided.
jsegarra added 2 commits 2023-12-20 13:10:04 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
5c5be788c1 refs #5499 feat: trigger for all changes
jsegarra added 1 commit 2023-12-21 06:16:40 +00:00
jsegarra added 1 commit 2024-01-04 14:17:39 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
71937a4df3 refs #5499 feat: send RocketMessage when change state
jsegarra added 1 commit 2024-01-04 14:36:57 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
8ee6cfb015 refs #5499 feat: send RocketMessage when change state
jsegarra added 2 commits 2024-01-10 06:48:43 +00:00
jsegarra added 1 commit 2024-01-10 06:50:52 +00:00
gitea/salix/pipeline/head This commit looks good Details
21566fd7ba refs #5499 code: remove unused translations
jsegarra changed title from WIP: Send message to comercial by RocketChat to Send message to comercial by RocketChat 2024-01-10 07:15:21 +00:00
jsegarra requested review from jgallego 2024-01-10 07:15:29 +00:00
jgallego requested changes 2024-01-10 09:21:48 +00:00
modules/claim/back/methods/claim/updateClaim.js
@ -102,3 +99,1 @@
if (newState.code == 'canceled')
await notifyStateChange(ctx, claim.workerFk, claim, newState.code);
}
// if (newState.code == 'incomplete')
jgallego commented 2024-01-10 09:21:46 +00:00
Owner
Copy Link

borrar

borrar
😕 1
jsegarra marked this conversation as resolved
modules/claim/back/methods/claim/updateClaim.js Outdated
@ -114,3 +112,3 @@
};
async function notifyStateChange(ctx, workerId, claim, state) {
async function notifyStateChange(ctx, id, claim, state) {
jgallego commented 2024-01-10 09:21:40 +00:00
Owner
Copy Link

porque lo llamas id? no es el worker?

porque lo llamas id? no es el worker?
jsegarra commented 2024-01-10 09:25:56 +00:00
Author
Member
Copy Link

No puse worker porque en lo antiguo ,según el "code", usaba el id de salesPerson o de workerFk, y como ya no se distingue por code, puse un nombre genérico.

No puse worker porque en lo antiguo ,según el "code", usaba el id de salesPerson o de workerFk, y como ya no se distingue por code, puse un nombre genérico.
jgallego commented 2024-01-11 05:43:13 +00:00
Owner
Copy Link

hasta hoy si un archivo tiene id, y estamos en la ruta claim en este caso, se espera que eso sea claim id. En este caso es confuso, pon una referencia a worker

hasta hoy si un archivo tiene id, y estamos en la ruta claim en este caso, se espera que eso sea claim id. En este caso es confuso, pon una referencia a worker
👍 1
jsegarra commented 2024-01-11 06:29:46 +00:00
Author
Member
Copy Link

Corregido(b76e269e73)

Corregido(b76e269e737a63f6102a10ac831a4837424920c9)
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2024-01-10 13:47:48 +00:00
gitea/salix/pipeline/head This commit looks good Details
de4ddf9392 remove bad comment
jsegarra requested review from jgallego 2024-01-10 13:48:39 +00:00
jsegarra added 1 commit 2024-01-11 06:18:05 +00:00
gitea/salix/pipeline/head This commit looks good Details
b76e269e73 refs #5499 perf: rename variable
jgallego approved these changes 2024-01-11 06:33:08 +00:00
jsegarra merged commit 93f80718d8 into dev 2024-01-11 07:00:13 +00:00
jsegarra deleted branch 5499_claim_rocketMessage_comercial 2024-01-11 07:00:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1897
No description provided.
Delete Branch "5499_claim_rocketMessage_comercial"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?