verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #6397 emailValidation #1941

Merged
carlossa merged 13 commits from 6397-emailValidation into dev 2024-02-01 17:45:54 +00:00
Conversation 0 Commits 13 Files Changed 3 +30 -3
carlossa commented 2024-01-17 14:00:22 +00:00
Member
Copy Link
No description provided.
carlossa added 1 commit 2024-01-17 14:00:23 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
23b8703afc refs #6397 emailValidation
carlossa added 1 commit 2024-01-18 09:57:00 +00:00
gitea/salix/pipeline/head This commit looks good Details
7cb7c7dace refs #6397 back validation
carlossa added 1 commit 2024-01-18 10:42:49 +00:00
gitea/salix/pipeline/head This commit looks good Details
e9c1f125a5 refs #6397 test back
carlossa requested review from alexm 2024-01-18 10:58:19 +00:00
carlossa changed title from WIP: refs #6397 emailValidation to refs #6397 emailValidation 2024-01-18 10:58:26 +00:00
alexm reviewed 2024-01-18 13:53:37 +00:00
loopback/locale/es.json Outdated
@ -339,2 +339,2 @@
"No tickets to invoice": "No hay tickets para facturar"
}
"No tickets to invoice": "No hay tickets para facturar",
"An email is necessary": "An email is necessary"
alexm commented 2024-01-18 13:53:37 +00:00
Member
Copy Link

Falta traducir

Falta traducir
alexm commented 2024-01-22 07:03:34 +00:00
Member
Copy Link

Falta traducir

Falta traducir
carlossa marked this conversation as resolved
alexm requested changes 2024-01-18 14:05:43 +00:00
modules/client/back/methods/client/createWithUser.js Outdated
@ -36,2 +34,2 @@
password: String(Math.random() * 100000000000000)
};
let user;
if (data.email) {
alexm commented 2024-01-18 14:03:10 +00:00
Member
Copy Link

Esto se puede refactorizar y dejar sin if else

Esto se puede refactorizar y dejar sin if else
carlossa marked this conversation as resolved
modules/client/back/methods/client/createWithUser.js Outdated
@ -37,1 +34,3 @@
};
let user;
if (data.email) {
const firstEmail = data.email ? data.email.split(',')[0] : null;
alexm commented 2024-01-18 14:03:38 +00:00
Member
Copy Link

Aqui como este codigo siempre va a tener data.email se puede quitar el hacer ? : (if else)

Aqui como este codigo siempre va a tener data.email se puede quitar el hacer ? : (if else)
carlossa marked this conversation as resolved
modules/client/back/methods/client/specs/createWithUser.spec.js Outdated
@ -51,0 +72,4 @@
throw e;
}
expect(errorMail).toEqual(`An email is necessary`);
alexm commented 2024-01-18 14:05:34 +00:00
Member
Copy Link

Si te has definido la variable, siempre va a dar lo mismo.
Deberias guardarte el error que te de y comprobarlo

Si te has definido la variable, siempre va a dar lo mismo. Deberias guardarte el error que te de y comprobarlo
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-01-19 13:18:04 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
391f418883 refs #6397 fix test back
carlossa added 1 commit 2024-01-19 13:53:41 +00:00
gitea/salix/pipeline/head This commit looks good Details
73e1b52348 refs #6397 refactor
carlossa requested review from alexm 2024-01-19 13:56:17 +00:00
alexm requested changes 2024-01-22 07:09:58 +00:00
modules/client/back/methods/client/specs/createWithUser.spec.js
@ -51,0 +62,4 @@
const tx = await models.Client.beginTransaction({});
let error;
try {
alexm commented 2024-01-22 07:09:35 +00:00
Member
Copy Link

La estructura no esta correcta, deuria ser:

         try{
            await funcioQueVolsProbar()
            await tx.rollback();
        } catch (e) {
            await tx.rollback();
            error = e;
        }

        expect(error.message).toEqual('Error que esperes');
La estructura no esta correcta, deuria ser: ``` try{ await funcioQueVolsProbar() await tx.rollback(); } catch (e) { await tx.rollback(); error = e; } expect(error.message).toEqual('Error que esperes'); ```
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-01-22 09:19:55 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
cf03982d0c refs #6397 trad tback
carlossa requested review from alexm 2024-01-22 09:20:34 +00:00
alexm requested changes 2024-01-26 06:55:23 +00:00
modules/client/back/methods/client/specs/createWithUser.spec.js Outdated
@ -13,6 +13,16 @@ describe('Client Create', () => {
businessTypeFk: 'florist',
provinceFk: 1
};
const newAccount2 = {
alexm commented 2024-01-26 06:54:23 +00:00
Member
Copy Link

Si vas a gasstar dos vegades lo mateix pero canviant un parametre.
Pots fer clonarte el objecte i modficar soles lo que vols
Teu vaig dir en persona

Si vas a gasstar dos vegades lo mateix pero canviant un parametre. Pots fer clonarte el objecte i modficar soles lo que vols Teu vaig dir en persona
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-01-29 13:08:25 +00:00
gitea/salix/pipeline/head This commit looks good Details
04f1a03d4d refs #6397 fix back
carlossa requested review from alexm 2024-01-29 13:09:28 +00:00
carlossa added 1 commit 2024-01-29 14:10:25 +00:00
gitea/salix/pipeline/head This commit looks good Details
f14c239391 Merge branch 'dev' into 6397-emailValidation
carlossa added 1 commit 2024-01-29 14:47:59 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
94cc3ad80e Merge branch 'dev' into 6397-emailValidation
alexm approved these changes 2024-01-30 06:49:43 +00:00
carlossa added 1 commit 2024-01-30 10:48:08 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
edfb90813a Merge branch 'dev' into 6397-emailValidation
carlossa added 1 commit 2024-01-31 15:45:00 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
cbdb089562 Merge branch 'dev' into 6397-emailValidation
carlossa added 1 commit 2024-02-01 11:48:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6576bab305 Merge branch 'dev' into 6397-emailValidation
carlossa added 1 commit 2024-02-01 17:35:36 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c56073c123 Merge branch 'dev' into 6397-emailValidation
carlossa merged commit e59ab6fd97 into dev 2024-02-01 17:45:54 +00:00
carlossa deleted branch 6397-emailValidation 2024-02-01 17:45:54 +00:00
jgallego approved these changes 2024-02-02 08:27:25 +00:00
modules/client/back/methods/client/createWithUser.js
@ -30,3 +32,3 @@
}
const firstEmail = data.email ? data.email.split(',')[0] : null;
if (!data.email)
jgallego commented 2024-02-02 08:27:19 +00:00
Owner
Copy Link

@alexm valorares la opcio de posar-ho en back/models/vn-user.js com a una validacio nativa?

@alexm valorares la opcio de posar-ho en back/models/vn-user.js com a una validacio nativa?
alexm commented 2024-02-02 08:30:36 +00:00
Member
Copy Link

Per mi si, pero hi hauria que mirar els nulls que hi hajen com se comporta la restriccio, pq segurament qualsevol canvi en el model fallara

Per mi si, pero hi hauria que mirar els nulls que hi hajen com se comporta la restriccio, pq segurament qualsevol canvi en el model fallara
Sign in to join this conversation.
Reviewers
No reviewers
alexm
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1941
No description provided.
Delete Branch "6397-emailValidation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?