verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

refs #6397 emailValidation #1941

Merged
carlossa merged 13 commits from 6397-emailValidation into dev 2024-02-01 17:45:54 +00:00
Conversation 0 Commits 13 Files Changed 3 +16 -16
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 391f418883 - Show all commits

32
modules/client/back/methods/client/specs/createWithUser.spec.js
View File

@ -13,8 +13,16 @@ describe('Client Create', () => {
businessTypeFk: 'florist', businessTypeFk: 'florist',
provinceFk: 1 provinceFk: 1
}; };
const newAccount2 = {
carlossa marked this conversation as resolved Outdated
alexm commented 2024-01-26 06:54:23 +00:00
Outdated
Review
Copy Link

Si vas a gasstar dos vegades lo mateix pero canviant un parametre.
Pots fer clonarte el objecte i modficar soles lo que vols
Teu vaig dir en persona

Si vas a gasstar dos vegades lo mateix pero canviant un parametre. Pots fer clonarte el objecte i modficar soles lo que vols Teu vaig dir en persona
const errorMail = `An email is necessary`; userName: 'Deadpool',
fi: '16195279J',
name: 'Wade',
socialName: 'DEADPOOL MARVEL',
street: 'WALL STREET',
city: 'New York',
businessTypeFk: 'florist',
provinceFk: 1
};
beforeAll(async() => { beforeAll(async() => {
const activeCtx = { const activeCtx = {
@ -53,26 +61,18 @@ describe('Client Create', () => {
it('should not create a new account', async() => { it('should not create a new account', async() => {
const tx = await models.Client.beginTransaction({}); const tx = await models.Client.beginTransaction({});
let error;
try { try {
carlossa marked this conversation as resolved
alexm commented 2024-01-22 07:09:35 +00:00
Review
Copy Link

La estructura no esta correcta, deuria ser:

         try{
            await funcioQueVolsProbar()
            await tx.rollback();
        } catch (e) {
            await tx.rollback();
            error = e;
        }

        expect(error.message).toEqual('Error que esperes');
La estructura no esta correcta, deuria ser: ``` try{ await funcioQueVolsProbar() await tx.rollback(); } catch (e) { await tx.rollback(); error = e; } expect(error.message).toEqual('Error que esperes'); ```
const options = {transaction: tx}; const options = {transaction: tx};
await models.Client.createWithUser(newAccount2, options);
const client = await models.Client.createWithUser(newAccount, options);
const account = await models.VnUser.findOne({where: {name: newAccount.userName}}, options);
expect(account.name).toEqual(newAccount.userName);
expect(client.id).toEqual(account.id);
expect(client.name).toEqual(newAccount.name);
expect(client.fi).toEqual(newAccount.fi);
expect(client.socialName).toEqual(newAccount.socialName);
expect(client.businessTypeFk).toEqual(newAccount.businessTypeFk);
await tx.rollback(); await tx.rollback();
} catch (e) { } catch (e) {
await tx.rollback(); error = e.message;
throw e;
}
expect(errorMail).toEqual(`An email is necessary`); expect(error).toEqual(`An email is necessary`);
await tx.rollback();
}
carlossa marked this conversation as resolved Outdated
alexm commented 2024-01-18 14:05:34 +00:00
Outdated
Review
Copy Link

Si te has definido la variable, siempre va a dar lo mismo.
Deberias guardarte el error que te de y comprobarlo

Si te has definido la variable, siempre va a dar lo mismo. Deberias guardarte el error que te de y comprobarlo
}); });
it('should create a new account', async() => { it('should create a new account', async() => {