verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

refs #6397 emailValidation #1941

Merged
carlossa merged 13 commits from 6397-emailValidation into dev 2024-02-01 17:45:54 +00:00
Conversation 0 Commits 13 Files Changed 3 +10 -10
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 73e1b52348 - Show all commits

12
modules/client/back/methods/client/createWithUser.js
View File

@ -31,16 +31,16 @@ module.exports = function(Self) {
myOptions.transaction = tx; myOptions.transaction = tx;
} }
let user; if (!data.email)
jgallego commented 2024-02-02 08:27:19 +00:00
Review
Copy Link

@alexm valorares la opcio de posar-ho en back/models/vn-user.js com a una validacio nativa?

@alexm valorares la opcio de posar-ho en back/models/vn-user.js com a una validacio nativa?
alexm commented 2024-02-02 08:30:36 +00:00
Review
Copy Link

Per mi si, pero hi hauria que mirar els nulls que hi hajen com se comporta la restriccio, pq segurament qualsevol canvi en el model fallara

Per mi si, pero hi hauria que mirar els nulls que hi hajen com se comporta la restriccio, pq segurament qualsevol canvi en el model fallara
if (data.email) { throw new UserError('An email is necessary');
carlossa marked this conversation as resolved Outdated
alexm commented 2024-01-18 14:03:10 +00:00
Outdated
Review
Copy Link

Esto se puede refactorizar y dejar sin if else

Esto se puede refactorizar y dejar sin if else
const firstEmail = data.email ? data.email.split(',')[0] : null;
carlossa marked this conversation as resolved Outdated
alexm commented 2024-01-18 14:03:38 +00:00
Outdated
Review
Copy Link

Aqui como este codigo siempre va a tener data.email se puede quitar el hacer ? : (if else)

Aqui como este codigo siempre va a tener data.email se puede quitar el hacer ? : (if else)
user = { const firstEmail = data.email.split(',')[0];
const user = {
name: data.userName, name: data.userName,
email: firstEmail, email: firstEmail,
password: String(Math.random() * 100000000000000) password: String(Math.random() * 100000000000000)
}; };
} else
throw new UserError(`An email is necessary`);
try { try {
const account = await models.VnUser.create(user, myOptions); const account = await models.VnUser.create(user, myOptions);