#6703 refactor saleRefund #1954

Merged
jorgep merged 16 commits from 6703-refactorSaleRefund into dev 2024-02-05 07:51:18 +00:00
Member
No description provided.
jorgep changed title from #6703 refactor saleRefund to WIP: #6703 refactor saleRefund 2024-01-25 14:55:12 +00:00
jorgep added 1 commit 2024-01-26 07:34:40 +00:00
gitea/salix/pipeline/head This commit looks good Details
e5d466b697
fix: refs #6703 drop & replace sale refund by clone
jorgep added 1 commit 2024-01-26 14:36:46 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
4fc780967f
fix: refs #6703 tests
jorgep requested review from alexm 2024-01-26 14:37:05 +00:00
jorgep requested review from jgallego 2024-01-26 14:37:19 +00:00
jorgep added the
CR / Tests passed
label 2024-01-26 14:37:24 +00:00
jorgep changed title from WIP: #6703 refactor saleRefund to #6703 refactor saleRefund 2024-01-26 14:37:32 +00:00
jgallego requested changes 2024-01-29 07:29:18 +00:00
@ -525,3 +525,3 @@
const salesIds = sales.map(sale => sale.id);
const params = {salesIds: salesIds, withWarehouse: withWarehouse};
const query = 'Sales/refund';
const query = 'Sales/clone';
Owner

aqui imagino que deberas pasar a true el parametro negative

aqui imagino que deberas pasar a true el parametro negative
jorgep marked this conversation as resolved
@ -57,3 +57,3 @@
const params = {servicesIds: this.checkeds, withWarehouse: false};
const query = 'Sales/refund';
const query = 'Sales/clone';
Owner

aqui imagino que deberas pasar a true el parametro negative

aqui imagino que deberas pasar a true el parametro negative
jorgep marked this conversation as resolved
alexm requested changes 2024-01-30 06:32:05 +00:00
@ -0,0 +1,4 @@
UPDATE salix.ACL
Member

Pasar a como se hace en myt

Pasar a como se hace en myt
jorgep marked this conversation as resolved
@ -1,101 +0,0 @@
const models = require('vn-loopback/server/server').models;
Member

Adaptar los test a .clone sino se quedaria sin tests

Adaptar los test a .clone sino se quedaria sin tests
jorgep marked this conversation as resolved
jorgep added 2 commits 2024-01-31 08:20:43 +00:00
jorgep reviewed 2024-01-31 08:24:57 +00:00
@ -16,4 +0,0 @@
});
});
it('should create ticket with the selected lines', async() => {
Author
Member

Ya hay un test parecido en sale clone.

Ya hay un test parecido en sale clone.
jorgep reviewed 2024-01-31 08:33:16 +00:00
@ -34,4 +0,0 @@
}
});
it('should create one ticket for each unique ticketFk in the sales', async() => {
Author
Member

@alexm @jgallego creo que este ya se controla en los tests de clone.

@alexm @jgallego creo que este ya se controla en los tests de clone.
jorgep reviewed 2024-01-31 08:33:30 +00:00
@ -61,4 +0,0 @@
}
});
it('should create a ticket without sales', async() => {
Author
Member

Este lo añado en sale clone

Este lo añado en sale clone
jorgep added 1 commit 2024-01-31 09:03:32 +00:00
jorgep added 1 commit 2024-01-31 09:04:03 +00:00
jorgep requested review from jgallego 2024-01-31 09:04:30 +00:00
jorgep requested review from alexm 2024-01-31 09:04:31 +00:00
jgallego approved these changes 2024-01-31 11:04:02 +00:00
jorgep added 1 commit 2024-01-31 12:15:41 +00:00
alexm added 1 commit 2024-02-01 06:46:27 +00:00
alexm approved these changes 2024-02-01 06:47:34 +00:00
jorgep added 2 commits 2024-02-01 07:18:57 +00:00
jorgep added 1 commit 2024-02-01 07:37:01 +00:00
jorgep added 1 commit 2024-02-01 07:40:52 +00:00
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
a2e076e94f
Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix into 6703-refactorSaleRefund
jorgep added 1 commit 2024-02-02 07:15:57 +00:00
jorgep added 1 commit 2024-02-02 08:41:34 +00:00
jorgep added 1 commit 2024-02-05 07:27:05 +00:00
jorgep added 1 commit 2024-02-05 07:48:13 +00:00
jorgep merged commit 9ee01e2bc2 into dev 2024-02-05 07:51:18 +00:00
jorgep deleted branch 6703-refactorSaleRefund 2024-02-05 07:51:18 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1954
No description provided.