verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: refs #6761 fixtures #1962

Merged
jorgep merged 3 commits from 6761-fixE2e into dev 2024-01-30 08:18:01 +00:00
Conversation 1 Commits 3 Files Changed 3 +7 -6
jorgep commented 2024-01-29 14:52:10 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-01-29 14:52:12 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
a3442d4887 fix: refs #6276 fixtures
jorgep requested review from alexm 2024-01-29 15:09:21 +00:00
jorgep added the
CR / Tests passed
 label 2024-01-29 15:09:30 +00:00
alexm requested changes 2024-01-30 06:52:19 +00:00
alexm left a comment
Member
Copy Link

Se ha comprobado que realmente deban dar esos valores?
Si antes haciendo x peticion devolcia 'unchecked', ahora haciendo la misma devuelve 'checked'?

Se ha comprobado que realmente deban dar esos valores? Si antes haciendo x peticion devolcia 'unchecked', ahora haciendo la misma devuelve 'checked'?
alexm reviewed 2024-01-30 06:53:43 +00:00
e2e/paths/13-supplier/02_basic_data.spec.js Outdated
@ -44,7 +44,7 @@ describe('Supplier basic data path', () => {
it('should check the isSerious checkbox is now unchecked', async() => {
alexm commented 2024-01-30 06:53:43 +00:00
Member
Copy Link

Si fuera el caso ya no seria '... now unchecked'

Si fuera el caso ya no seria '... now unchecked'
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-01-30 07:06:05 +00:00
jorgep commented 2024-01-30 07:12:46 +00:00
Author
Member
Copy Link

Se ha comprobado que realmente deban dar esos valores?
Si antes haciendo x peticion devolcia 'unchecked', ahora haciendo la misma devuelve 'checked'?

He mirado las fixtures y por defecto están todas unchecked (el campo isSerious), por lo que si haces click se cambía a checked.

> Se ha comprobado que realmente deban dar esos valores? > Si antes haciendo x peticion devolcia 'unchecked', ahora haciendo la misma devuelve 'checked'? He mirado las fixtures y por defecto están todas unchecked (el campo **isSerious**), por lo que si haces click se cambía a checked.
Captura de pantalla 2024-01-30 080605.png
98 KiB
Captura de pantalla 2024-01-30 080605.png
jorgep added 1 commit 2024-01-30 07:15:22 +00:00
gitea/salix/pipeline/head This commit looks good Details
8ea1600f4a fix: refs #6276 test title
jorgep requested review from alexm 2024-01-30 07:15:35 +00:00
alexm approved these changes 2024-01-30 07:24:28 +00:00
jorgep changed title from fix: refs #6276 fixtures to fix: refs #6761 fixtures 2024-01-30 07:57:28 +00:00
jorgep merged commit c96e380ba6 into dev 2024-01-30 08:18:01 +00:00
jorgep deleted branch 6761-fixE2e 2024-01-30 08:18:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1962
No description provided.
Delete Branch "6761-fixE2e"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?