verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6776 makeMulti & itemShelvin_add refactor #1970

Merged
jorgep merged 11 commits from 6776-makeMulti into dev 2024-02-19 12:23:45 +00:00
Conversation 0 Commits 11 Files Changed 4 +124
jorgep commented 2024-01-30 12:56:03 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-01-30 13:04:08 +00:00
gitea/salix/pipeline/head This commit looks good Details
afa34c6296 feat: refs #6776 makeMulti
jorgep added 1 commit 2024-01-30 15:09:57 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
5690da0a18 fix: refs #6776 add userId
jorgep added 1 commit 2024-02-15 10:08:05 +00:00
jorgep added 1 commit 2024-02-15 10:22:28 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
be7a570314 fix: refs #6776 test
jorgep added 1 commit 2024-02-15 13:52:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f11aa2605b feat: refs #6776 back & procedure modified
jorgep changed title from WIP: #6776 makeMulti & itemShelvin_add refactor to #6776 makeMulti & itemShelvin_add refactor 2024-02-15 13:53:31 +00:00
jorgep added 1 commit 2024-02-15 13:53:52 +00:00
jorgep added the
CR / Tests passed
 label 2024-02-15 13:53:59 +00:00
jorgep requested review from jgallego 2024-02-15 13:54:08 +00:00
jgallego requested changes 2024-02-16 08:49:43 +00:00
modules/item/back/methods/item-shelving/makeMulti.js Outdated
@ -0,0 +1,64 @@
module.exports = Self => {
Self.remoteMethodCtx('makeMulti', {
jgallego commented 2024-02-16 08:49:41 +00:00
Owner
Copy Link

tanto el nombre como la descripcion no me dejan claro que hace

tanto el nombre como la descripcion no me dejan claro que hace
sergiodt commented 2024-02-16 11:02:26 +00:00
Member
Copy Link

Proposta: itemShelvingAddList_byItem

Proposta: itemShelvingAddList_byItem
jgallego commented 2024-02-16 11:32:44 +00:00
Owner
Copy Link

addShelvingByItem este be?

addShelvingByItem este be?
jorgep added 1 commit 2024-02-16 12:43:07 +00:00
jorgep added 1 commit 2024-02-16 12:53:29 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
69acebb43c fix: refs #6776 replace name
jorgep requested review from jgallego 2024-02-16 12:54:42 +00:00
jgallego requested changes 2024-02-17 06:43:32 +00:00
modules/item/back/methods/item-shelving/addListByItem.js Outdated
@ -0,0 +1,64 @@
module.exports = Self => {
Self.remoteMethodCtx('addListByItem', {
jgallego commented 2024-02-17 06:42:26 +00:00
Owner
Copy Link

upsertItem creo que es lo mas claro y conciso en este caso

upsertItem creo que es lo mas claro y conciso en este caso
jorgep marked this conversation as resolved
jorgep added 2 commits 2024-02-19 10:22:41 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
fc6e34ddfd fix: refs #6776 replace name
jorgep requested review from jgallego 2024-02-19 10:22:58 +00:00
jgallego approved these changes 2024-02-19 12:12:35 +00:00
jorgep added 1 commit 2024-02-19 12:21:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d127354905 Merge branch 'dev' into 6776-makeMulti
jorgep merged commit 6720ef89b9 into dev 2024-02-19 12:23:45 +00:00
jorgep deleted branch 6776-makeMulti 2024-02-19 12:23:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1970
No description provided.
Delete Branch "6776-makeMulti"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?