verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

6444-MigrateVn2008.intrastat_netoFunctionToVn #1972

Merged
ivanm merged 10 commits from 6444-MigrateVn2008.intrastat_netoFunctionToVn into dev 2024-02-06 13:21:24 +00:00
Conversation 0 Commits 10 Files Changed 2 +32 -20
ivanm commented 2024-01-30 14:25:32 +00:00
Member
Copy Link
No description provided.
ivanm added 2 commits 2024-01-30 14:25:32 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
da2a2b5f09 refs #6444 Remove vn2008.intrastat_neto function
ivanm requested review from guillermo 2024-01-30 14:25:56 +00:00
guillermo requested changes 2024-01-31 08:20:02 +00:00
db/routines/vn/functions/intrastat_estimateNet.sql Outdated
@ -0,0 +1,19 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` FUNCTION `vn`.`intrastat_estimateNet`(intINSTRASTAT INTEGER,intUNIDADES INTEGER)
guillermo commented 2024-01-31 08:20:00 +00:00
Member
Copy Link

Falta cambiar los nombres de las variables y formatear mejor el código

Falta cambiar los nombres de las variables y formatear mejor el código
ivanm added 1 commit 2024-02-01 12:04:08 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7b1a0e1957 refs #6444 change code according to sql conventions
ivanm requested review from guillermo 2024-02-01 14:12:00 +00:00
guillermo requested changes 2024-02-02 06:06:27 +00:00
db/routines/vn/functions/intrastat_estimateNet.sql Outdated
@ -0,0 +1,21 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` FUNCTION `vn`.`intrastat_estimateNet`(vIntrastat INT, vUnidades INT)
guillermo commented 2024-02-02 06:06:25 +00:00
Member
Copy Link

Las variables deben de ir en ingles, de todas formas si quieres cuando vengas comentamos

Las variables deben de ir en ingles, de todas formas si quieres cuando vengas comentamos
ivanm added 1 commit 2024-02-05 07:34:52 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1a869766b9 refs #6444 change code accord to conventions
ivanm requested review from guillermo 2024-02-05 07:45:00 +00:00
guillermo requested changes 2024-02-06 07:35:13 +00:00
db/routines/vn/functions/intrastat_estimateNet.sql Outdated
@ -0,0 +1,32 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` FUNCTION `vn`.`intrastat_estimateNet`(
vSelf INT,
vUnits INT
guillermo commented 2024-02-06 07:35:10 +00:00
Member
Copy Link

Al final crec que es millor ficar vStems per a seguir la mateixa nomenclatura

Al final crec que es millor ficar vStems per a seguir la mateixa nomenclatura
ivanm added 1 commit 2024-02-06 07:42:10 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
438af34d73 refs #6444 cambio vUnits por vStems
guillermo approved these changes 2024-02-06 07:43:43 +00:00
juan added 1 commit 2024-02-06 09:11:57 +00:00
ivanm added 1 commit 2024-02-06 09:25:36 +00:00
ivanm added 1 commit 2024-02-06 10:36:45 +00:00
ivanm added 1 commit 2024-02-06 10:39:41 +00:00
guillermo added 1 commit 2024-02-06 13:18:45 +00:00
ivanm merged commit 4592429b3d into dev 2024-02-06 13:21:24 +00:00
ivanm deleted branch 6444-MigrateVn2008.intrastat_netoFunctionToVn 2024-02-06 13:21:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
guillermo
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1972
No description provided.
Delete Branch "6444-MigrateVn2008.intrastat_netoFunctionToVn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?