verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

4515-addBuyCheck #1974

Merged
pablone merged 7 commits from 4515-addBuyCheck into dev 2024-02-02 11:59:28 +00:00
Conversation 0 Commits 7 Files Changed 6 +64 -12
pablone commented 2024-01-31 07:07:04 +00:00
Member
Copy Link
No description provided.
pablone added 2 commits 2024-01-31 07:07:05 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
7e7ab3e8b6 fix(triggers): refs #4515 fix error
pablone requested review from jgallego 2024-01-31 07:25:34 +00:00
pablone requested review from carlosap 2024-01-31 07:25:39 +00:00
jgallego requested changes 2024-01-31 08:44:29 +00:00
db/routines/vn/procedures/buy_chekItem.sql Outdated
@ -0,0 +16,4 @@
JOIN item i ON i.id = b.itemFk
JOIN tmp.buysToCheck bt ON bt.id = b.id
WHERE (i.weightByPiece IS NULL OR i.`size` IS NULL)
LIMIT 1;
jgallego commented 2024-01-31 08:44:24 +00:00
Owner
Copy Link

estas segur que funciona be?
si el primer registre coincidira que hasWeightVolumetric es false, no miraria la resta.
Estas asumint que totes compres que et pasen son del mateix travel, pero jo posaria el a.hasWeightVolumetric en el where per a asegurar.
Altra cosa, en procesos com l'inventari, açò fara que vaja molt lento? el buy_upsert li tinguerem que posar la variable dentorno per ixe motiu

estas segur que funciona be? si el primer registre coincidira que hasWeightVolumetric es false, no miraria la resta. Estas asumint que totes compres que et pasen son del mateix travel, pero jo posaria el a.hasWeightVolumetric en el where per a asegurar. Altra cosa, en procesos com l'inventari, açò fara que vaja molt lento? el buy_upsert li tinguerem que posar la variable dentorno per ixe motiu
pablone commented 2024-01-31 13:30:15 +00:00
Author
Member
Copy Link

bien visto, estaba realizando las pruebas con 1 sola buy

bien visto, estaba realizando las pruebas con 1 sola buy
pablone marked this conversation as resolved
pablone added 1 commit 2024-01-31 13:57:14 +00:00
pablone requested review from jgallego 2024-01-31 13:57:37 +00:00
pablone added 1 commit 2024-01-31 13:57:46 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
650f85c737 Merge branch 'dev' into 4515-addBuyCheck
pablone scheduled this pull request to auto merge when all checks succeed 2024-01-31 13:57:54 +00:00
jgallego approved these changes 2024-01-31 14:27:11 +00:00
pablone added 1 commit 2024-02-02 09:39:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1155c8d309 Merge branch 'dev' into 4515-addBuyCheck
carlosap requested changes 2024-02-02 10:51:00 +00:00
db/routines/vn/procedures/buy_chekItem.sql
@ -0,0 +15,4 @@
JOIN buy b ON b.entryFk = e.id
JOIN item i ON i.id = b.itemFk
JOIN tmp.buysToCheck bt ON bt.id = b.id
WHERE (i.weightByPiece IS NULL OR i.`size` IS NULL)
carlosap commented 2024-02-02 10:29:36 +00:00
Member
Copy Link

paréntesis se pueden quitar

paréntesis se pueden quitar
pablone marked this conversation as resolved
pablone added 1 commit 2024-02-02 11:08:09 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
58daf4754b Merge branch 'dev' into 4515-addBuyCheck
pablone requested review from carlosap 2024-02-02 11:08:52 +00:00
carlosap approved these changes 2024-02-02 11:40:49 +00:00
jgallego added 1 commit 2024-02-02 11:58:07 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
232f46be90 Merge branch 'dev' into 4515-addBuyCheck
pablone merged commit 986d3532ed into dev 2024-02-02 11:59:28 +00:00
pablone deleted branch 4515-addBuyCheck 2024-02-05 10:02:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1974
No description provided.
Delete Branch "4515-addBuyCheck"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?