verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs#5167 Update #1976

Merged
jbreso merged 11 commits from 5167-kk-warehouseAlias-y-warehouseJoined into dev 2024-02-06 09:16:16 +00:00
Conversation 0 Commits 11 Files Changed 11 +42 -260
jbreso commented 2024-01-31 07:59:49 +00:00
Member
Copy Link

Creado de la versión de database que tenía

https://gitea.verdnatura.es/verdnatura/vn-database/pulls/1911/files#diff-fd0acab97de42225d25d8ef1cf4b3090de31c0ad

Creado de la versión de database que tenía https://gitea.verdnatura.es/verdnatura/vn-database/pulls/1911/files#diff-fd0acab97de42225d25d8ef1cf4b3090de31c0ad
jbreso added 1 commit 2024-01-31 07:59:50 +00:00
gitea/salix/pipeline/head This commit looks good Details
aba0d97106 feat: refs#5167 Update
jbreso added 1 commit 2024-01-31 08:37:38 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
18772c04f6 feat: refs #5167 update
jbreso added 1 commit 2024-02-05 06:49:54 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
592e5c877f Merge branch 'dev' into 5167-kk-warehouseAlias-y-warehouseJoined
jbreso added 1 commit 2024-02-05 07:40:10 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f4591aae85 feat: refs #5167 Restaurar zoneEstimatedDelivery
jbreso added 1 commit 2024-02-05 07:40:41 +00:00
jbreso requested review from guillermo 2024-02-05 07:41:02 +00:00
guillermo requested changes 2024-02-06 06:34:24 +00:00
db/routines/vn/procedures/itemPlacementSupplyStockGetTargetList.sql Outdated
@ -21,2 +12,2 @@
ish.created,
p.pickingOrder
p.code parking,
SUM(ish.visible) as stockTotal,
guillermo commented 2024-02-06 06:30:18 +00:00
Member
Copy Link

Quita el AS ya de paso

Quita el AS ya de paso
jbreso marked this conversation as resolved
db/routines/vn/procedures/itemPlacementSupplyStockGetTargetList.sql Outdated
@ -30,3 +23,3 @@
AND ish.itemFk = vItemFk
GROUP BY ish.id
ORDER BY (sc.id = vSectorFk) DESC, sh.priority DESC, ish.created, p.pickingOrder;
ORDER BY sh.priority DESC, ish.created, p.pickingOrder;
guillermo commented 2024-02-06 06:30:29 +00:00
Member
Copy Link

Esto tabulalo

Esto tabulalo
jbreso marked this conversation as resolved
db/versions/10857-navyArborvitae/00-firstScript.sql Outdated
@ -0,0 +1,6 @@
ALTER TABLE vn.agency CHANGE warehouseAliasFk warehouseAliasFk__ smallint(5) unsigned DEFAULT NULL NULL COMMENT 'Refs #5167 Deprecated 2024-01-23';
guillermo commented 2024-02-06 06:32:16 +00:00
Member
Copy Link

Respeta el formato que acoerdamos en la wiki https://wiki.verdnatura.es/index.php/Convenciones_SQL#Borrar_un_objeto

Respeta el formato que acoerdamos en la wiki https://wiki.verdnatura.es/index.php/Convenciones_SQL#Borrar_un_objeto
jbreso marked this conversation as resolved
jbreso added 1 commit 2024-02-06 06:50:42 +00:00
jbreso added 1 commit 2024-02-06 07:03:52 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9f6807204d feat: refs #5167 changes required
jbreso requested review from guillermo 2024-02-06 07:05:47 +00:00
guillermo requested changes 2024-02-06 07:38:43 +00:00
db/versions/10857-navyArborvitae/00-firstScript.sql Outdated
@ -0,0 +3,4 @@
ALTER TABLE vn.warehouse CHANGE aliasFk aliasFk__ smallint(5) unsigned DEFAULT NULL NULL COMMENT 'Refs #5167 Deprecated 2024-01-23';
RENAME TABLE vn.warehouseAlias TO vn.warehouseAlias__;
ALTER TABLE vn.warehouseAlias__ COMMENT='@Deprecated 2024-01-23 Refs #5167';
guillermo commented 2024-02-06 07:38:40 +00:00
Member
Copy Link

Encara está mal, fijat en les mayuscules i minuscules, ademés, dalt tens més

Encara está mal, fijat en les mayuscules i minuscules, ademés, dalt tens més
jbreso marked this conversation as resolved
jbreso added 1 commit 2024-02-06 08:43:33 +00:00
jbreso added 1 commit 2024-02-06 08:53:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
7ebb9cb429 feat: refs #5167 change required
jbreso requested review from guillermo 2024-02-06 08:54:00 +00:00
guillermo requested changes 2024-02-06 09:01:57 +00:00
db/versions/10857-navyArborvitae/00-firstScript.sql Outdated
@ -0,0 +5,4 @@
CHANGE aliasFk aliasFk__ SMALLINT(5) UNSIGNED DEFAULT NULL NULL COMMENT '@Deprecated 2024-01-23 Refs #5167';
RENAME TABLE vn.warehouseAlias TO vn.warehouseAlias__;
ALTER TABLE vn.warehouseAlias__ COMMENT='@Deprecated 2024-01-23 Refs #5167';
guillermo commented 2024-02-06 09:01:55 +00:00
Member
Copy Link

Las mayusculas, te lo he puesto en el anterior comentario

Las mayusculas, te lo he puesto en el anterior comentario
jbreso marked this conversation as resolved
jbreso added 1 commit 2024-02-06 09:07:32 +00:00
gitea/salix/pipeline/pr-dev Build queued... Details
a949c25860 feat refs #5167 changes required
jbreso added 1 commit 2024-02-06 09:07:45 +00:00
jbreso requested review from guillermo 2024-02-06 09:07:47 +00:00
guillermo approved these changes 2024-02-06 09:09:06 +00:00
jbreso merged commit 863b37384f into dev 2024-02-06 09:16:16 +00:00
jbreso deleted branch 5167-kk-warehouseAlias-y-warehouseJoined 2024-02-06 09:16:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
guillermo
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1976
No description provided.
Delete Branch "5167-kk-warehouseAlias-y-warehouseJoined"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?