verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #6692 Deleted views and dependences #1983

Merged
guillermo merged 5 commits from 6692-viewClean9 into dev 2024-02-01 07:38:25 +00:00
Conversation 0 Commits 5 Files Changed 17 +73 -175
guillermo commented 2024-01-31 11:13:57 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-01-31 11:13:57 +00:00
guillermo added 1 commit 2024-01-31 11:14:45 +00:00
guillermo requested review from carlosap 2024-01-31 11:18:06 +00:00
carlosap requested changes 2024-01-31 11:50:04 +00:00
db/routines/vn2008/procedures/emailYesterdayPurchasesByConsigna.sql
@ -21,0 +20,4 @@
JOIN (
SELECT `Movimientos`.`Id_Ticket` AS `Id_Ticket`,
sum(
`Movimientos`.`Cantidad` * `Movimientos`.`Preu` * (100 - `Movimientos`.`Descuento`) / 100
carlosap commented 2024-01-31 11:49:05 +00:00
Member
Copy Link

deberíamos de utilizar las tablas de vn sale y tickets

deberíamos de utilizar las tablas de vn sale y tickets
guillermo marked this conversation as resolved
db/routines/vn2008/views/v_xsubcuentas.sql
@ -152,1 +175,3 @@
`Proveedores`.`Id_Proveedor` = `v_xsubprov`.`proveedor_id`
JOIN (
SELECT `recibida`.`proveedor_id` AS `proveedor_id`,
`recibida`.`empresa_id` AS `empresa_id`
carlosap commented 2024-01-31 11:49:55 +00:00
Member
Copy Link

Ya que hacemos el cambio podemos hacerlo con las tablas de vn

Ya que hacemos el cambio podemos hacerlo con las tablas de vn
guillermo commented 2024-01-31 11:52:39 +00:00
Author
Member
Copy Link

Creo que no vale la pena, ya que es de vn2008, es faena de quien mire si se gasta esa vista y lo cambie a vn

Creo que no vale la pena, ya que es de vn2008, es faena de quien mire si se gasta esa vista y lo cambie a vn
guillermo commented 2024-01-31 11:53:50 +00:00
Author
Member
Copy Link

Mi tarea era una simple comprobación de si se utiliza o no, he hecho eso por eliminar las vistas ya que solo tenian dependencias en esa vista

Mi tarea era una simple comprobación de si se utiliza o no, he hecho eso por eliminar las vistas ya que solo tenian dependencias en esa vista
guillermo marked this conversation as resolved
guillermo requested review from carlosap 2024-01-31 11:52:46 +00:00
guillermo changed title from refactor: refs #6235 Deleted views and dependences to refactor: refs #6692 Deleted views and dependences 2024-01-31 12:02:56 +00:00
carlosap approved these changes 2024-01-31 12:20:12 +00:00
guillermo added 1 commit 2024-02-01 06:22:04 +00:00
guillermo added 1 commit 2024-02-01 07:11:47 +00:00
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
0b5395af2b Merge branch 'dev' into 6692-viewClean9
guillermo scheduled this pull request to auto merge when all checks succeed 2024-02-01 07:22:05 +00:00
guillermo added 1 commit 2024-02-01 07:29:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5d35519431 Merge branch 'dev' into 6692-viewClean9
guillermo merged commit 263d46fa03 into dev 2024-02-01 07:38:25 +00:00
guillermo deleted branch 6692-viewClean9 2024-02-01 07:41:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1983
No description provided.
Delete Branch "6692-viewClean9"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?