verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6403 - mrwIntegration #2005

Merged
pablone merged 15 commits from 6403-mrwIntegration into master 2024-02-23 08:54:44 +00:00
Conversation 0 Commits 15 Files Changed 13 +456 -1
pablone commented 2024-02-07 15:54:57 +00:00
Member
Copy Link
No description provided.
pablone added 6 commits 2024-02-07 15:54:58 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
73c0ca5382 feat(mrwXml): refs #6403 render and transmEnvio integrated
gitea/salix/pipeline/head This commit looks good Details
854447f7c1 feat: refs #6403 mrw cancelShipment
gitea/salix/pipeline/pr-master There was a failure building this commit Details
d2d28889b6 merge(master): refs #6403 merge master fix conflicts
pablone added 2 commits 2024-02-16 07:27:49 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
b6be76c38f feat(test): refs #6403 add spec
pablone added 2 commits 2024-02-16 07:30:46 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
85b1391006 fix(sql): refs #6403 merge master
pablone added 1 commit 2024-02-16 13:14:23 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
c10cb7c051 feat(spec): refs #6403 mrwIntegration
pablone changed title from WIP: 6403-mrwIntegration to 6403-mrwIntegration 2024-02-16 13:19:51 +00:00
pablone requested review from carlosap 2024-02-16 13:19:57 +00:00
pablone requested review from alexm 2024-02-16 13:20:02 +00:00
alexm changed title from 6403-mrwIntegration to #6403 - mrwIntegration 2024-02-19 07:58:58 +00:00
alexm requested changes 2024-02-19 07:59:41 +00:00
alexm left a comment
Member
Copy Link

Usar try catch con rollback para poder usar rollback en los tests

Usar try catch con rollback para poder usar rollback en los tests
back/methods/mrw-config/cancelShipment.js Outdated
@ -0,0 +39,4 @@
const xmlString = response.data;
const parser = new DOMParser();
const xmlDoc = parser.parseFromString(xmlString, 'text/xml');
const resultElement = xmlDoc.getElementsByTagName('Mensaje')[0];
alexm commented 2024-02-19 07:49:35 +00:00
Member
Copy Link

Se pot subsituir per
const [resultElement] = xmlDoc.getElementsByTagName('Mensaje');

Se pot subsituir per const [resultElement] = xmlDoc.getElementsByTagName('Mensaje');
pablone marked this conversation as resolved
back/methods/mrw-config/specs/createShipment.spec.js Outdated
@ -0,0 +35,4 @@
let options;
fdescribe('MRWConfig createShipment()', () => {
beforeAll(async() => {
alexm commented 2024-02-19 07:58:21 +00:00
Member
Copy Link

Gastar beforeEach i afterEach per a fer rollback

Gastar beforeEach i afterEach per a fer rollback
pablone marked this conversation as resolved
carlosap approved these changes 2024-02-19 09:37:29 +00:00
Dismissed
pablone added 1 commit 2024-02-19 10:33:08 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
b3ce6e8d45 fix(spec): refs #6403 add mrwSpec
pablone dismissed carlosap’s review 2024-02-19 10:33:08 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pablone requested review from alexm 2024-02-19 11:50:58 +00:00
pablone added 1 commit 2024-02-19 11:53:35 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
46043eef9a refactor(description): refs #6403 modify description
alexm added 1 commit 2024-02-21 08:50:55 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
8182809d8a Merge branch 'master' into 6403-mrwIntegration
alexm approved these changes 2024-02-21 08:51:43 +00:00
Dismissed
alexm reviewed 2024-02-21 08:52:08 +00:00
loopback/locale/es.json Outdated
@ -339,2 +339,2 @@
"No tickets to invoice": "No hay tickets para facturar"
}
"No tickets to invoice": "No hay tickets para facturar",
"1) El servicio solicitado no existe o no es un servicio válido.": "1) El servicio solicitado no existe o no es un servicio válido."
alexm commented 2024-02-21 08:52:08 +00:00
Member
Copy Link

1 ) ?

1 ) ?
carlosap approved these changes 2024-02-21 09:40:59 +00:00
Dismissed
pablone added 1 commit 2024-02-23 08:40:06 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
18da27179d merge(dev): refs #6005 traduction conflict
pablone dismissed alexm’s review 2024-02-23 08:40:06 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pablone dismissed carlosap’s review 2024-02-23 08:40:06 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2024-02-23 08:53:11 +00:00
pablone merged commit 03550573b0 into master 2024-02-23 08:54:44 +00:00
pablone deleted branch 6403-mrwIntegration 2024-02-23 08:54:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2005
No description provided.
Delete Branch "6403-mrwIntegration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?