verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

#2687 - Travel_cloneWithEntries_MYT #2012

Closed
jsegarra wants to merge 6 commits from 2687_travel_cloneWithEntries into dev
pull from: 2687_travel_cloneWithEntries
merge into: verdnatura:dev
Conversation 0 Commits 6 Files Changed 3 +14 -8
jsegarra commented 2024-02-08 12:45:00 +00:00
Member
Copy Link
No description provided.
jsegarra added 1 commit 2024-02-09 08:36:15 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f368395912 Merge branch 'dev' into 2687_travel_cloneWithEntries
jsegarra added 2 commits 2024-02-11 19:41:39 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
gitea/salix/pipeline/pr-test This commit looks good Details
a97b3afe98 refs #2687 db: use myt to implement
jsegarra changed title from WIP: #2687 - Travel_cloneWithEntries_MYT to #2687 - Travel_cloneWithEntries_MYT 2024-02-12 05:11:46 +00:00
jsegarra requested review from alexm 2024-02-12 05:11:49 +00:00
alexm requested changes 2024-02-12 06:25:59 +00:00
db/versions/10832-purpleAralia/01-update_procedure_TravelCloneWithEntries.sql
@ -27,7 +27,7 @@ BEGIN
DECLARE vEvaNotes VARCHAR(255);
alexm commented 2024-02-12 06:22:48 +00:00
Member
Copy Link

Esta versio ya esta en test, si es vol modificar s'ha de modificar antes que es fusione en produccio

Esta versio ya esta en test, si es vol modificar s'ha de modificar antes que es fusione en produccio
modules/travel/back/methods/travel/specs/cloneWithEntries.spec.js
@ -31,1 +31,4 @@
travelFk: newTravelId
}, options);
await models.Travel.destroyById(newTravelId, options);
await tx.rollback();
alexm commented 2024-02-12 06:25:45 +00:00
Member
Copy Link

Aunque fasa rollback cal borrar les entrades i el travel???

Aunque fasa rollback cal borrar les entrades i el travel???
jsegarra commented 2024-02-12 07:09:51 +00:00
Author
Member
Copy Link

Lo hablamos, porque aunque hagas rollback, los registros no desaparecen.

Lo hablamos, porque aunque hagas rollback, los registros no desaparecen.
jsegarra changed target branch from dev to test 2024-02-12 07:10:11 +00:00
jsegarra added 1 commit 2024-02-12 07:11:36 +00:00
gitea/salix/pipeline/pr-test This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
94503c803e Merge branch 'test' into 2687_travel_cloneWithEntries
jsegarra changed target branch from test to dev 2024-02-12 07:22:14 +00:00
jsegarra closed this pull request 2024-02-12 07:41:44 +00:00
All checks were successful
gitea/salix/pipeline/pr-test This commit looks good
Required
Details
gitea/salix/pipeline/pr-dev This commit looks good
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2012
No description provided.
Delete Branch "2687_travel_cloneWithEntries"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?