verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #6501 Migrated procs from vn2008 to vn #2016

Merged
guillermo merged 24 commits from 6501-procMigration into dev 2024-02-14 10:31:14 +00:00
Conversation 1 Commits 24 Files Changed 9 +535 -452
guillermo commented 2024-02-09 10:39:43 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-02-09 10:39:44 +00:00
guillermo added 1 commit 2024-02-09 10:39:48 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
0cea80ad46 Merge branch 'dev' into 6501-procMigration
guillermo added 2 commits 2024-02-09 10:40:38 +00:00
guillermo added 1 commit 2024-02-09 10:44:45 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
dbe63ad11b refactor: refs #6501 Fix grant errors
guillermo commented 2024-02-09 10:45:19 +00:00
Author
Member
Copy Link

He tenido que poner también los proc en el fichero de versión, ya que de lo contrario los GRANT dan error.

He tenido que poner también los proc en el fichero de versión, ya que de lo contrario los GRANT dan error.
guillermo added 1 commit 2024-02-12 07:56:40 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
fc5daf119c Merge branch 'dev' into 6501-procMigration
guillermo requested review from carlosap 2024-02-12 07:57:55 +00:00
guillermo added 1 commit 2024-02-12 09:08:07 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
212bf58932 refactor: refs #6501 Minor change
guillermo added 1 commit 2024-02-12 09:17:42 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f89ae0aad9 refactor: refs #6501 Minor change
guillermo added 1 commit 2024-02-12 09:27:36 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
23bf9b2750 refactor: refs #6501 Minor change
guillermo added 1 commit 2024-02-12 09:35:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4b5802202d refactor: refs #6501 Minor change
guillermo added 1 commit 2024-02-12 10:01:35 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
fb76381624 refactor: refs #6501 Minor change
guillermo added 1 commit 2024-02-12 10:28:05 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
ee67a02bf0 refactor: refs #6501 Minor change
guillermo added 1 commit 2024-02-12 10:31:18 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
96d6637a3f refactor: refs #6501 Minor change
carlosap requested changes 2024-02-12 15:05:37 +00:00
db/routines/vn/procedures/XDiario_reconciliation.sql Outdated
@ -0,0 +1,41 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`XDiario_reconciliation`()
carlosap commented 2024-02-12 15:01:06 +00:00
Member
Copy Link

El nombre del procedimiento es mejor que sea verification ó check, en la descripción quitaría las palabras conciliación diaria -> verificación

El nombre del procedimiento es mejor que sea verification ó check, en la descripción quitaría las palabras conciliación diaria -> verificación
guillermo marked this conversation as resolved
db/routines/vn/procedures/entry_getTransfer.sql Outdated
@ -0,0 +4,4 @@
)
BEGIN
/**
* Gestiona el traslado de productos a partir de una entrada específica.
carlosap commented 2024-02-12 14:57:34 +00:00
Member
Copy Link

Retorna los artículos trasladables a partir de una entrada

Retorna los artículos trasladables a partir de una entrada
guillermo marked this conversation as resolved
db/routines/vn/procedures/entry_getTransfer.sql Outdated
@ -0,0 +167,4 @@
LEFT JOIN vn.buy b3 ON b3.id = bufi.buyFk
WHERE ic.display
AND NOT e.isRaid
AND (ti.visible != 0 OR ti.available != 0)
carlosap commented 2024-02-12 14:59:04 +00:00
Member
Copy Link

<>

<>
guillermo marked this conversation as resolved
db/routines/vn/procedures/travel_detail.sql Outdated
@ -0,0 +1,103 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`travel_detail`()
carlosap commented 2024-02-12 14:40:21 +00:00
Member
Copy Link

Debe ser más descriptivo, aunque lo correcto sería que el origen lo pudiéramos parametrizar y fuera genérico, en este caso en particular cambiamos a travel_detailAmerica
y cambiamos por el campo continentFk

Debe ser más descriptivo, aunque lo correcto sería que el origen lo pudiéramos parametrizar y fuera genérico, en este caso en particular cambiamos a travel_detailAmerica y cambiamos por el campo continentFk
guillermo commented 2024-02-13 06:16:07 +00:00
Author
Member
Copy Link

Lo de continentFk no entiendo a que te refieres

Lo de continentFk no entiendo a que te refieres
guillermo commented 2024-02-13 06:43:11 +00:00
Author
Member
Copy Link

Vale creo que ya te entendido, te refieres al nuevo nombre de la variable que has propuesto.

Creo que no sería correcto, ya que el procedimiento retornaría travels de otros países a parte de Ecuador y Colombia, además de que este tipo de tareas no se centra en refactorizar el funcionamiento de los procedimientos, sino en pasar de vn2008 a vn y que no tengan dependencias de vn2008.

Vale creo que ya te entendido, te refieres al nuevo nombre de la variable que has propuesto. Creo que no sería correcto, ya que el procedimiento retornaría travels de otros países a parte de Ecuador y Colombia, además de que este tipo de tareas no se centra en refactorizar el funcionamiento de los procedimientos, sino en pasar de vn2008 a vn y que no tengan dependencias de vn2008.
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-02-13 06:15:41 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
fb84fe4b97 refactor: refs #6501 Requested changes
guillermo added 1 commit 2024-02-13 06:16:17 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c4528a9eac Merge branch 'dev' into 6501-procMigration
guillermo requested review from carlosap 2024-02-13 06:43:26 +00:00
guillermo added 1 commit 2024-02-13 10:13:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
ed67b1168f refactor: refs #6501 Requested changes
guillermo added 1 commit 2024-02-13 10:15:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3c6e3a9856 Merge branch 'dev' into 6501-procMigration
guillermo added 1 commit 2024-02-14 06:04:28 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9dd5b725e1 Merge branch 'dev' into 6501-procMigration
carlosap reviewed 2024-02-14 09:54:18 +00:00
db/routines/vn/procedures/continent_getTravelDetail.sql Outdated
@ -0,0 +1,109 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`continent_getTravelDetail`(
carlosap commented 2024-02-14 09:54:18 +00:00
Member
Copy Link

travel_getDetailFromContinent (vContinentFk)

travel_getDetailFromContinent (vContinentFk)
carlosap reviewed 2024-02-14 09:56:14 +00:00
db/routines/vn/procedures/XDiario_verify.sql Outdated
@ -0,0 +1,41 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`XDiario_verify`()
carlosap commented 2024-02-14 09:56:14 +00:00
Member
Copy Link

Creo que es más correcto check que lo utilizamos más

Creo que es más correcto check que lo utilizamos más
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-02-14 10:04:25 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
874f776498 refactor: refs #6501 Requested changes
guillermo added 1 commit 2024-02-14 10:06:26 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
cddb8dc216 Merge branch 'dev' into 6501-procMigration
guillermo added 1 commit 2024-02-14 10:11:14 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
08db19bf4e Merge branch 'dev' into 6501-procMigration
guillermo added 2 commits 2024-02-14 10:16:02 +00:00
carlosap approved these changes 2024-02-14 10:20:28 +00:00
guillermo added 1 commit 2024-02-14 10:20:31 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b46087b75c refactor: refs #6501 Requested changes
guillermo merged commit 267fd8beb8 into dev 2024-02-14 10:31:14 +00:00
guillermo deleted branch 6501-procMigration 2024-02-14 10:31:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2016
No description provided.
Delete Branch "6501-procMigration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?