verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6379 fixDriverRouteEmail #2018

Merged
jorgep merged 7 commits from 6379-fixDriverRouteEmail into dev 2024-02-12 07:46:56 +00:00
Conversation 0 Commits 7 Files Changed 3 +31 -15
jorgep commented 2024-02-09 12:27:59 +00:00
Member
Copy Link
No description provided.
jorgep added 2 commits 2024-02-09 12:28:00 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
e0de498f65 fix: refs #6379 add Error & locale
jorgep added the
CR / Tests passed
 label 2024-02-09 12:28:06 +00:00
jorgep requested review from alexm 2024-02-09 12:39:37 +00:00
jorgep added 1 commit 2024-02-09 12:41:13 +00:00
jorgep added 1 commit 2024-02-09 12:50:01 +00:00
jorgep added 1 commit 2024-02-09 13:05:47 +00:00
alexm requested changes 2024-02-12 06:18:29 +00:00
loopback/locale/es.json Outdated
@ -342,2 +342,3 @@
"An email is necessary": "Es necesario un email",
"You cannot update these fields": "No puedes actualizar estos campos"
"You cannot update these fields": "No puedes actualizar estos campos",
"CountryFK cannot be empty": "CountryFK cannot be empty"
alexm commented 2024-02-12 06:11:21 +00:00
Member
Copy Link

Falta traducir

Falta traducir
jorgep marked this conversation as resolved
alexm requested changes 2024-02-12 06:20:36 +00:00
modules/route/back/methods/route/driverRouteEmail.js Outdated
@ -43,0 +52,4 @@
else ctx.args.recipient = reportMail;
if (!ctx.args.recipient) throw new UserError('An email is necessary');
Self.sendTemplate(ctx, 'driver-route');
alexm commented 2024-02-12 06:20:32 +00:00
Member
Copy Link

i aci igual val la pena posar un await

i aci igual val la pena posar un await
jorgep marked this conversation as resolved
jorgep added 2 commits 2024-02-12 07:38:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d60a95feaa fix: refs #6379 await & locale
jorgep requested review from alexm 2024-02-12 07:40:52 +00:00
alexm approved these changes 2024-02-12 07:41:03 +00:00
jorgep merged commit d7e51e01a2 into dev 2024-02-12 07:46:56 +00:00
jorgep deleted branch 6379-fixDriverRouteEmail 2024-02-12 07:46:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2018
No description provided.
Delete Branch "6379-fixDriverRouteEmail"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?