verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6813 fix creditClient #2026

Merged
jorgep merged 5 commits from 6813-fixCreditClient into dev 2024-02-13 10:53:39 +00:00
Conversation 0 Commits 5 Files Changed 1 +2 -12
jorgep commented 2024-02-12 13:31:19 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-02-13 08:40:02 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6116ada156 fix: refs #6813 remove inserts
jorgep added 1 commit 2024-02-13 09:20:44 +00:00
jorgep changed title from WIP: #6813 fix creditClient to #6813 fix creditClient 2024-02-13 09:51:28 +00:00
jorgep added the
CR / Tests passed
 label 2024-02-13 09:51:32 +00:00
jorgep requested review from jgallego 2024-02-13 09:54:48 +00:00
jorgep requested review from jsegarra 2024-02-13 09:54:48 +00:00
jsegarra reviewed 2024-02-13 10:01:06 +00:00
db/routines/vn2008/procedures/recobro_credito.sql
@ -16,3 +11,2 @@
UPDATE vn.`client` c
JOIN vn.payMethod pm ON pm.id = c.payMethodFk
JOIN vn.payMethod pm ON pm.id = c.payMethodFk
jsegarra commented 2024-02-13 10:01:06 +00:00
Member
Copy Link

Esta linea y la 14 es formateo, correcto?

Esta linea y la 14 es formateo, correcto?
jorgep commented 2024-02-13 10:19:06 +00:00
Author
Member
Copy Link

Según el experto en base de datos @pablone, el set es más importante que el join.

Según el experto en base de datos @pablone, el set es más importante que el join.
jorgep marked this conversation as resolved
jorgep added 2 commits 2024-02-13 10:22:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
579f2abe5b fix: refs #6813 remove quotation marks
jgallego approved these changes 2024-02-13 10:33:49 +00:00
jorgep added 1 commit 2024-02-13 10:51:16 +00:00
jsegarra approved these changes 2024-02-13 10:53:16 +00:00
jorgep merged commit 9bd8c21660 into dev 2024-02-13 10:53:39 +00:00
jorgep deleted branch 6813-fixCreditClient 2024-02-13 10:53:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
jsegarra
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2026
No description provided.
Delete Branch "6813-fixCreditClient"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?