feat: refs #5720 vehicle nuevos campos #2029

Merged
jgallego merged 2 commits from 5720-poolbancario into dev 2024-02-14 14:02:22 +00:00
Owner
No description provided.
jgallego added 1 commit 2024-02-13 06:58:31 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
118fbcb94f
feat: #5720 vehicle nuevos campos
jgallego requested review from guillermo 2024-02-13 06:58:52 +00:00
guillermo requested changes 2024-02-13 08:07:05 +00:00
@ -0,0 +1,13 @@
ALTER TABLE vn.vehicle ADD supplierFk int(10) unsigned NULL COMMENT 'supplier from whom the vehicle was purchased';
Member

Creo que acordamos en la convención SQL que los comentarios eran en español

Creo que acordamos en la convención SQL que los comentarios eran en español
Author
Owner

ací no s'acordà res, per tant, es lliure

ací no s'acordà res, per tant, es lliure
jgallego marked this conversation as resolved
@ -0,0 +1,13 @@
ALTER TABLE vn.vehicle ADD supplierFk int(10) unsigned NULL COMMENT 'supplier from whom the vehicle was purchased';
ALTER TABLE vn.vehicle ADD CONSTRAINT vehicle_supplierFk FOREIGN KEY (supplierFk) REFERENCES vn.supplier(id);
ALTER TABLE vn.vehicle ADD import decimal(10,2) NULL;
Member

Si no le pones el DEFAULT el default es NULL?

Si no le pones el DEFAULT el default es NULL?
Author
Owner

depén de com estiga configurada la BBDD en este cas se li posa que accepte valors nulls el camp

depén de com estiga configurada la BBDD en este cas se li posa que accepte valors nulls el camp
jgallego marked this conversation as resolved
@ -0,0 +6,4 @@
ALTER TABLE vn.vehicle ADD supplierCoolerFk int(10) unsigned NULL;
ALTER TABLE vn.vehicle ADD CONSTRAINT vehicle_supplierCoolerFk FOREIGN KEY (supplierCoolerFk) REFERENCES vn.supplier(id) ON DELETE RESTRICT ON UPDATE CASCADE;
ALTER TABLE vn.vehicle ADD vin varchar(50) CHARACTER SET utf8mb3 COLLATE utf8mb3_unicode_ci DEFAULT NULL NULL;
Member

Cuando se crea un nuevo campo que no va a tener foreign key, no se pone número: https://wiki.verdnatura.es/index.php/Convenciones_SQL#Data_type

Cuando se crea un nuevo campo que no va a tener foreign key, no se pone número: https://wiki.verdnatura.es/index.php/Convenciones_SQL#Data_type
Author
Owner

ixa part de la wiki ni Juan ni Carlos ni jo l'haviem vist, i a mes no s'ha dit mai, lo correcte es especificar un varchar amb la seua longitud.

ixa part de la wiki ni Juan ni Carlos ni jo l'haviem vist, i a mes no s'ha dit mai, lo correcte es especificar un varchar amb la seua longitud.
jgallego marked this conversation as resolved
guillermo changed title from feat: #5720 vehicle nuevos campos to feat: refs #5720 vehicle nuevos campos 2024-02-13 08:07:13 +00:00
jgallego requested review from guillermo 2024-02-13 12:32:23 +00:00
guillermo approved these changes 2024-02-13 14:13:08 +00:00
jgallego added 1 commit 2024-02-14 13:47:15 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d7efdacab3
Merge branch 'dev' into 5720-poolbancario
jgallego merged commit 798bd10303 into dev 2024-02-14 14:02:22 +00:00
jgallego deleted branch 5720-poolbancario 2024-02-14 14:02:22 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2029
No description provided.