verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #6875 Add restriction on vn.buy.packing field not null and > 0 #2047

Merged
guillermo merged 3 commits from 6875-packingNotNull into dev 2024-03-14 08:05:12 +00:00
Conversation 0 Commits 3 Files Changed 2 +16 -6
pablone commented 2024-02-19 08:55:19 +00:00
Member
Copy Link
No description provided.
pablone added 1 commit 2024-02-19 08:55:19 +00:00
jgallego requested changes 2024-03-05 14:48:12 +00:00
Dismissed
db/routines/vn/procedures/inventoryMake.sql Outdated
@ -183,3 +183,3 @@
SET inv.buyingValue = b.buyingValue,
inv.freightValue = b.freightValue,
inv.packing = b.packing,
inv.packing = IFNULL(GREATEST(b.packing, 1), 1),
jgallego commented 2024-03-05 14:44:47 +00:00
Owner
Copy Link

si baix fas açò
ALTER TABLE vn.buy MODIFY COLUMN packing int(11) NOT NULL CHECK(packing > 0);

ja no fa falta tocar esta linea perque no hi ha forma de que hi haja registres incorrectes.

si baix fas açò ALTER TABLE vn.buy MODIFY COLUMN packing int(11) NOT NULL CHECK(packing > 0); ja no fa falta tocar esta linea perque no hi ha forma de que hi haja registres incorrectes.
guillermo marked this conversation as resolved
db/versions/10892-yellowGerbera/00-firstScript.sql Outdated
@ -0,0 +5,4 @@
WHERE packing IS NULL
OR NOT packing
ALTER TABLE vn.buy MODIFY COLUMN packing int(11) NOT NULL CHECK(packing > 0);
jgallego commented 2024-03-05 14:48:06 +00:00
Owner
Copy Link

aprofitar per a posar el camp com a unsigned, ja que hi ha negatius, els valors actuals posarlos a uno, els mes recients son de agost.

aprofitar per a posar el camp com a unsigned, ja que hi ha negatius, els valors actuals posarlos a uno, els mes recients son de agost.
guillermo marked this conversation as resolved
guillermo changed title from WIP: refactor(packing): refs #6875 add restriction on vn.buy.packing field not null and > 0 to refactor(packing): refs #6875 add restriction on vn.buy.packing field not null and > 0 2024-03-13 10:56:13 +00:00
guillermo added 1 commit 2024-03-13 10:56:20 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
cbaa48a933 Merge branch 'dev' into 6875-packingNotNull
guillermo added 1 commit 2024-03-13 12:44:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
11dcb6e79f refactor: refs #6875 packing not null, negative or zero
guillermo requested review from jgallego 2024-03-13 12:44:47 +00:00
guillermo changed title from refactor(packing): refs #6875 add restriction on vn.buy.packing field not null and > 0 to refactor: refs #6875 Add restriction on vn.buy.packing field not null and > 0 2024-03-13 12:46:05 +00:00
jgallego approved these changes 2024-03-13 13:29:01 +00:00
guillermo merged commit 08359cdfe0 into dev 2024-03-14 08:05:12 +00:00
guillermo deleted branch 6875-packingNotNull 2024-03-14 08:05:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2047
No description provided.
Delete Branch "6875-packingNotNull"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?