verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #6834 feat:handle Error #2057

Merged
sergiodt merged 4 commits from 6834_sectorCollectionSaleGroup_add into dev 2024-02-21 11:06:54 +00:00
Conversation 0 Commits 4 Files Changed 1 +19
sergiodt commented 2024-02-20 15:10:59 +00:00
Member
Copy Link
No description provided.
sergiodt added 1 commit 2024-02-20 15:11:00 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b9fe990003 refs #6834 feat:handle Error
sergiodt requested review from jgallego 2024-02-20 15:11:09 +00:00
sergiodt added 1 commit 2024-02-20 15:12:09 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
be81835474 refs #6834 feat:handle Error
jgallego requested changes 2024-02-20 18:09:20 +00:00
db/routines/vn/procedures/sectorCollectionSaleGroup_add.sql Outdated
@ -11,0 +12,4 @@
DECLARE vHasSectorCollection INT;
SELECT COUNT(id) INTO vHasSaleGroup
FROM vn.saleGroup sg
jgallego commented 2024-02-20 18:08:01 +00:00
Owner
Copy Link

FROM saleGroup
sols una taula va sense alias

FROM saleGroup sols una taula va sense alias
sergiodt commented 2024-02-21 06:12:09 +00:00
Author
Member
Copy Link

Fet

Fet
db/routines/vn/procedures/sectorCollectionSaleGroup_add.sql Outdated
@ -11,0 +16,4 @@
WHERE sg.id = vSaleGroupFk;
IF !vHasSaleGroup THEN
CALL util.throw ("INVALID_SALEGROUP");
jgallego commented 2024-02-20 18:08:55 +00:00
Owner
Copy Link

Els throws van en minúscules i separades, busca un exemple

Els throws van en minúscules i separades, busca un exemple
sergiodt commented 2024-02-21 06:13:48 +00:00
Author
Member
Copy Link

He trobat un poc de tot, ho apunte en Convenciones SQL ?

He trobat un poc de tot, ho apunte en Convenciones SQL ?
sergiodt added 1 commit 2024-02-21 06:09:00 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
614652c357 refs #6834 feat:handle Error
sergiodt requested review from jgallego 2024-02-21 06:14:06 +00:00
sergiodt added 1 commit 2024-02-21 06:16:03 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
448763ee72 refs #6834 feat:handle Error
jgallego approved these changes 2024-02-21 08:49:43 +00:00
sergiodt merged commit 1328a8fa96 into dev 2024-02-21 11:06:54 +00:00
sergiodt deleted branch 6834_sectorCollectionSaleGroup_add 2024-02-21 11:06:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2057
No description provided.
Delete Branch "6834_sectorCollectionSaleGroup_add"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?