verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

6784-delete-clientTypeFk #2059

Merged
ivanm merged 6 commits from 6784-delete-clientTypeFk into dev 2024-02-23 08:25:42 +00:00
Conversation 0 Commits 6 Files Changed 15 +45 -68
ivanm commented 2024-02-21 11:25:41 +00:00
Member
Copy Link
No description provided.
ivanm added 3 commits 2024-02-21 11:25:42 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f0daf2dd9a refs #6784 Modify fixtures.before.sql
ivanm added 1 commit 2024-02-21 11:32:38 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
65cb2d45fd refs #6784 Eliminate row in fixtures.before.sql
ivanm requested review from jgallego 2024-02-21 11:36:58 +00:00
jgallego requested changes 2024-02-21 14:05:19 +00:00
db/routines/vn/procedures/comparative_add.sql Outdated
@ -48,3 +48,3 @@
JOIN ticket t ON t.id = s.ticketFk
JOIN client c ON c.id = t.clientFk
JOIN clientType ct ON ct.id = c.clientTypeFk
JOIN clientType ct ON ct.code = c.typeFk
jgallego commented 2024-02-21 13:59:45 +00:00
Owner
Copy Link

este join ja sobra

este join ja sobra
ivanm commented 2024-02-21 14:34:19 +00:00
Author
Member
Copy Link

Sí, es cert, ho canvie en els 3 casos i ho tinc en compte per a canviar-ho en els 2 de access.

Sí, es cert, ho canvie en els 3 casos i ho tinc en compte per a canviar-ho en els 2 de access.
db/routines/vn/procedures/itemShelving_filterBuyer.sql Outdated
@ -45,3 +45,3 @@
JOIN ticket t ON t.id = s.ticketFk
JOIN client c on c.id = t.clientFk
JOIN clientType ct ON ct.id = c.clientTypeFk
JOIN clientType ct ON ct.code = c.typeFk
jgallego commented 2024-02-21 14:00:05 +00:00
Owner
Copy Link

este join ja sobra

este join ja sobra
db/routines/vn/procedures/itemShelving_filterBuyer.sql
@ -48,3 +47,4 @@
JOIN clientType ct ON ct.code = c.typeFk
WHERE t.shipped BETWEEN util.VN_CURDATE() AND util.dayend(util.VN_CURDATE())
AND st.saleFk IS NULL
AND ct.code IN ('normal', 'trust')
jgallego commented 2024-02-21 14:00:38 +00:00
Owner
Copy Link

c.typeFk , tant ací com en els altres llocs

c.typeFk , tant ací com en els altres llocs
modules/ticket/back/models/sale.js Outdated
@ -45,4 +44,0 @@
include: {
relation: 'type',
scope: {
fields: ['code', 'description']
jgallego commented 2024-02-21 14:05:13 +00:00
Owner
Copy Link

atencio ací perque al ser back cap la posibilitat de que quan ho puges t'obriguen un cau de que algu accedia a sale y consultaba la propietat description..

atencio ací perque al ser back cap la posibilitat de que quan ho puges t'obriguen un cau de que algu accedia a sale y consultaba la propietat description..
ivanm commented 2024-02-21 14:33:23 +00:00
Author
Member
Copy Link

Es de veres, ahí m'he vingut amunt, he retornat la relació i els 2 camps i ha passat el test correctament. Quan ho tinga tot t'ho puje.

Es de veres, ahí m'he vingut amunt, he retornat la relació i els 2 camps i ha passat el test correctament. Quan ho tinga tot t'ho puje.
ivanm added 1 commit 2024-02-22 13:03:35 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a0cb32ea10 refs #6784 Delete unnecessary JOINs
ivanm requested review from jgallego 2024-02-22 13:09:39 +00:00
jgallego approved these changes 2024-02-22 14:30:53 +00:00
ivanm added 1 commit 2024-02-23 08:24:15 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
03fc7cfb4e Merge branch 'dev' into 6784-delete-clientTypeFk
ivanm merged commit bf85aa1e9d into dev 2024-02-23 08:25:42 +00:00
ivanm deleted branch 6784-delete-clientTypeFk 2024-02-23 08:25:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2059
No description provided.
Delete Branch "6784-delete-clientTypeFk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?