verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #6732 change name supplier.isSerious to supplier.isReal #2063

Merged
ivanm merged 4 commits from 6732-Change-name-vn.supplier.isSerious-to-vn.supplier.isReal into dev 2024-04-10 11:21:20 +00:00
Conversation 1 Commits 4 Files Changed 12 +16 -15
ivanm commented 2024-02-21 13:41:05 +00:00
Member
Copy Link
No description provided.
ivanm added 1 commit 2024-02-21 13:41:05 +00:00
ivanm requested review from guillermo 2024-02-21 13:46:51 +00:00
ivanm commented 2024-02-26 11:36:09 +00:00
Author
Member
Copy Link

La cerca de "isSerious" ha donat el mateix resultat que abans.
En canvi "serious" sí que ha tornat un resultat que he de modificar una vegada m'acceptes el PR.
Ho tens explicat en el redmine https://redmine.verdnatura.es/issues/6732

La cerca de "isSerious" ha donat el mateix resultat que abans. En canvi "serious" sí que ha tornat un resultat que he de modificar una vegada m'acceptes el PR. Ho tens explicat en el redmine https://redmine.verdnatura.es/issues/6732
guillermo approved these changes 2024-03-11 13:46:09 +00:00
Dismissed
guillermo left a comment
Member
Copy Link

Revisa las dependencias en Salix, ya que te has dejado algunas

Revisa las dependencias en Salix, ya que te has dejado algunas
db/routines/vn2008/views/Proveedores.sql Outdated
@ -23,7 +23,7 @@ AS SELECT `s`.`id` AS `Id_Proveedor`,
`s`.`isOfficial` AS `oficial`,
`s`.`workerFk` AS `workerFk`,
`s`.`payDay` AS `pay_day`,
`s`.`isSerious` AS `serious`,
guillermo commented 2024-03-11 13:44:51 +00:00
Member
Copy Link

Si aço no has canviat encara en access, respeta serious, i a qui li toque llevar la vista ja o canviará directe

Si aço no has canviat encara en access, respeta serious, i a qui li toque llevar la vista ja o canviará directe
guillermo requested changes 2024-03-11 13:46:25 +00:00
Dismissed
guillermo left a comment
Member
Copy Link

Revisa las dependencias en Salix, ya que te has dejado algunas

Revisa las dependencias en Salix, ya que te has dejado algunas
ivanm added 1 commit 2024-04-09 11:54:43 +00:00
ivanm added 1 commit 2024-04-09 15:34:12 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
eedf30a2dd refs #6732 salix dependencies and undo changes Proveedores
ivanm requested review from guillermo 2024-04-09 15:37:19 +00:00
guillermo approved these changes 2024-04-10 05:01:45 +00:00
ivanm added 1 commit 2024-04-10 11:18:34 +00:00
ivanm merged commit bd026af917 into dev 2024-04-10 11:21:20 +00:00
ivanm deleted branch 6732-Change-name-vn.supplier.isSerious-to-vn.supplier.isReal 2024-04-10 11:21:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
guillermo
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2063
No description provided.
Delete Branch "6732-Change-name-vn.supplier.isSerious-to-vn.supplier.isReal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?