5509-entryDmsBack #2079

Merged
alexm merged 21 commits from 5509-entryDmsBack into dev 2024-02-26 10:16:41 +00:00
Member
No description provided.
alexm added 18 commits 2024-02-23 06:50:25 +00:00
gitea/salix/pipeline/head This commit looks good Details
7ea1fbfb26
refs #5509 feat: entryDms funcionality
gitea/salix/pipeline/head This commit looks good Details
f4dc596e97
refs 5509 feat: add triggers, downloadFile
gitea/salix/pipeline/pr-dev This commit looks good Details
4a2032b9cd
refs #5509 fix(EntryDms): sql
alexm changed title from WIP: 5509-entryDmsBack to 5509-entryDmsBack 2024-02-23 07:18:44 +00:00
alexm reviewed 2024-02-23 07:19:06 +00:00
@ -103,6 +103,20 @@
"video/mp4"
]
},
"entryStorage": {
Author
Member

Esta part esta be? @juan

Esta part esta be? @juan
Owner

No te se dir, açò ho portaba Joan pero pareix que la resta estàn igual

No te se dir, açò ho portaba Joan pero pareix que la resta estàn igual
alexm requested review from jsegarra 2024-02-23 07:19:58 +00:00
alexm added 1 commit 2024-02-23 07:34:25 +00:00
jsegarra requested changes 2024-02-23 22:10:31 +00:00
@ -337,2 +337,4 @@
"You already have the mailAlias": "Ya tienes este alias de correo",
"The alias cant be modified": "Este alias de correo no puede ser modificado",
"No tickets to invoice": "No hay tickets para facturar",
"this warehouse has not dms": "El Almacén no acepta documentos",
Member

No encuentro ocurrencias
Si las hay, es correcto que empiece por minúscula?

No encuentro ocurrencias Si las hay, es correcto que empiece por minúscula?
Author
Member

Viene en minúsculas de :
db/dump/.dump/triggers.sql
db/routines/vn/triggers/dms_beforeInsert.sql

Viene en minúsculas de : db/dump/.dump/triggers.sql db/routines/vn/triggers/dms_beforeInsert.sql
alexm marked this conversation as resolved
@ -0,0 +2,4 @@
module.exports = Self => {
Self.remoteMethodCtx('removeFile', {
description: 'Removes a claim document',
Member

Hablamos de claim o entry?

Hablamos de claim o entry?
alexm marked this conversation as resolved
@ -0,0 +36,4 @@
const targetEntryDms = await Self.findById(id, null, myOptions);
const targetDms = await Self.app.models.Dms.removeFile(ctx, targetEntryDms.dmsFk, myOptions);
if (!targetDms || ! targetEntryDms)
Member

Mmm creo que la condición debería duplicarse ya que líneas más arriba usas dmsFk
O si asumimos que la línea 36 SIEMPRE devuelve resultado para que poner ||?

Mmm creo que la condición debería duplicarse ya que líneas más arriba usas dmsFk O si asumimos que la línea 36 SIEMPRE devuelve resultado para que poner ||?
alexm marked this conversation as resolved
@ -0,0 +6,4 @@
accepts: [{
arg: 'id',
type: 'number',
description: 'The claim id',
Member

Claim o entry?

Claim o entry?
alexm marked this conversation as resolved
alexm added 2 commits 2024-02-26 06:23:07 +00:00
alexm reviewed 2024-02-26 06:25:42 +00:00
@ -0,0 +1,2 @@
INSERT INTO `vn`.`dmsType` (code, name, path__, writeRoleFk, readRoleFk, monthToDelete)
VALUES('entry', 'Entrada', '', 1, 1, NULL);
Author
Member

Fique algo de path__ ? @juan

Fique algo de `path__` ? @juan
Owner

Esta deprecat, això es que no se gasta i no farà falta ficar res

Esta deprecat, això es que no se gasta i no farà falta ficar res
alexm requested review from jsegarra 2024-02-26 06:26:08 +00:00
jsegarra approved these changes 2024-02-26 06:52:09 +00:00
alexm merged commit 41cc56f9ed into dev 2024-02-26 10:16:41 +00:00
alexm deleted branch 5509-entryDmsBack 2024-02-26 10:16:41 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2079
No description provided.