verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: comprobaciones facturas contabilizadas refs #6932 #2091

Merged
carlosap merged 9 commits from 6932-cambios-en-ENT-con-facturas-contabilzadas into dev 2024-02-26 16:22:27 +00:00
Conversation 0 Commits 9 Files Changed 2 +19 -4
carlosap commented 2024-02-23 17:05:29 +00:00
Member
Copy Link
No description provided.
carlosap added 1 commit 2024-02-23 17:05:30 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
bed4faceb7 feat: comprobaciones facturas contabilizadas refs #6932
carlosap requested review from jgallego 2024-02-23 17:05:41 +00:00
carlosap added 1 commit 2024-02-23 17:10:26 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
5fe4f794cc feat: comprobaciones facturas contabilizadas refs #6932
carlosap added 1 commit 2024-02-23 17:13:06 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
55bc6418f5 feat: comprobaciones facturas contabilizadas refs #6932
carlosap added 1 commit 2024-02-23 17:15:11 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4cc950011e feat: comprobaciones facturas contabilizadas refs #6932
jgallego requested changes 2024-02-24 05:50:11 +00:00
db/routines/vn/triggers/entry_beforeUpdate.sql Outdated
@ -50,0 +57,4 @@
AND ii.isBooked;
IF vHasAnyInvoiceBooked THEN
CALL util.throw('The travel has entries with booked invoices');
jgallego commented 2024-02-24 05:50:09 +00:00
Owner
Copy Link

Ademés de que estem repentint codi, crec que teniem un altre cau de fer que en les entrades pasara igual que en tpv que si un ticket esta facturat ja no es pot modificar, es pot fer igual? si el contabilicen mirar quines coses no es poden tocar.
Si vols seguir en la linea que ho has plantejat, jo faria una funcion travel_hasInvoiceBooked o similar que li pases el travel et torna l'error i estos dos triggers que li pasen el travel. La unica diferencia es que en el trigger de entry tu estas sols comprobant l'entrada actual i en el que jo planteje es comprobarien totes les del travel, pero llegint el mensage d'error crec que es lo correcte.

Ademés de que estem repentint codi, crec que teniem un altre cau de fer que en les entrades pasara igual que en tpv que si un ticket esta facturat ja no es pot modificar, es pot fer igual? si el contabilicen mirar quines coses no es poden tocar. Si vols seguir en la linea que ho has plantejat, jo faria una funcion travel_hasInvoiceBooked o similar que li pases el travel et torna l'error i estos dos triggers que li pasen el travel. La unica diferencia es que en el trigger de entry tu estas sols comprobant l'entrada actual i en el que jo planteje es comprobarien totes les del travel, pero llegint el mensage d'error crec que es lo correcte.
carlosap commented 2024-02-26 11:20:04 +00:00
Author
Member
Copy Link

Se decide dejar solamente las verificaciones a nivel de travel

Se decide dejar solamente las verificaciones a nivel de travel
carlosap added 1 commit 2024-02-26 11:18:05 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a19ce04a40 feat: comprobaciones facturas contabilizadas refs #6932
carlosap added 1 commit 2024-02-26 11:19:01 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
bfd86c8972 feat: comprobaciones facturas contabilizadas refs #6932
carlosap requested review from jgallego 2024-02-26 11:20:14 +00:00
jgallego requested changes 2024-02-26 13:16:05 +00:00
db/routines/vn/triggers/entry_beforeUpdate.sql Outdated
@ -6,6 +6,7 @@ BEGIN
DECLARE vIsVirtual BOOL;
DECLARE vPrintedCount INT;
DECLARE vHasDistinctWarehouses BOOL;
DECLARE vHasAnyInvoiceBooked BOOL;
jgallego commented 2024-02-26 13:16:03 +00:00
Owner
Copy Link

no hem parlat de deixar sols el trigger de travel?

no hem parlat de deixar sols el trigger de travel?
carlosap added 1 commit 2024-02-26 14:43:21 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f1329a4624 feat: comprobaciones facturas contabilizadas refs #6932
carlosap added 1 commit 2024-02-26 14:44:54 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9cbcd70d4d feat: comprobaciones facturas contabilizadas refs #6932
carlosap requested review from jgallego 2024-02-26 14:45:33 +00:00
jgallego requested changes 2024-02-26 14:50:06 +00:00
db/routines/vn/triggers/travel_beforeUpdate.sql
@ -19,1 +21,4 @@
END IF;
IF NOT (NEW.awbFk <=> OLD.awbFk)THEN
DECLARE vHasAnyInvoiceBooked BOOL;
jgallego commented 2024-02-26 14:50:03 +00:00
Owner
Copy Link

duplicat

duplicat
carlosap marked this conversation as resolved
carlosap added 1 commit 2024-02-26 14:54:17 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
dcb09cd9f9 feat: comprobaciones facturas contabilizadas refs #6932
carlosap requested review from jgallego 2024-02-26 14:55:15 +00:00
jgallego approved these changes 2024-02-26 16:06:39 +00:00
carlosap merged commit 7ffc11e45a into dev 2024-02-26 16:22:27 +00:00
carlosap deleted branch 6932-cambios-en-ENT-con-facturas-contabilzadas 2024-02-26 16:22:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2091
No description provided.
Delete Branch "6932-cambios-en-ENT-con-facturas-contabilzadas"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?