verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 64 Releases Wiki Activity

feat: comprobaciones facturas contabilizadas refs #6932 #2091

Merged
carlosap merged 9 commits from 6932-cambios-en-ENT-con-facturas-contabilzadas into dev 2024-02-26 16:22:27 +00:00
Conversation 0 Commits 9 Files Changed 2 +9 -9
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5fe4f794cc - Show all commits

7
db/routines/vn/triggers/entry_beforeUpdate.sql
View File

@ -6,6 +6,7 @@ BEGIN
DECLARE vIsVirtual BOOL;
DECLARE vPrintedCount INT;
DECLARE vHasDistinctWarehouses BOOL;
DECLARE vHasAnyInvoiceBooked BOOL;
jgallego commented 2024-02-26 13:16:03 +00:00
Outdated
Review
Copy Link

no hem parlat de deixar sols el trigger de travel?

no hem parlat de deixar sols el trigger de travel?
SET NEW.editorFk = account.myUser_getId();
@ -49,15 +50,13 @@ BEGIN
END IF;
IF NOT (NEW.invoiceInFk <=> OLD.invoiceInFk)THEN
DECLARE vHanAnyInvoiceBooked BOOL;
SELECT COUNT(*) INTO vHanAnyInvoiceBooked
SELECT COUNT(*) INTO vHasAnyInvoiceBooked
FROM entry e
JOIN invoiceIn ii ON ii.id = e.invoiceInFk
WHERE e.id = NEW.id
AND ii.isBooked;
IF vHanAnyInvoiceBooked THEN
IF vHasAnyInvoiceBooked THEN
CALL util.throw('The travel has entries with booked invoices')
jgallego commented 2024-02-24 05:50:09 +00:00
Outdated
Review
Copy Link

Ademés de que estem repentint codi, crec que teniem un altre cau de fer que en les entrades pasara igual que en tpv que si un ticket esta facturat ja no es pot modificar, es pot fer igual? si el contabilicen mirar quines coses no es poden tocar.
Si vols seguir en la linea que ho has plantejat, jo faria una funcion travel_hasInvoiceBooked o similar que li pases el travel et torna l'error i estos dos triggers que li pasen el travel. La unica diferencia es que en el trigger de entry tu estas sols comprobant l'entrada actual i en el que jo planteje es comprobarien totes les del travel, pero llegint el mensage d'error crec que es lo correcte.

Ademés de que estem repentint codi, crec que teniem un altre cau de fer que en les entrades pasara igual que en tpv que si un ticket esta facturat ja no es pot modificar, es pot fer igual? si el contabilicen mirar quines coses no es poden tocar. Si vols seguir en la linea que ho has plantejat, jo faria una funcion travel_hasInvoiceBooked o similar que li pases el travel et torna l'error i estos dos triggers que li pasen el travel. La unica diferencia es que en el trigger de entry tu estas sols comprobant l'entrada actual i en el que jo planteje es comprobarien totes les del travel, pero llegint el mensage d'error crec que es lo correcte.
carlosap commented 2024-02-26 11:20:04 +00:00
Outdated
Review
Copy Link

Se decide dejar solamente las verificaciones a nivel de travel

Se decide dejar solamente las verificaciones a nivel de travel
END IF;
END IF;

11
db/routines/vn/triggers/travel_beforeUpdate.sql
View File

@ -3,6 +3,8 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`travel_beforeUpdate`
BEFORE UPDATE ON `travel`
FOR EACH ROW
BEGIN
DECLARE vHasAnyInvoiceBooked BOOL;
SET NEW.editorFk = account.myUser_getId();
IF NOT (NEW.landed <=> OLD.landed)
@ -19,16 +21,15 @@ BEGIN
END IF;
IF NOT (NEW.awbFk <=> OLD.awbFk)THEN
DECLARE vHanAnyInvoiceBooked BOOL;
SELECT COUNT(*) INTO vHanAnyInvoiceBooked
carlosap marked this conversation as resolved
jgallego commented 2024-02-26 14:50:03 +00:00
Review
Copy Link

duplicat

duplicat
SELECT COUNT(*) INTO vHasAnyInvoiceBooked
FROM travel t
JOIN entry e ON e.travelFk =t.id
JOIN invoiceIn ii ON ii.id = e.invoiceInFk
WHERE t.id = NEW.id
AND ii.isBooked;
IF vHanAnyInvoiceBooked THEN
IF vHasAnyInvoiceBooked THEN
CALL util.throw('The travel has entries with booked invoices')
END IF;
END IF;