verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6930 - Use ScopedToken when share Multimedia files #2094

Merged
jsegarra merged 19 commits from 6930_scopedToken_Multimedia into dev 2024-03-15 08:28:05 +00:00
Conversation 0 Commits 19 Files Changed 27 +245 -154
jsegarra commented 2024-02-26 05:58:35 +00:00
Member
Copy Link
No description provided.
jsegarra added 3 commits 2024-02-26 05:58:35 +00:00
jsegarra changed title from #6930 - Use ScopedToken when share Multimedia files to WIP: #6930 - Use ScopedToken when share Multimedia files 2024-02-26 06:00:56 +00:00
jsegarra added 1 commit 2024-02-27 13:27:34 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f2ad069186 refs 6930 feat: get multimediaToken from new method
jsegarra added 1 commit 2024-02-28 06:41:20 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
a1a80259a2 Merge branch 'dev' into 6930_scopedToken_Multimedia
jsegarra added 4 commits 2024-02-28 09:56:13 +00:00
jsegarra requested review from juan 2024-02-28 10:56:36 +00:00
jsegarra changed title from WIP: #6930 - Use ScopedToken when share Multimedia files to #6930 - Use ScopedToken when share Multimedia files 2024-02-28 10:56:38 +00:00
jsegarra added 1 commit 2024-02-28 10:57:38 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1d1d950e4b refs 6930 feat: ACL
jsegarra added 1 commit 2024-02-29 06:40:57 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5ee9c2b01e refs #6930 fix: revert fdescribe
juan requested changes 2024-03-06 14:05:40 +00:00
Dismissed
back/models/vn-user.js Outdated
@ -30,6 +31,32 @@ module.exports = function(Self) {
message: `A client with that Web User name already exists`
});
Self.remoteMethod('logoutMultimedia', {
juan commented 2024-03-06 14:00:28 +00:00
Owner
Copy Link

Este método no sería necesario, con el logout nativo es suficiente

Este método no sería necesario, con el logout nativo es suficiente
jsegarra commented 2024-03-06 18:15:05 +00:00
Author
Member
Copy Link

Desde el inicio, no me planteé usar un método extra para hacer logout accessScoped, pero después de probar probar y perder el tiempo, decidí crearlo y buahala...success.

Bajo mi punto de vista, el logout nativo no funcionaria porque el token está asociado a un accessScope y como logout nativo no tiene definido ningun accessScoped, devuelve Access denied.

Si te parece, nos juntamos y lo vemos.

Desde el inicio, no me planteé usar un método extra para hacer logout accessScoped, pero después de probar probar y perder el tiempo, decidí crearlo y buahala...success. Bajo mi punto de vista, el logout nativo no funcionaria porque el token está asociado a un accessScope y como logout nativo no tiene definido ningun accessScoped, devuelve Access denied. Si te parece, nos juntamos y lo vemos.
jsegarra commented 2024-03-12 12:40:55 +00:00
Author
Member
Copy Link

Corregido:
99f01a1dbd
c84e86270c
ff6a1a9111

Corregido: 99f01a1dbd165bc89eee52dc2bbd66a0dde54de3 c84e86270c8c910903f26f2311883b9771d38a19 ff6a1a91110905c2a25fc8531be2ee831620101d
jsegarra marked this conversation as resolved
front/core/services/auth.js Outdated
@ -109,0 +111,4 @@
this.aclService.reset();
this.$state.go('login');
}
});
juan commented 2024-03-06 14:05:35 +00:00
Owner
Copy Link

Las llamadas al back pueden hacerse en paralelo en lugar de secuencial

Las llamadas al back pueden hacerse en paralelo en lugar de secuencial
jsegarra commented 2024-03-06 18:18:31 +00:00
Author
Member
Copy Link

Me parece que tiene mas lógica hacerlo sencuencial porque es la misma manera de proceder para obtener el token con accesScope, es decir,

  1. Pido token
  2. Solicito token con accessScope
  3. Logout con accessScope
  4. Logout del usuario

Puedo probar a implementar $q.all([promises])

Me parece que tiene mas lógica hacerlo sencuencial porque es la misma manera de proceder para obtener el token con accesScope, es decir, 1. Pido token 2. Solicito token con accessScope 3. Logout con accessScope 4. Logout del usuario Puedo probar a implementar $q.all([promises])
jsegarra commented 2024-03-12 12:41:08 +00:00
Author
Member
Copy Link

Corregido
f2f6e7be0b

Corregido f2f6e7be0b5354d041fe3c746fcf572ea06c7c3e
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2024-03-06 18:18:36 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6c06f70121 Merge branch 'dev' into 6930_scopedToken_Multimedia
jsegarra requested review from juan 2024-03-07 12:51:34 +00:00
jsegarra added 5 commits 2024-03-12 12:40:02 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
99f01a1dbd refs #6930 perf: add accessScopes to account.logout
jsegarra added 1 commit 2024-03-14 13:05:42 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a7faf4e325 refs #6930 perf: logout update
juan approved these changes 2024-03-15 08:11:48 +00:00
jsegarra added 1 commit 2024-03-15 08:26:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6989299593 Merge branch 'dev' into 6930_scopedToken_Multimedia
jsegarra merged commit 275e53f79c into dev 2024-03-15 08:28:05 +00:00
jsegarra deleted branch 6930_scopedToken_Multimedia 2024-03-15 08:28:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2094
No description provided.
Delete Branch "6930_scopedToken_Multimedia"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?