verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #6495 Migrated procs to vn #2108

Merged
guillermo merged 12 commits from 6495-procRefactor4 into dev 2024-03-12 06:04:20 +00:00
Conversation 1 Commits 12 Files Changed 5 +2 -256
guillermo commented 2024-02-28 11:31:35 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-02-28 11:31:35 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f5f2179ac6 refactor: refs #6495 Migrated procs to vn
guillermo requested review from carlosap 2024-02-28 11:31:55 +00:00
guillermo added 1 commit 2024-02-29 06:36:46 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
01fb865a76 Merge branch 'dev' into 6495-procRefactor4
guillermo added 1 commit 2024-02-29 13:49:29 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5c8b4b17c6 Merge branch 'dev' into 6495-procRefactor4
guillermo added 1 commit 2024-03-01 06:46:12 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3dd4d48557 refactor: refs #6495 Deleted residual procs
guillermo commented 2024-03-01 06:46:46 +00:00
Author
Member
Copy Link

He visto que embalajes_stocks y embalajes_stocks_detalle no tiene permisos nadie, por lo que doy por entendido que no se utiliza, dejo por si acaso los procedimientos refactorizados.

Procedo a la eliminación.

@carlosap

He visto que embalajes_stocks y embalajes_stocks_detalle no tiene permisos nadie, por lo que doy por entendido que no se utiliza, dejo por si acaso los procedimientos refactorizados. Procedo a la eliminación. @carlosap
guillermo added 1 commit 2024-03-01 06:46:51 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a439d07245 Merge branch 'dev' into 6495-procRefactor4
guillermo added 1 commit 2024-03-04 06:07:32 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
216f6f1db3 Merge branch 'dev' into 6495-procRefactor4
carlosap requested changes 2024-03-04 10:42:12 +00:00
db/routines/vn/procedures/client_sendMailPurchases.sql Outdated
@ -0,0 +1,91 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`client_sendMailPurchases`(
carlosap commented 2024-03-04 10:41:58 +00:00
Member
Copy Link

client_sendSales

client_sendSales
jgallego commented 2024-03-04 10:55:19 +00:00
Owner
Copy Link

al ser mail un verb podem ser mes concisos client_mailSales

al ser mail un verb podem ser mes concisos client_mailSales
guillermo marked this conversation as resolved
db/routines/vn/procedures/client_sendMailPurchases.sql Outdated
@ -0,0 +44,4 @@
SET vDated = IFNULL(vDated, util.yesterday());
OPEN vTickets;
FETCH vTickets INTO vTicketFk, vAlias, vAmount, vStreet, vCity;
carlosap commented 2024-03-04 10:40:24 +00:00
Member
Copy Link

No duplicar el FETCH

No duplicar el FETCH
guillermo marked this conversation as resolved
db/routines/vn/procedures/client_sendMailPurchasesLauncher.sql Outdated
@ -0,0 +16,4 @@
WHERE eypbc;
DECLARE CONTINUE HANDLER FOR NOT FOUND SET vDone = TRUE;
OPEN vClients;
carlosap commented 2024-03-04 10:39:27 +00:00
Member
Copy Link

No duplicar el FETCH

OPEN vClients;
l: LOOP
	SET vDone = FALSE;
	FETCH vClients INTO vClientFk;
     
	IF vDone THEN
		LEAVE l;
	END IF;
    CALL client_sendMailPurchases(util.yesterday(), vClientFk);
No duplicar el FETCH ``` OPEN vClients; l: LOOP SET vDone = FALSE; FETCH vClients INTO vClientFk; IF vDone THEN LEAVE l; END IF; CALL client_sendMailPurchases(util.yesterday(), vClientFk); ```
guillermo marked this conversation as resolved
carlosap requested review from jgallego 2024-03-04 10:42:21 +00:00
jgallego requested changes 2024-03-04 10:57:31 +00:00
db/routines/vn/procedures/client_sendMailPurchases.sql Outdated
@ -0,0 +81,4 @@
WHERE id = vSelf
AND email <> '';
CALL mail_insert(
jgallego commented 2024-03-04 10:56:12 +00:00
Owner
Copy Link

confirma en pako que encara necesita açò, si fos que si hi ha que buscar alternatives

confirma en pako que encara necesita açò, si fos que si hi ha que buscar alternatives
pako commented 2024-03-04 13:21:49 +00:00
Member
Copy Link

No em fa falta ja

No em fa falta ja
guillermo marked this conversation as resolved
db/routines/vn/procedures/client_sendMailPurchasesLauncher.sql Outdated
@ -0,0 +1,27 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`client_sendMailPurchasesLauncher`()
jgallego commented 2024-03-04 10:56:57 +00:00
Owner
Copy Link

client_mailSalesLaucher

client_mailSalesLaucher
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-03-05 07:54:33 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
619ac4e053 refactor: refs #6495 Requested changes
guillermo requested review from carlosap 2024-03-05 07:54:35 +00:00
guillermo requested review from jgallego 2024-03-05 07:54:36 +00:00
guillermo added 1 commit 2024-03-05 07:54:44 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ab4d1a0437 Merge branch 'dev' into 6495-procRefactor4
jgallego requested changes 2024-03-06 06:22:09 +00:00
jgallego left a comment
Owner
Copy Link

hablar con Julia para verificar que sigue siendo necesario enviar este mail, si fuese que si deribar a alguien de salix para crear el informe

hablar con Julia para verificar que sigue siendo necesario enviar este mail, si fuese que si deribar a alguien de salix para crear el informe
guillermo added 1 commit 2024-03-06 10:17:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
094c00aabd Merge branch 'dev' into 6495-procRefactor4
guillermo added 1 commit 2024-03-07 06:07:34 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
cd40bd47e5 refactor: refs #6495 Deleted procs
guillermo requested review from jgallego 2024-03-07 06:07:49 +00:00
guillermo added 1 commit 2024-03-07 06:07:57 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ee08502f33 Merge branch 'dev' into 6495-procRefactor4
guillermo added 1 commit 2024-03-08 11:31:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1027ef6479 Merge branch 'dev' into 6495-procRefactor4
jgallego approved these changes 2024-03-08 14:27:41 +00:00
carlosap approved these changes 2024-03-11 13:45:45 +00:00
guillermo merged commit 819bc7a56d into dev 2024-03-12 06:04:20 +00:00
guillermo deleted branch 6495-procRefactor4 2024-03-12 06:04:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2108
No description provided.
Delete Branch "6495-procRefactor4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?