verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #6874 Proc itemProposal #2123

Merged
guillermo merged 3 commits from 6874-itemProposalRefactor into dev 2024-03-05 06:35:06 +00:00
Conversation 0 Commits 3 Files Changed 3 +97 -228
guillermo commented 2024-03-04 07:37:28 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-03-04 07:37:28 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
28dbb200fc refactor: refs #6874 Proc itemProposal
guillermo requested review from jgallego 2024-03-04 07:39:51 +00:00
jgallego requested changes 2024-03-04 08:12:49 +00:00
db/routines/vn/procedures/itemProposal.sql Outdated
@ -1,19 +1,23 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`itemProposal`(vItemFk INT, vTicketFk INT,vShowType BOOL)
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`itemProposal`(
jgallego commented 2024-03-04 08:12:45 +00:00
Owner
Copy Link

vn.item_getSimilar pareix que fa algo moolt paregut..mira a vore si els podem fusionar,
en cas de no poder fusionarlos, meu dius perque este hauria de tindre un nom correcte item_ algo

vn.item_getSimilar pareix que fa algo moolt paregut..mira a vore si els podem fusionar, en cas de no poder fusionarlos, meu dius perque este hauria de tindre un nom correcte item_ algo
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-03-04 11:43:39 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
24efc1dd28 Merge branch 'dev' into 6874-itemProposalRefactor
guillermo added 1 commit 2024-03-04 12:13:36 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
cf810fe497 refactor: refs #6874 Proc itemProposal
guillermo requested review from jgallego 2024-03-04 12:18:47 +00:00
jgallego approved these changes 2024-03-04 13:32:12 +00:00
guillermo merged commit 05380df4f8 into dev 2024-03-05 06:35:06 +00:00
guillermo deleted branch 6874-itemProposalRefactor 2024-03-05 06:35:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2123
No description provided.
Delete Branch "6874-itemProposalRefactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?