feat: refs #6500 procRefactor8 #2131

Merged
robert merged 28 commits from 6500-procRefactor8 into dev 2024-04-17 11:32:54 +00:00
Member
No description provided.
robert added 1 commit 2024-03-05 11:42:03 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9aad1dd6e8
feat: refs #6500 procRefactor8
robert changed title from feat: refs #6500 procRefactor8 to WIP: feat: refs #6500 procRefactor8 2024-03-05 11:42:08 +00:00
robert added 1 commit 2024-03-05 12:22:49 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e83b0622cf
refs 6500 rateView
robert added 1 commit 2024-03-06 09:12:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9c6db881b8
Merge branch 'dev' into 6500-procRefactor8
robert added 2 commits 2024-03-06 11:02:17 +00:00
robert added 1 commit 2024-03-06 11:06:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5ee78a6b8c
Merge branch 'dev' into 6500-procRefactor8
robert added 1 commit 2024-03-06 13:10:49 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
194947dc9a
feat: refs #6500 procRefactor8
robert added 1 commit 2024-03-14 05:59:26 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1d434da539
Merge branch 'dev' into 6500-procRefactor8
robert added 2 commits 2024-04-08 10:01:07 +00:00
robert added 1 commit 2024-04-08 10:17:52 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2d18f01a15
feat: refs #6500
robert added 1 commit 2024-04-08 10:21:54 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d595a7b2fa
feat: refs #6500
robert changed title from WIP: feat: refs #6500 procRefactor8 to feat: refs #6500 procRefactor8 2024-04-08 10:27:13 +00:00
robert requested review from carlosap 2024-04-08 10:27:22 +00:00
carlosap requested changes 2024-04-08 15:29:14 +00:00
Dismissed
@ -0,0 +16,4 @@
DROP TEMPORARY TABLE IF EXISTS tCreditClients;
CREATE TEMPORARY TABLE tCreditClients
SELECT clientFk, IF (credit > recovery ,credit - recovery,0) newCredit
Member

Espacios: SELECT clientFk, IF (credit > recovery, credit - recovery, 0) newCredit

Espacios: SELECT clientFk, IF (credit > recovery, credit - recovery, 0) newCredit
robert marked this conversation as resolved
@ -0,0 +17,4 @@
DROP TEMPORARY TABLE IF EXISTS tCreditClients;
CREATE TEMPORARY TABLE tCreditClients
SELECT clientFk, IF (credit > recovery ,credit - recovery,0) newCredit
FROM (
Member

tabulación FROM

tabulación FROM
robert marked this conversation as resolved
@ -0,0 +20,4 @@
FROM (
SELECT r.clientFk,
r.amount recovery,
timestampadd(DAY, r.period, sub2.created) deadLine,
Member

INTERVAL

INTERVAL
robert marked this conversation as resolved
@ -0,0 +26,4 @@
JOIN (
SELECT clientFk, amount , created
FROM (
SELECT * FROM clientCredit
Member

Especificar campos, eliminar *

Especificar campos, eliminar *
robert marked this conversation as resolved
@ -0,0 +34,4 @@
) sub2 ON sub2.clientFk = r.clientFk
WHERE r.finished IS NULL OR r.finished >= util.VN_CURDATE()
GROUP BY r.clientFk
HAVING deadLine <= util.VN_CURDATE()
Member

tabulación HAVING

tabulación HAVING
robert marked this conversation as resolved
@ -0,0 +39,4 @@
WHERE credit > 0;
UPDATE client c
JOIN tCreditClients cc ON cc.clientFk = c.id
Member

tabulación JOIN y SET

tabulación JOIN y SET
robert marked this conversation as resolved
@ -0,0 +1,4 @@
-- Place your SQL code here
UPDATE bs.nightTask SET `schema`='vn' WHERE id=22;
Member

Utilizar el nombre del procedure y no la posición

Utilizar el nombre del procedure y no la posición
robert marked this conversation as resolved
@ -0,0 +1,4 @@
-- Place your SQL code here
UPDATE bs.nightTask SET `schema`='vn' WHERE id=22;
UPDATE bs.nightTask SET `schema`='vn',`procedure`='creditRecovery' WHERE id=30;
Member

Utilizar el nombre del procedure y no la posición

Utilizar el nombre del procedure y no la posición
robert marked this conversation as resolved
robert added 1 commit 2024-04-09 05:34:23 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
2c0c346a7b
feat: refs #6500
robert added 1 commit 2024-04-09 05:37:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1743f7501a
Merge branch 'dev' into 6500-procRefactor8
robert requested review from carlosap 2024-04-09 05:39:35 +00:00
robert added 1 commit 2024-04-09 09:39:52 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c6ece4619f
feat: refs #6500
robert added 1 commit 2024-04-10 12:04:43 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e2eff4df54
Merge branch 'dev' into 6500-procRefactor8
carlosap requested changes 2024-04-11 11:29:17 +00:00
Dismissed
@ -0,0 +1,50 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`creditRecovery`()
BEGIN
Member

Falta descripción del procedimiento

Falta descripción del procedimiento
robert marked this conversation as resolved
@ -0,0 +1,30 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`raidUpdate`()
BEGIN
Member

falta descripción

falta descripción
robert marked this conversation as resolved
@ -0,0 +1,36 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`rateView`()
BEGIN
Member

falta descripción

falta descripción
robert marked this conversation as resolved
robert added 1 commit 2024-04-11 12:21:34 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
04c5a9a004
Merge branch 'dev' into 6500-procRefactor8
robert added 1 commit 2024-04-12 05:57:55 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f545a57c9f
feat: refs #6500
robert added 1 commit 2024-04-12 06:40:27 +00:00
robert added 1 commit 2024-04-12 06:43:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
adadf70f1e
feat: refs #6500
robert requested review from carlosap 2024-04-12 06:46:15 +00:00
carlosap requested changes 2024-04-12 09:30:23 +00:00
Dismissed
@ -0,0 +10,4 @@
JOIN (
SELECT *
FROM (
SELECT id, landed, tt.warehouseInFk, tt.warehouseOutFk
Member

faltan alias en los campos

faltan alias en los campos
robert marked this conversation as resolved
@ -0,0 +19,4 @@
JOIN travel t ON t.id = e.travelFk
GROUP BY t.warehouseInFk, t.warehouseOutFk
) tt ON t.warehouseInFk = tt.warehouseInFk AND t.warehouseOutFk = tt.warehouseOutFk
WHERE shipped > util.VN_CURDATE() AND isDelivered = FALSE
Member

isDelivered = FALSE

NOT isDelivered

Faltan alias

isDelivered = FALSE NOT isDelivered Faltan alias
robert marked this conversation as resolved
@ -0,0 +18,4 @@
( SELECT
t.year,
t.month,
CAST(SUM(divisa) AS DECIMAL(10,2)) dollars,
Member

faltan alias, no se sabe de que tablas vienen los campos

faltan alias, no se sabe de que tablas vienen los campos
robert marked this conversation as resolved
robert added 1 commit 2024-04-12 10:12:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f30f907d8e
feat: refs #6500 cambios solicitados
robert added 1 commit 2024-04-15 05:18:57 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
36b3a92ca3
Merge branch 'dev' into 6500-procRefactor8
robert requested review from carlosap 2024-04-15 05:19:37 +00:00
robert added 1 commit 2024-04-15 09:35:56 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a41aa46c3a
Merge branch 'dev' into 6500-procRefactor8
robert added 1 commit 2024-04-16 08:39:11 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
ffd7b3cf50
Merge branch 'dev' into 6500-procRefactor8
carlosap requested changes 2024-04-16 17:13:02 +00:00
Dismissed
@ -0,0 +28,4 @@
WHERE p.divisa
AND c.code = 'USD'
GROUP BY t.year, t.month
) pagos ON t.year = pagos.year AND t.month = pagos.MONTH
Member

En la medida de lo posible no se debe de escribir en español, en este caso el nombre de la subconsulta es totalmente evitable que este en español, traducir

En la medida de lo posible no se debe de escribir en español, en este caso el nombre de la subconsulta es totalmente evitable que este en español, traducir
robert marked this conversation as resolved
robert added 1 commit 2024-04-17 08:59:36 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
8ca278b5a9
feat: refs #6500 cambios solicitados
robert added 1 commit 2024-04-17 09:01:41 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3e5b6a9ad1
Merge branch 'dev' into 6500-procRefactor8
robert requested review from carlosap 2024-04-17 09:09:52 +00:00
robert added 1 commit 2024-04-17 11:11:02 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e769081a74
feat: refs #6500
carlosap approved these changes 2024-04-17 11:26:46 +00:00
robert added 1 commit 2024-04-17 11:30:47 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
edc6e4a5e3
Merge branch 'dev' into 6500-procRefactor8
robert merged commit c62ec8798b into dev 2024-04-17 11:32:54 +00:00
robert deleted branch 6500-procRefactor8 2024-04-17 11:32:54 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2131
No description provided.