verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6942 toUnbook #2135

Merged
jorgep merged 46 commits from 6942-improveInvoiceIn into dev 2024-05-29 07:03:35 +00:00
Conversation 0 Commits 46 Files Changed 9 +277 -3
jorgep commented 2024-03-05 15:19:41 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-03-05 15:19:41 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5a11e9ac76 feat: refs #6942 toUnbook
jorgep added 1 commit 2024-03-06 08:22:51 +00:00
jorgep added 1 commit 2024-03-06 08:23:33 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
607f08b568 feat: refs #6942 xdiario fixtures
jorgep added 2 commits 2024-03-06 09:01:22 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b5e8184489 fix: refs #6942 delete
jorgep added 1 commit 2024-03-06 12:46:56 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f79435bd13 feat: refs #6942 set false isBooed & ledger
jorgep added 1 commit 2024-03-06 12:56:37 +00:00
jorgep added 1 commit 2024-03-07 08:49:39 +00:00
jorgep added 1 commit 2024-03-07 13:34:17 +00:00
jorgep added 1 commit 2024-03-08 08:10:53 +00:00
jorgep added 1 commit 2024-03-08 11:23:58 +00:00
jorgep changed title from WIP: #6942 toUnbook to #6942 toUnbook 2024-03-11 07:41:49 +00:00
jorgep reviewed 2024-03-11 07:46:03 +00:00
db/dump/fixtures.before.sql Outdated
@ -3732,1 +3731,4 @@
INSERT INTO vn.report (name) VALUES ('LabelCollection');
INSERT INTO `vn`.`ledgerConfig` (lastBookEntry, maxTolerance) VALUES (2,0.01);
jorgep commented 2024-03-11 07:46:03 +00:00
Author
Member
Copy Link

fixture creada para poder descontabilizar, revisado con @carlosap

fixture creada para poder descontabilizar, revisado con @carlosap
jorgep reviewed 2024-03-11 07:46:55 +00:00
modules/client/back/models/XDiario.json Outdated
@ -80,0 +82,4 @@
},
"CLAVE": {
"type": "number"
}
jorgep commented 2024-03-11 07:46:55 +00:00
Author
Member
Copy Link

El campo CLAVE está en mayúsculas en la base de datos

El campo CLAVE está en mayúsculas en la base de datos
alexm commented 2024-03-11 08:19:59 +00:00
Member
Copy Link

Li pots fer un rename per a que nosaltres ho gastem normal.
En ticket.json hi ha un exemple:

 "updated": {
            "type": "date",
            "mysql": {
                "columnName": "created"
            }
        },
Li pots fer un rename per a que nosaltres ho gastem normal. En ticket.json hi ha un exemple: ``` "updated": { "type": "date", "mysql": { "columnName": "created" } }, ```
jorgep marked this conversation as resolved
jorgep requested review from alexm 2024-03-11 08:00:30 +00:00
jorgep added 1 commit 2024-03-11 08:01:02 +00:00
jorgep added the
CR / Tests passed
 label 2024-03-11 08:01:42 +00:00
alexm requested changes 2024-03-11 08:29:31 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Cambiar nombre de parametri

Cambiar nombre de parametri
👍 1
alexm requested review from jgallego 2024-03-11 08:29:40 +00:00
alexm reviewed 2024-03-11 08:30:16 +00:00
modules/invoiceIn/back/methods/invoice-in/toUnbook.js Outdated
@ -0,0 +47,4 @@
}
}, myOptions);
if (bookEntry) {
alexm commented 2024-03-11 08:30:16 +00:00
Member
Copy Link

@jgallego veus be la logica?

@jgallego veus be la logica?
jgallego commented 2024-03-12 07:09:58 +00:00
Owner
Copy Link

esta ok

esta ok
jgallego marked this conversation as resolved
jorgep added 1 commit 2024-03-11 09:17:14 +00:00
jorgep added 1 commit 2024-03-11 11:16:21 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
58635b5468 fix: refs #6942 add test & change column name
jorgep added 1 commit 2024-03-11 12:53:19 +00:00
jorgep requested review from alexm 2024-03-11 12:53:34 +00:00
jgallego approved these changes 2024-03-12 06:34:48 +00:00
Dismissed
jorgep added 1 commit 2024-03-12 08:05:40 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c91c12e41c Merge branch 'dev' into 6942-improveInvoiceIn
jorgep added 2 commits 2024-03-12 10:00:21 +00:00
alexm added 1 commit 2024-03-13 08:37:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
0d8ca39d04 Merge branch 'dev' into 6942-improveInvoiceIn
alexm approved these changes 2024-03-13 08:37:57 +00:00
Dismissed
jorgep added 2 commits 2024-03-13 14:56:19 +00:00
jorgep added 1 commit 2024-03-15 08:34:55 +00:00
jorgep added 1 commit 2024-03-25 14:11:19 +00:00
jorgep added 1 commit 2024-05-17 12:39:40 +00:00
jorgep added 1 commit 2024-05-20 06:54:28 +00:00
jorgep added 1 commit 2024-05-20 13:36:20 +00:00
jorgep added 1 commit 2024-05-21 07:06:10 +00:00
jorgep added 1 commit 2024-05-22 10:30:47 +00:00
jorgep added 1 commit 2024-05-23 06:58:52 +00:00
jorgep added 1 commit 2024-05-23 14:07:49 +00:00
jorgep added 1 commit 2024-05-23 14:08:52 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3e2abfea2c fix: refs #6942 merge
jorgep added 2 commits 2024-05-23 15:53:11 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
cddc034adf fix: refs #6942 revoke update isBooked
jorgep added 1 commit 2024-05-24 06:51:45 +00:00
jorgep added 1 commit 2024-05-27 07:03:47 +00:00
jorgep added 1 commit 2024-05-27 08:48:36 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
dc90ad6595 fix: refs #6942 acls & back
jorgep added 1 commit 2024-05-27 08:57:08 +00:00
jorgep reviewed 2024-05-27 09:38:40 +00:00
modules/invoiceIn/back/methods/invoice-in/updateInvoiceIn.js
@ -0,0 +1,104 @@
module.exports = Self => {
jorgep commented 2024-05-27 09:38:40 +00:00
Author
Member
Copy Link

Se llama desde basic-data para actualizar los campos de la factura. Tras hablar con @alex se ha decidido usar any. Ya que hay parametros que pueden ser number| null o string| null ... y en loopback no hay manera de ponerle 2 tipos a un argumento.

Se llama desde basic-data para actualizar los campos de la factura. Tras hablar con @alex se ha decidido usar any. Ya que hay parametros que pueden ser number| null o string| null ... y en loopback no hay manera de ponerle 2 tipos a un argumento.
jorgep reviewed 2024-05-27 09:39:03 +00:00
modules/item/back/models/expense.json
@ -10,3 +10,3 @@
"id": {
"id": true,
"type": "number",
"type": "string",
jorgep commented 2024-05-27 09:39:03 +00:00
Author
Member
Copy Link

En la base de datos está como varchar

En la base de datos está como varchar
jorgep added 1 commit 2024-05-27 09:58:18 +00:00
jorgep added 1 commit 2024-05-27 10:03:11 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
0fa6074278 fix: refs #6942 drop quotes
jsegarra reviewed 2024-05-27 10:22:39 +00:00
modules/invoiceIn/back/methods/invoice-in/toUnbook.js
@ -0,0 +46,4 @@
]
}
}, myOptions);
jsegarra commented 2024-05-27 10:16:54 +00:00
Member
Copy Link

El numero de ocurrencias de bookEntry.ASIEN es medio-alto.
Propongo crear una variable representativa de este valor y reemplazar donde toque.
Otro enfoque puede ser que en el if, reemplazar bookEntry.ASIEN porque ya es true

El numero de ocurrencias de bookEntry.ASIEN es medio-alto. Propongo crear una variable representativa de este valor y reemplazar donde toque. Otro enfoque puede ser que en el if, reemplazar bookEntry.ASIEN porque ya es true
jorgep commented 2024-05-27 10:28:23 +00:00
Author
Member
Copy Link

Me parece bien.

Me parece bien.
jorgep marked this conversation as resolved
jorgep added 2 commits 2024-05-27 10:53:28 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1671423d23 fix: refs #6942 add deleteById acl
jorgep requested review from jgallego 2024-05-27 10:53:56 +00:00
jorgep requested review from alexm 2024-05-27 10:53:58 +00:00
jgallego requested changes 2024-05-27 11:09:32 +00:00
Dismissed
db/versions/11065-yellowChrysanthemum/00-modifyInvoiceInPrivileges.sql Outdated
@ -0,0 +21,4 @@
withholdingSageFk,
expenseFkDeductible,
editorFk
) ON vn.invoiceIn TO administrative, hrBoss, buyer, logistic, grafana;
jgallego commented 2024-05-27 11:05:05 +00:00
Owner
Copy Link

grafana SOLO debe tener permisos de select en cualquier tabla

grafana SOLO debe tener permisos de select en cualquier tabla
jorgep commented 2024-05-27 11:32:12 +00:00
Author
Member
Copy Link

No hacía falta hacer el revoke, sobre grafana. Gestionado.

No hacía falta hacer el revoke, sobre grafana. Gestionado.
jorgep marked this conversation as resolved
modules/invoiceIn/back/methods/invoice-in/updateInvoiceIn.js
@ -0,0 +1,104 @@
module.exports = Self => {
Self.remoteMethodCtx('updateInvoiceIn', {
jgallego commented 2024-05-27 11:09:07 +00:00
Owner
Copy Link

porque no usas el nativo?

porque no usas el nativo?
jorgep commented 2024-05-27 11:28:59 +00:00
Author
Member
Copy Link

Porque con el nativo no se puede evitar la modificación de 1 solo campo de una tabla. En este caso, queremos evitar la modificación de isBooked desde salix. Lo hablé con Juan y me dijo que creará un back.

Porque con el nativo no se puede evitar la modificación de 1 solo campo de una tabla. En este caso, queremos evitar la modificación de isBooked desde salix. Lo hablé con Juan y me dijo que creará un back.
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-05-27 11:34:04 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1af24e8473 fix : refs #6942 remove grafana update priv
jorgep added 1 commit 2024-05-27 11:35:00 +00:00
jorgep requested review from jgallego 2024-05-27 11:35:19 +00:00
jorgep added 1 commit 2024-05-27 12:36:23 +00:00
jgallego approved these changes 2024-05-27 15:10:30 +00:00
jorgep added 1 commit 2024-05-28 11:14:37 +00:00
alexm approved these changes 2024-05-28 11:26:46 +00:00
jorgep added 1 commit 2024-05-29 07:00:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d35bbe5c06 Merge branch 'dev' into 6942-improveInvoiceIn
jorgep merged commit b50b1f2b13 into dev 2024-05-29 07:03:35 +00:00
jorgep deleted branch 6942-improveInvoiceIn 2024-05-29 07:03:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2135
No description provided.
Delete Branch "6942-improveInvoiceIn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?