verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 63 Releases Wiki Activity

#6942 toUnbook #2135

Merged
jorgep merged 46 commits from 6942-improveInvoiceIn into dev 2024-05-29 07:03:35 +00:00
Conversation 0 Commits 46 Files Changed 9 +1 -2
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b5e8184489 - Show all commits

3
modules/invoiceIn/back/methods/invoice-in/toUnbook.js
View File

@ -49,8 +49,7 @@ module.exports = Self => {
jorgep marked this conversation as resolved
jsegarra commented 2024-05-27 10:16:54 +00:00
Review
Copy Link

El numero de ocurrencias de bookEntry.ASIEN es medio-alto.
Propongo crear una variable representativa de este valor y reemplazar donde toque.
Otro enfoque puede ser que en el if, reemplazar bookEntry.ASIEN porque ya es true

El numero de ocurrencias de bookEntry.ASIEN es medio-alto. Propongo crear una variable representativa de este valor y reemplazar donde toque. Otro enfoque puede ser que en el if, reemplazar bookEntry.ASIEN porque ya es true
jorgep commented 2024-05-27 10:28:23 +00:00
Review
Copy Link

Me parece bien.

Me parece bien.
if (bookEntry) { if (bookEntry) {
jgallego marked this conversation as resolved Outdated
alexm commented 2024-03-11 08:30:16 +00:00
Outdated
Review
Copy Link

@jgallego veus be la logica?

@jgallego veus be la logica?
jgallego commented 2024-03-12 07:09:58 +00:00
Outdated
Review
Copy Link

esta ok

esta ok
accountingEntries = await models.Xdiario.count({ASIEN: bookEntry}, myOptions); accountingEntries = await models.Xdiario.count({ASIEN: bookEntry}, myOptions);
await models.Xdiario.destroyAll({ASIEN: bookEntry}, myOptions);
await models.Xdiario.destroyAll({where: {ASIEN: bookEntry}}, myOptions);
} else { } else {
const linkedBookEntry = await models.Xdiario.findOne({ const linkedBookEntry = await models.Xdiario.findOne({
fields: ['ASIEN'], fields: ['ASIEN'],