verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 62 Releases Wiki Activity

#6942 toUnbook #2135

Merged
jorgep merged 46 commits from 6942-improveInvoiceIn into dev 2024-05-29 07:03:35 +00:00
Conversation 0 Commits 46 Files Changed 9 +7 -7
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c136f2783a - Show all commits

3
db/versions/11065-yellowChrysanthemum/01-modifyInvoiceInAcls.sql
View File

@ -18,5 +18,4 @@ VALUES
('InvoiceIn', 'corrective', 'WRITE', 'ALLOW', 'ROLE', 'buyer'), ('InvoiceIn', 'corrective', 'WRITE', 'ALLOW', 'ROLE', 'buyer'),
('InvoiceIn', 'exchangeRateUpdate', 'WRITE', 'ALLOW', 'ROLE', 'buyer'), ('InvoiceIn', 'exchangeRateUpdate', 'WRITE', 'ALLOW', 'ROLE', 'buyer'),
('InvoiceIn', 'invoiceInEmail', 'WRITE', 'ALLOW', 'ROLE', 'buyer'), ('InvoiceIn', 'invoiceInEmail', 'WRITE', 'ALLOW', 'ROLE', 'buyer'),
('InvoiceIn', 'toBook', 'WRITE', 'ALLOW', 'ROLE', 'buyer'), ('InvoiceIn', 'toBook', 'WRITE', 'ALLOW', 'ROLE', 'buyer');
('InvoiceIn', 'toUnbook', 'WRITE', 'ALLOW', 'ROLE', 'buyer');

11
modules/invoiceIn/back/methods/invoice-in/toUnbook.js
View File

@ -47,10 +47,11 @@ module.exports = Self => {
} }
}, myOptions); }, myOptions);
jorgep marked this conversation as resolved
jsegarra commented 2024-05-27 10:16:54 +00:00
Review
Copy Link

El numero de ocurrencias de bookEntry.ASIEN es medio-alto.
Propongo crear una variable representativa de este valor y reemplazar donde toque.
Otro enfoque puede ser que en el if, reemplazar bookEntry.ASIEN porque ya es true

El numero de ocurrencias de bookEntry.ASIEN es medio-alto. Propongo crear una variable representativa de este valor y reemplazar donde toque. Otro enfoque puede ser que en el if, reemplazar bookEntry.ASIEN porque ya es true
jorgep commented 2024-05-27 10:28:23 +00:00
Review
Copy Link

Me parece bien.

Me parece bien.
if (bookEntry?.ASIEN) { let asien = bookEntry?.ASIEN;
accountingEntries = await models.Xdiario.count({ASIEN: bookEntry.ASIEN}, myOptions); if (asien) {
accountingEntries = await models.Xdiario.count({ASIEN: asien}, myOptions);
await models.Xdiario.destroyAll({ASIEN: bookEntry.ASIEN}, myOptions); await models.Xdiario.destroyAll({ASIEN: asien}, myOptions);
await Self.updateAll({id: invoiceInId}, {isBooked: false}, myOptions); await Self.updateAll({id: invoiceInId}, {isBooked: false}, myOptions);
} else { } else {
const linkedBookEntry = await models.Xdiario.findOne({ const linkedBookEntry = await models.Xdiario.findOne({
@ -61,14 +62,14 @@ module.exports = Self => {
} }
}, myOptions); }, myOptions);
bookEntry = linkedBookEntry?.ASIEN; asien = linkedBookEntry?.ASIEN;
isLinked = true; isLinked = true;
} }
if (tx) await tx.commit(); if (tx) await tx.commit();
return { return {
isLinked, isLinked,
bookEntry: bookEntry?.ASIEN, bookEntry: asien,
accountingEntries accountingEntries
}; };
} catch (e) { } catch (e) {