verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6492 refactor vn2008 procedures #2159

Merged
jorgep merged 18 commits from 6492-refactorProceduresVn2008 into dev 2024-04-10 09:42:07 +00:00
Conversation 0 Commits 18 Files Changed 10 +143 -92
jorgep commented 2024-03-12 10:03:44 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-03-12 12:02:43 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
10c2d25cbd feat: refs #6492 create procedures & grant privileges
jorgep added 1 commit 2024-03-12 14:32:17 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9e596e6525 fix: refs #6492 file names
jorgep added 1 commit 2024-03-14 08:16:08 +00:00
jorgep added 1 commit 2024-03-14 08:48:07 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3e458281e6 fix: refs #6492 boxes alias
jorgep added 1 commit 2024-03-14 10:54:32 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ff130b773d fix: refs #6492 drop useless insert
jorgep added 1 commit 2024-03-14 10:59:48 +00:00
jorgep added 1 commit 2024-03-14 11:15:22 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
d7115e40c1 feat: refs #6492 dropping vn2008 procedures
jorgep changed title from WIP: #6492 refactor vn2008 procedures to #6492 refactor vn2008 procedures 2024-03-14 11:16:53 +00:00
jorgep reviewed 2024-03-14 11:18:36 +00:00
jorgep reviewed 2024-03-14 11:19:00 +00:00
db/routines/vn2008/procedures/article.sql Outdated
@ -1,15 +0,0 @@
DELIMITER $$
jorgep commented 2024-03-14 11:19:00 +00:00
Author
Member
Copy Link

No se usa en ningún sitio.

No se usa en ningún sitio.
jorgep requested review from carlosap 2024-03-14 11:24:59 +00:00
jorgep added the
CR / Tests passed
 label 2024-03-14 11:27:00 +00:00
carlosap requested changes 2024-03-22 15:52:37 +00:00
Dismissed
db/routines/vn/procedures/addAccountReconciliation.sql
@ -0,0 +1,29 @@
DELIMITER $$
carlosap commented 2024-03-22 15:50:18 +00:00
Member
Copy Link

He revisado que solo se usa en un sitio muy concreto, es posible que sea mejor eliminar el procedimiento y pasar este UPDATE al código de access que es de donde se está llamando

He revisado que solo se usa en un sitio muy concreto, es posible que sea mejor eliminar el procedimiento y pasar este UPDATE al código de access que es de donde se está llamando
jorgep marked this conversation as resolved
db/routines/vn/procedures/addAccountReconciliation.sql
@ -0,0 +2,4 @@
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`addAccountReconciliation`()
BEGIN
/**
* Updates duplicate records in the accountReconciliation table,
carlosap commented 2024-03-22 15:49:21 +00:00
Member
Copy Link

Esta descripción no se adecua a lo que realmente hace

Esta descripción no se adecua a lo que realmente hace
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-03-25 07:57:48 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
2ea9d042e3 Merge branch 'dev' into 6492-refactorProceduresVn2008
jorgep added 2 commits 2024-03-26 11:44:46 +00:00
jorgep added 1 commit 2024-03-26 12:47:22 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
94f6d20bb1 feat: refs #6942 add Insert
jorgep requested review from carlosap 2024-03-26 12:59:34 +00:00
jorgep added 1 commit 2024-03-28 13:21:04 +00:00
jorgep added 1 commit 2024-03-28 14:09:06 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
df271a242d fix: refs #6492 procedure
jorgep added 1 commit 2024-03-28 14:10:07 +00:00
carlosap requested changes 2024-04-08 10:13:17 +00:00
Dismissed
db/versions/10948-azureSalal/00-addReconciliationConfig.sql
@ -0,0 +1,10 @@
CREATE OR REPLACE TABLE `vn`.`accountReconciliationConfig` (
`id` INT AUTO_INCREMENT,
`debitCredit` INT(6),
`debitCredit2` INT(6),
carlosap commented 2024-04-08 10:00:48 +00:00
Member
Copy Link

Vamos hacer un campo ENUM que sea debit, credit y eliminamos las 2 variables

Vamos hacer un campo ENUM que sea debit, credit y eliminamos las 2 variables
jorgep added 1 commit 2024-04-09 09:17:22 +00:00
jorgep added 1 commit 2024-04-09 13:26:25 +00:00
jorgep added 1 commit 2024-04-09 14:03:25 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a3c1bceb7e refactor: refs #6492 use enum
jorgep requested review from carlosap 2024-04-09 14:03:37 +00:00
carlosap approved these changes 2024-04-10 09:04:43 +00:00
jorgep added 1 commit 2024-04-10 09:29:18 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
099fb70582 Merge branch 'dev' into 6492-refactorProceduresVn2008
jorgep merged commit 0f5afc908c into dev 2024-04-10 09:42:07 +00:00
jorgep deleted branch 6492-refactorProceduresVn2008 2024-04-10 09:42:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2159
No description provided.
Delete Branch "6492-refactorProceduresVn2008"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?