verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix: closeTicket idem salix refs #6549 #2163

Merged
carlosap merged 9 commits from 6549-ticket_close into dev 2024-04-08 10:36:22 +00:00
Conversation 0 Commits 9 Files Changed 8 +144 -12
carlosap commented 2024-03-13 11:19:03 +00:00
Member
Copy Link
No description provided.
carlosap added 1 commit 2024-03-13 11:19:03 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ff459ea3be fix: closeTicket idem salix refs #6549
carlosap added 1 commit 2024-03-13 17:51:18 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
77d1a38a87 fix: closeTicket idem salix refs #6549
carlosap added 1 commit 2024-03-18 16:56:42 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
913b261f86 Merge branch 'dev' into 6549-ticket_close
carlosap added 1 commit 2024-03-18 17:15:08 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1315a854a9 fix: closeTicket idem salix Refs: #6549
carlosap added 1 commit 2024-04-04 12:20:59 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
75a4d6947f fix: closeTicket idem salix Refs: #6549
carlosap added 1 commit 2024-04-04 12:46:55 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
9fcad457a7 fix: closeTicket idem salix Refs: #6549
carlosap requested review from jgallego 2024-04-04 12:48:01 +00:00
carlosap requested review from alexm 2024-04-04 12:48:08 +00:00
jgallego requested changes 2024-04-04 13:18:16 +00:00
Dismissed
db/versions/10949-limeLaurel/00-firstScript.sql Outdated
@ -0,0 +6,4 @@
SET @notificationFk =LAST_INSERT_ID();
INSERT IGNORE INTO util.notificationAcl (notificationFk, roleFk)
SELECT @notificationFk, 108
jgallego commented 2024-04-04 13:12:46 +00:00
Owner
Copy Link

hacer join con role

hacer join con role
jgallego marked this conversation as resolved
modules/ticket/back/methods/ticket/closeAll.js Outdated
@ -62,0 +74,4 @@
FROM (
SELECT ticketFk,
CONCAT_WS('',
IF(hasErrorToInvoice, 'Facturar, ', ''),
jgallego commented 2024-04-04 13:15:29 +00:00
Owner
Copy Link

usar CONCAT_WS(', ','a','b','c')

usar CONCAT_WS(', ','a','b','c')
jgallego marked this conversation as resolved
print/templates/email/invoice-ticket-closure/locale/en.yml Outdated
@ -0,0 +1,4 @@
subject: Nightly ticket closing process report
title: Nightly ticket closing process report
reason: Reason
ticketId: Ticket No
jgallego commented 2024-04-04 13:17:51 +00:00
Owner
Copy Link

Id Ticket

Id Ticket
carlosap marked this conversation as resolved
print/templates/email/invoice-ticket-closure/locale/es.yml Outdated
@ -0,0 +1,4 @@
subject: Informe proceso de cierre de tickets nocturno
title: Informe proceso de cierre de tickets nocturno
reason: Motivo
ticketId: Ticket nº
jgallego commented 2024-04-04 13:17:45 +00:00
Owner
Copy Link

Id Ticket

Id Ticket
carlosap marked this conversation as resolved
carlosap added 1 commit 2024-04-04 15:50:42 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
fe0afe30bf fix: closeTicket idem salix Refs: #6549
carlosap requested review from jgallego 2024-04-04 15:52:32 +00:00
jgallego approved these changes 2024-04-05 05:23:03 +00:00
Dismissed
alexm requested changes 2024-04-05 05:51:35 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Tot lo demes OK

Tot lo demes OK
db/versions/10949-limeLaurel/00-firstScript.sql Outdated
@ -0,0 +1,16 @@
INSERT INTO util.notification ( name, description)
SELECT 'invoice-ticket-closure',
'Tickets not invoiced during the nightly closure ticket process'
FROM util.notification;
alexm commented 2024-04-05 05:50:17 +00:00
Member
Copy Link

Faltava llevar el from, sino fea tants inserts com linies te la taula

Faltava llevar el from, sino fea tants inserts com linies te la taula
carlosap marked this conversation as resolved
carlosap added 1 commit 2024-04-05 11:22:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
cedfdbb421 fix: closeTicket idem salix Refs: #6549
carlosap requested review from alexm 2024-04-05 11:23:40 +00:00
carlosap requested review from jgallego 2024-04-05 11:24:04 +00:00
jgallego approved these changes 2024-04-05 11:55:40 +00:00
Dismissed
alexm approved these changes 2024-04-05 12:19:57 +00:00
Dismissed
alexm added 1 commit 2024-04-05 12:20:13 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
93000aaecf Merge branch 'dev' into 6549-ticket_close
carlosap requested review from alexm 2024-04-05 12:40:24 +00:00
carlosap requested review from jgallego 2024-04-05 12:40:25 +00:00
jgallego approved these changes 2024-04-05 12:54:21 +00:00
alexm approved these changes 2024-04-08 06:37:54 +00:00
carlosap merged commit 5558e92b1e into dev 2024-04-08 10:36:22 +00:00
carlosap deleted branch 6549-ticket_close 2024-04-08 10:36:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2163
No description provided.
Delete Branch "6549-ticket_close"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?