verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#7019 fix(createManualInvoice): add throw error #2175

Merged
jorgep merged 7 commits from 7019_fix_createManualInvoice into dev 2024-04-25 15:30:19 +00:00
Conversation 0 Commits 7 Files Changed 5 +57 -76
alexm commented 2024-03-18 13:20:50 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2024-03-18 13:20:50 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
517aeebe8b refs #7019 fix(createManualInvoice): add throw error
jorgep added 1 commit 2024-04-25 08:16:21 +00:00
jorgep added 1 commit 2024-04-25 11:18:22 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
931c2c4f5e feat: refs #7211 error & locale
jorgep added 1 commit 2024-04-25 13:44:39 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4e864fed52 fix: refs #7211 tests
jorgep added 1 commit 2024-04-25 15:22:58 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
32da39899a fix: refs #7211 test e2e
jorgep changed title from WIP: refs #7019 fix(createManualInvoice): add throw error to #7019 fix(createManualInvoice): add throw error 2024-04-25 15:24:17 +00:00
jorgep added the
CR / Tests passed
 label 2024-04-25 15:24:21 +00:00
jorgep requested review from jgallego 2024-04-25 15:24:36 +00:00
jorgep added 1 commit 2024-04-25 15:24:57 +00:00
jorgep reviewed 2024-04-25 15:26:05 +00:00
e2e/paths/09-invoice-out/03_manualInvoice.spec.js
@ -41,3 +41,3 @@
await page.waitForSelector(selectors.invoiceOutIndex.manualInvoiceForm);
await page.autocompleteSearch(selectors.invoiceOutIndex.manualInvoiceClient, 'Max Eisenhardt');
await page.autocompleteSearch(selectors.invoiceOutIndex.manualInvoiceClient, 'Bruce Wayne');
jorgep commented 2024-04-25 15:26:05 +00:00
Member
Copy Link

Se estaba intentando facturar el mismo ticket. El ticket 15 es de este cliente, por tanto falla. Antes devolvía id: null y no estaba controlado para que lance un error.

Se estaba intentando facturar el mismo ticket. El ticket 15 es de este cliente, por tanto falla. Antes devolvía id: null y no estaba controlado para que lance un error.
jorgep reviewed 2024-04-25 15:26:53 +00:00
modules/invoiceOut/back/methods/invoiceOut/specs/createManualInvoice.spec.js
@ -147,2 +113,4 @@
});
});
function createInvoice(
jorgep commented 2024-04-25 15:26:53 +00:00
Member
Copy Link

Se repetía mucho lo mismo.

Se repetía mucho lo mismo.
jorgep added 1 commit 2024-04-25 15:28:46 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b09fa1e2fb feat: refs #7019 changelog
jgallego approved these changes 2024-04-25 15:29:08 +00:00
jorgep merged commit 86d8bc877a into dev 2024-04-25 15:30:19 +00:00
jorgep deleted branch 7019_fix_createManualInvoice 2024-04-25 15:30:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2175
No description provided.
Delete Branch "7019_fix_createManualInvoice"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?