refs #6276 feat:newWarehouse #2189

Merged
sergiodt merged 8 commits from 6276-newWarehouse-salix into master 2024-03-25 07:26:20 +00:00
Member
No description provided.
sergiodt added 1 commit 2024-03-21 09:20:31 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
9eee26cbe9
refs #6276 feat:newWarehouse
sergiodt requested review from alexm 2024-03-21 09:20:36 +00:00
sergiodt added 1 commit 2024-03-21 09:32:44 +00:00
gitea/salix/pipeline/pr-master There was a failure building this commit Details
3fbf32bd52
refs #6276 feat:newWarehouse
sergiodt added 1 commit 2024-03-21 09:34:03 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
1d37d3d8bf
refs #6276 feat:newWarehouse
sergiodt added 1 commit 2024-03-21 11:03:06 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
5135bee2d2
refs #6276 feat:newWarehouse
sergiodt added 1 commit 2024-03-21 11:05:42 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
2a976664ec
refs #6276 feat:newWarehouse
alexm requested changes 2024-03-21 12:31:34 +00:00
Dismissed
@ -350,0 +347,4 @@
"Cmr file does not exist": "El archivo del cmr no existe",
"You are not allowed to modify the alias": "No estás autorizado a modificar el alias",
"The address of the customer must have information about Incoterms and Customs Agent": "El consignatario del cliente debe tener informado Incoterms y Agente de aduanas",
"The line could not be marked": "The line could not be marked"
Member

Falta la traduccion

Falta la traduccion
sergiodt marked this conversation as resolved
@ -0,0 +30,4 @@
await tx.rollback();
});
xit('should add two new records', async() => {
Member

se quedan comentados???

se quedan comentados???
Author
Member

Si perquè falta vore el motiu que no s'ha pujat itemShelving_add que es cridat per upsertItem. Quan pugem itemShelving_add modificarem el test

Si perquè falta vore el motiu que no s'ha pujat itemShelving_add que es cridat per upsertItem. Quan pugem itemShelving_add modificarem el test
@ -89,16 +89,9 @@ module.exports = Self => {
const {itemOriginalFk} = await models.Buy.findById(buyFk, {fields: ['itemOriginalFk']}, myOptions);
if (itemOriginalFk) await models.SaleBuy.create({saleFk, buyFk}, myOptions);
} catch (e) {
Member

tiene que ser

catch(){}
finally(){ commit}

sino solo hara commit en caso de fallar

tiene que ser catch(){} finally(){ commit} sino solo hara commit en caso de fallar
Author
Member

He posat el commit en el codi , finally es propaga l'error i no volem que es propague

He posat el commit en el codi , finally es propaga l'error i no volem que es propague
sergiodt added 1 commit 2024-03-22 05:57:18 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
9e5e49c28f
refs #6276 feat:newWarehouse
sergiodt added 1 commit 2024-03-22 06:01:19 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
0116389290
Merge branch 'master' into 6276-newWarehouse-salix
sergiodt added 1 commit 2024-03-25 07:04:43 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
b179fc1b5a
Merge branch 'master' into 6276-newWarehouse-salix
sergiodt requested review from alexm 2024-03-25 07:05:56 +00:00
alexm approved these changes 2024-03-25 07:12:15 +00:00
sergiodt merged commit 25eb6735b0 into master 2024-03-25 07:26:20 +00:00
sergiodt deleted branch 6276-newWarehouse-salix 2024-03-25 07:26:20 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2189
No description provided.