verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

7013-solunionRiskRequest #2190

Merged
jgallego merged 8 commits from 7013-solunionRiskRequest into dev 2024-03-28 08:01:29 +00:00
Conversation 0 Commits 8 Files Changed 3 +53 -41
jgallego commented 2024-03-21 09:50:07 +00:00
Owner
Copy Link
No description provided.
jgallego added 2 commits 2024-03-21 09:50:07 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
a24d38128b feat: #7013 muestra solo clientes asegurados
jgallego requested review from carlosap 2024-03-21 09:50:12 +00:00
carlosap requested changes 2024-03-21 15:02:02 +00:00
Dismissed
db/routines/vn/procedures/solunionRiskRequest.sql Outdated
@ -1,31 +1,40 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`solunionRiskRequest`()
carlosap commented 2024-03-21 15:01:27 +00:00
Member
Copy Link

Si hay posibilidad de cambiar el nombre seria conveniente

Si hay posibilidad de cambiar el nombre seria conveniente
jgallego marked this conversation as resolved
db/routines/vn/procedures/solunionRiskRequest.sql Outdated
@ -28,0 +14,4 @@
LIMIT 10000000000000000000) t1
GROUP BY Id_Cliente;
CALL vn2008.risk_vs_client_list(util.VN_CURDATE());
carlosap commented 2024-03-21 15:00:48 +00:00
Member
Copy Link

@deprecated usar vn.client_getDebt

@deprecated usar vn.client_getDebt
jgallego commented 2024-03-25 06:44:31 +00:00
Author
Owner
Copy Link

https://redmine.verdnatura.es/issues/6500 ja esta en esta tarea i hi ha que mirar que donen el mateix resultat.

https://redmine.verdnatura.es/issues/6500 ja esta en esta tarea i hi ha que mirar que donen el mateix resultat.
jgallego marked this conversation as resolved
jgallego added 2 commits 2024-03-25 06:52:52 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
8d258254d0 feat: #7013 change name procedure
jgallego requested review from carlosap 2024-03-25 06:53:51 +00:00
carlosap requested changes 2024-03-25 09:51:17 +00:00
Dismissed
db/routines/vn/procedures/creditInsurance_getRisk.sql Outdated
@ -0,0 +34,4 @@
LEFT JOIN tmp.risk r ON r.Id_Cliente = ci.Id_Cliente
JOIN client c ON c.id = ci.Id_Cliente
JOIN bs.clientAnnualConsumption cac ON c.id = cac.clientFk
JOIN vn.country c2 ON c2.id = c.countryFk
carlosap commented 2024-03-25 09:50:59 +00:00
Member
Copy Link

vn. no es necesario

vn. no es necesario
jgallego marked this conversation as resolved
jgallego added 1 commit 2024-03-26 09:14:02 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
04117d2c27 fix: #7013 quito vn.
jgallego requested review from carlosap 2024-03-26 09:14:31 +00:00
carlosap requested changes 2024-03-26 09:24:08 +00:00
Dismissed
db/routines/vn/procedures/creditInsurance_getRisk.sql Outdated
@ -0,0 +1,43 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`creditInsurance_getRisk`()
BEGIN
/**
carlosap commented 2024-03-25 09:52:32 +00:00
Member
Copy Link

Comentarios sin tabular

Comentarios sin tabular
jgallego commented 2024-03-26 11:13:06 +00:00
Author
Owner
Copy Link

fet

fet
jgallego marked this conversation as resolved
jgallego added 1 commit 2024-03-26 11:12:46 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
587dd8f4d9 feat: #7013 sin tabular
jgallego removed review request for carlosap 2024-03-26 11:13:13 +00:00
jgallego requested review from carlosap 2024-03-26 11:13:15 +00:00
carlosap requested changes 2024-03-26 17:48:16 +00:00
Dismissed
db/routines/vn/procedures/creditInsurance_getRisk.sql Outdated
@ -0,0 +2,4 @@
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`creditInsurance_getRisk`()
BEGIN
/**
* Devuelve el riesgo de los clientes que estan asegurados
carlosap commented 2024-03-26 17:47:44 +00:00
Member
Copy Link

Falta un espacio al principio de comentario

Falta un espacio al principio de comentario
jgallego marked this conversation as resolved
db/routines/vn/procedures/creditInsurance_getRisk.sql Outdated
@ -0,0 +23,4 @@
c.name,
c.credit clientCredit,
c.creditInsurance solunion,
cast(r.risk as DECIMAL(10,0)) risk,
carlosap commented 2024-03-26 17:48:06 +00:00
Member
Copy Link

Funciones en mayúsculas

Funciones en mayúsculas
jgallego marked this conversation as resolved
jgallego added 1 commit 2024-03-27 07:05:44 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4b41ac68aa feat: #7013 en mayusculas y con espacio en comentarios
jgallego requested review from carlosap 2024-03-27 07:07:49 +00:00
jgallego added 1 commit 2024-03-27 07:12:15 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
fe0a1ad7be feat: #7013 purge productionError
carlosap approved these changes 2024-03-27 18:18:30 +00:00
jgallego merged commit 6596efdc91 into dev 2024-03-28 08:01:29 +00:00
jgallego deleted branch 7013-solunionRiskRequest 2024-03-28 08:01:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2190
No description provided.
Delete Branch "7013-solunionRiskRequest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?