verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: #7117 company_getSuppliersDebt devolver el pais del banco #2211

Merged
jgallego merged 2 commits from 7117 into dev 2024-03-28 08:02:31 +00:00
Conversation 0 Commits 2 Files Changed 1 +139 -135
jgallego commented 2024-03-26 08:53:52 +00:00
Owner
Copy Link
No description provided.
jgallego added 1 commit 2024-03-26 08:53:52 +00:00
jgallego requested review from carlosap 2024-03-26 08:54:02 +00:00
carlosap approved these changes 2024-03-26 09:28:23 +00:00
Dismissed
db/routines/vn/procedures/company_getSuppliersDebt.sql Outdated
@ -177,0 +169,4 @@
AND vp.supplierFk = rd.supplierFk
AND vp.companyFk = rd.companyFk
AND vp.currencyFk = rd.currencyFk
WHERE vp.isPayment = FALSE;
carlosap commented 2024-03-26 09:25:27 +00:00
Member
Copy Link

NOT

NOT
jgallego marked this conversation as resolved
carlosap requested changes 2024-03-26 09:29:14 +00:00
carlosap left a comment
Member
Copy Link

Revisar tabulaciones se han cambiado por espacios

Revisar tabulaciones se han cambiado por espacios
jgallego added 1 commit 2024-03-26 11:16:15 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
57c42b6808 feat: #7117 añado NOT
jgallego requested review from carlosap 2024-03-26 11:16:25 +00:00
carlosap requested changes 2024-03-26 17:51:56 +00:00
db/routines/vn/procedures/company_getSuppliersDebt.sql
@ -13,1 +10,3 @@
DECLARE vInvalidBalances DOUBLE;
DECLARE vStartingDate DATETIME DEFAULT TIMESTAMPADD (MONTH,- vMonthsAgo,util.VN_CURDATE());
DECLARE vCurrencyEuroFk INT;
DECLARE vStartDate DATE;
carlosap commented 2024-03-26 17:51:51 +00:00
Member
Copy Link

En la anterior revisión ya se indicó, se han substituido todas las tabulaciones por espacios,

En la anterior revisión ya se indicó, se han substituido todas las tabulaciones por espacios,
jgallego commented 2024-03-27 06:29:05 +00:00
Author
Owner
Copy Link

explicam açò que no entenc el que vols dir

explicam açò que no entenc el que vols dir
jgallego merged commit 585dd70a60 into dev 2024-03-28 08:02:31 +00:00
jgallego deleted branch 7117 2024-03-28 08:02:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2211
No description provided.
Delete Branch "7117"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?