verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #7150 #2224

Merged
robert merged 11 commits from 7150-greuge_dif_porte_add into dev 2024-04-10 07:01:14 +00:00
Conversation 0 Commits 11 Files Changed 2 +66 -50
robert commented 2024-03-27 16:00:22 +00:00
Member
Copy Link
No description provided.
robert added 1 commit 2024-03-27 16:00:23 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9667d31441 feat: refs #7150
robert changed title from feat: refs #7150 to WIP: feat: refs #7150 2024-03-27 16:00:25 +00:00
robert added 1 commit 2024-03-27 16:30:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
ed1bc06301 feat: refs #7150
carlosap requested changes 2024-04-05 14:59:10 +00:00
Dismissed
db/routines/bi/procedures/greuge_dif_porte_add.sql
@ -1,8 +1,14 @@
DELIMITER $$
carlosap commented 2024-04-05 14:58:00 +00:00
Member
Copy Link

Faltan comentarios

Faltan comentarios
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql Outdated
@ -4,2 +4,2 @@
DECLARE datSTART DATETIME DEFAULT TIMESTAMPADD(DAY,-60,util.VN_CURDATE()); -- '2019-07-01'
DECLARE datEND DATETIME DEFAULT TIMESTAMPADD(DAY,-1,util.VN_CURDATE());
DECLARE vDateStarted DATETIME;
DECLARE vDateEnded DATETIME DEFAULT TIMESTAMPADD(DAY,-1,util.VN_CURDATE());
carlosap commented 2024-04-05 14:51:11 +00:00
Member
Copy Link

usar INTERVAL

usar INTERVAL
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql Outdated
@ -6,0 +5,4 @@
DECLARE vDateEnded DATETIME DEFAULT TIMESTAMPADD(DAY,-1,util.VN_CURDATE());
DECLARE vDaysSinceLastRecalculation INT;
SELECT daysSinceLastRecalculation INTO vDaysSinceLastRecalculation
carlosap commented 2024-04-05 14:53:30 +00:00
Member
Copy Link

daysSinceLastRecalculation ? el recalculo se hace diariamente, esa descripción es confusa

daysSinceLastRecalculation ? el recalculo se hace diariamente, esa descripción es confusa
robert commented 2024-04-09 05:41:48 +00:00
Author
Member
Copy Link

Podrías decirme que nombre crees que seria correcto?

Podrías decirme que nombre crees que seria correcto?
db/routines/bi/procedures/greuge_dif_porte_add.sql Outdated
@ -6,0 +8,4 @@
SELECT daysSinceLastRecalculation INTO vDaysSinceLastRecalculation
FROM vn.greugeConfig;
SET vDateStarted = TIMESTAMPADD(DAY, -vDaysSinceLastRecalculation, util.VN_CURDATE());
carlosap commented 2024-04-05 14:53:38 +00:00
Member
Copy Link

usar INTERVAL

usar INTERVAL
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql
@ -14,19 +20,17 @@ BEGIN
SUM((t.zonePrice - t.zoneBonus) * ebv.ratio) AS teorico,
00000.00 as practico,
carlosap commented 2024-04-05 14:54:37 +00:00
Member
Copy Link

Alias 'AS' no son necesarios

Alias 'AS' no son necesarios
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql Outdated
@ -21,1 +23,4 @@
t.clientFk,
t.shipped
FROM vn.ticket t
JOIN vn2008.Clientes cli ON cli.Id_cliente = t.clientFk
carlosap commented 2024-04-05 14:54:17 +00:00
Member
Copy Link

eliminar las dependencias de vn2008

eliminar las dependencias de vn2008
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql Outdated
@ -29,1 +30,3 @@
AND z.isVolumetric = FALSE
WHERE t.shipped between vDateStarted AND vDateEnded
AND cli.`real`
AND t.companyFk IN (442 , 567)
carlosap commented 2024-04-05 14:57:15 +00:00
Member
Copy Link

Sin números

Sin números
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql Outdated
@ -30,0 +30,4 @@
WHERE t.shipped between vDateStarted AND vDateEnded
AND cli.`real`
AND t.companyFk IN (442 , 567)
AND z.isVolumetric = FALSE
carlosap commented 2024-04-05 14:55:04 +00:00
Member
Copy Link

NOT

NOT
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql
@ -49,11 +53,11 @@ BEGIN
(PRIMARY KEY (ticketFk))
ENGINE = MEMORY
SELECT dp.ticketFk, sum(Cantidad * Valor) as valor
carlosap commented 2024-04-05 14:55:20 +00:00
Member
Copy Link

SUM mayúsculas

SUM mayúsculas
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql Outdated
@ -55,2 +56,2 @@
WHERE mc.Id_Componente = 15
GROUP BY dp.ticketFk;
FROM tmp.dp
JOIN vn2008.Movimientos m ON m.Id_Ticket = dp.ticketFk
carlosap commented 2024-04-05 14:58:51 +00:00
Member
Copy Link

vn2008 ¿?

vn2008 ¿?
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql Outdated
@ -57,0 +56,4 @@
FROM tmp.dp
JOIN vn2008.Movimientos m ON m.Id_Ticket = dp.ticketFk
JOIN vn2008.Movimientos_componentes mc using(Id_Movimiento)
WHERE mc.Id_Componente = 15
carlosap commented 2024-04-05 14:56:05 +00:00
Member
Copy Link

Si estamos refactorizando no deben de aparecer números, JOIN al código de componente correspondiente

Si estamos refactorizando no deben de aparecer números, JOIN al código de componente correspondiente
robert marked this conversation as resolved
db/routines/bi/procedures/greuge_dif_porte_add.sql Outdated
@ -82,2 +82,2 @@
, 1
,dp.ticketFk
SELECT dp.clientFk,
concat('dif_porte ', dp.ticketFk),
carlosap commented 2024-04-05 14:59:04 +00:00
Member
Copy Link

funciones en mayúsculas

funciones en mayúsculas
robert marked this conversation as resolved
robert added 1 commit 2024-04-08 06:37:16 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5517c29c1c fet: refs #7150 greuge_dif_porte_add
robert added 1 commit 2024-04-08 06:39:25 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
1e8e6a67a3 Merge branch 'dev' into 7150-greuge_dif_porte_add
robert added 1 commit 2024-04-08 06:57:37 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
657150a9a7 feat: refs #7150 greuge_dif_porte_add
robert added 1 commit 2024-04-08 10:28:03 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
0c5b9e3544 Merge branch 'dev' into 7150-greuge_dif_porte_add
robert added 1 commit 2024-04-08 11:29:12 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
6ba43a3c6d Merge branch 'dev' into 7150-greuge_dif_porte_add
robert changed title from WIP: feat: refs #7150 to feat: refs #7150 2024-04-08 12:38:38 +00:00
robert added 1 commit 2024-04-09 05:40:04 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
4a31fe29b8 Merge branch 'dev' into 7150-greuge_dif_porte_add
robert requested review from carlosap 2024-04-09 05:42:18 +00:00
carlosap approved these changes 2024-04-09 10:32:13 +00:00
robert added 1 commit 2024-04-10 06:05:05 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
3420667ae5 Merge branch 'dev' into 7150-greuge_dif_porte_add
robert added 2 commits 2024-04-10 06:09:30 +00:00
robert merged commit acd422d48f into dev 2024-04-10 07:01:14 +00:00
robert deleted branch 7150-greuge_dif_porte_add 2024-04-10 07:01:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2224
No description provided.
Delete Branch "7150-greuge_dif_porte_add"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?