verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #6641 add button my team #2254

Merged
jcasado merged 7 commits from 6641-checkboxMyTeam into dev 2024-04-15 08:11:37 +00:00
Conversation 0 Commits 7 Files Changed 4 +84 -11
jcasado commented 2024-04-04 11:56:53 +00:00
Member
Copy Link
No description provided.
jcasado added 1 commit 2024-04-04 11:56:53 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5acef1fcc0 refs #6641 add button my team
jcasado added 1 commit 2024-04-04 12:27:52 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1c6d913926 refs #6641 addFilterCollegues
jcasado added 1 commit 2024-04-04 12:52:32 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
84e6e7f7bf refs #6641 test fixtures
jcasado added 1 commit 2024-04-08 11:02:15 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
26c74a3e71 refs #6641 fix test
jcasado changed title from WIP: refs #6641 add button my team to refs #6641 add button my team 2024-04-08 11:03:17 +00:00
jcasado requested review from alexm 2024-04-08 11:03:22 +00:00
jcasado added the
CR / Tests passed
 label 2024-04-08 11:13:47 +00:00
alexm reviewed 2024-04-09 05:59:56 +00:00
db/dump/fixtures.before.sql Outdated
@ -3748,1 +3747,4 @@
(1, 10, 9);
INSERT INTO vn.workerTeam
alexm commented 2024-04-09 05:59:56 +00:00
Member
Copy Link

Por seguir la convencion de SQL, añadir tabulaciones

Por seguir la convencion de SQL, añadir tabulaciones
jcasado marked this conversation as resolved
alexm requested changes 2024-04-09 06:18:32 +00:00
Dismissed
modules/claim/back/methods/claim/filter.js Outdated
@ -5,3 +5,3 @@
module.exports = Self => {
Self.remoteMethodCtx('filter', {
Self.remoteMethod('filter', {
alexm commented 2024-04-09 06:03:00 +00:00
Member
Copy Link

Pq se quita remoteMethodCtx y se pone?

	            {
                arg: 'ctx',
                type: 'object',
                http: {source: 'context'}
            },
Pq se quita remoteMethod**Ctx** y se pone? ``` { arg: 'ctx', type: 'object', http: {source: 'context'} }, ```
jcasado marked this conversation as resolved
modules/claim/back/methods/claim/specs/filter.spec.js Outdated
@ -8,3 +19,3 @@
const options = {transaction: tx};
const result = await app.models.Claim.filter({args: {filter: {}, search: 1}}, null, options);
const result = await app.models.Claim.filter({...ctx, args: {filter: {}, search: 1}}, null, options);
alexm commented 2024-04-09 06:15:15 +00:00
Member
Copy Link

Veo mas como y legible poner en la linea de antes ctx.args = {search: 1}
Y luego usar directamente .. models.Claim.filter(ctx, null, options);

Igual en los otros casos

Veo mas como y legible poner en la linea de antes `ctx.args = {search: 1}` Y luego usar directamente `.. models.Claim.filter(ctx, null, options);` Igual en los otros casos
jcasado marked this conversation as resolved
jcasado added 1 commit 2024-04-10 11:15:35 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7d925bac87 refs #6641 fix PR changes
jcasado requested review from alexm 2024-04-10 11:15:45 +00:00
jcasado added 1 commit 2024-04-10 11:16:38 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
0cf1ced747 remove focus
alexm approved these changes 2024-04-12 05:09:49 +00:00
jcasado added 1 commit 2024-04-15 08:10:20 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
dc8a6d1274 Merge branch 'dev' into 6641-checkboxMyTeam
jcasado scheduled this pull request to auto merge when all checks succeed 2024-04-15 08:11:00 +00:00
jcasado merged commit e0fca2cf6c into dev 2024-04-15 08:11:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2254
No description provided.
Delete Branch "6641-checkboxMyTeam"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?