refactor(workerDms): adapat to lilium #2269

Merged
alexm merged 3 commits from 6551-workerDms_refactor into dev 2024-04-09 08:21:21 +00:00
Member
No description provided.
alexm added 1 commit 2024-04-08 12:49:59 +00:00
gitea/salix/pipeline/pr-dev Build queued... Details
9134216332
refactor(workerDms): adapat to lilium
alexm added 1 commit 2024-04-08 12:50:07 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
0ecc09fcc4
Merge branch 'dev' into 6551-workerDms_refactor
alexm requested review from jsegarra 2024-04-08 13:00:35 +00:00
alexm reviewed 2024-04-09 05:33:47 +00:00
@ -66,2 +70,2 @@
if (!docuwareDmsType || (docuwareDmsType && await models.DmsType.hasReadRole(ctx, docuwareDmsType))) {
const worker = await models.Worker.findById(id, {fields: ['fi', 'firstName', 'lastName']});
if (!filter.skip && (!docuwareDmsType || (docuwareDmsType && await models.DmsType.hasReadRole(ctx, docuwareDmsType)))) {
const worker = await models.Worker.findById(36471, {fields: ['fi', 'firstName', 'lastName']});
Author
Member

id,

id,
alexm added 1 commit 2024-04-09 05:51:13 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
500244dbed
fix id
jsegarra approved these changes 2024-04-09 06:01:33 +00:00
@ -66,2 +70,2 @@
if (!docuwareDmsType || (docuwareDmsType && await models.DmsType.hasReadRole(ctx, docuwareDmsType))) {
const worker = await models.Worker.findById(id, {fields: ['fi', 'firstName', 'lastName']});
if (!filter.skip && (!docuwareDmsType || (docuwareDmsType && await models.DmsType.hasReadRole(ctx, docuwareDmsType)))) {
const worker = await models.Worker.findById(36471, {fields: ['fi', 'firstName', 'lastName']});
Member

valor fijo?
Supongo que se asociado a un registro de BD?
Si es así, moverlo a una variable const para que con el nombre se sepa a que hace referencia

valor fijo? Supongo que se asociado a un registro de BD? Si es así, moverlo a una variable const para que con el nombre se sepa a que hace referencia
jsegarra added spent time 2024-04-09 06:01:46 +00:00
20 hours
alexm merged commit c69a4e1c98 into dev 2024-04-09 08:21:21 +00:00
alexm deleted branch 6551-workerDms_refactor 2024-04-09 08:21:21 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Total Time Spent: 20 hours
jsegarra
20 hours
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2269
No description provided.