verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refactor: refs #7181 vn2008.Deleted risk_vs_client_list #2283

Merged
guillermo merged 5 commits from 7181-risk_vs_client_list into dev 2024-04-12 05:18:07 +00:00
Conversation 0 Commits 5 Files Changed 4 +35 -155
guillermo commented 2024-04-10 12:17:14 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2024-04-10 12:17:14 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
5044cd454d refactor: refs #7181 vn2008.Deleted risk_vs_client_list
guillermo added 1 commit 2024-04-10 12:23:25 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
7b3472aa0b refactor: refs #7181 Minor change
guillermo requested review from jgallego 2024-04-10 12:24:27 +00:00
jgallego requested changes 2024-04-11 06:18:45 +00:00
Dismissed
db/routines/vn/procedures/riskAllClients.sql Outdated
@ -1,29 +1,35 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`riskAllClients`(maxRiskDate DATE)
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`riskAllClients`(
jgallego commented 2024-04-11 06:18:09 +00:00
Owner
Copy Link

el nom no es correcte, podem gastar client_getRisk.
Amb retrocompatibilitat, este hi hauria que deixarlo per a que no falle res, pero que simplement apunte a l'altre que crees nou.

el nom no es correcte, podem gastar client_getRisk. Amb retrocompatibilitat, este hi hauria que deixarlo per a que no falle res, pero que simplement apunte a l'altre que crees nou.
guillermo commented 2024-04-11 07:28:08 +00:00
Author
Member
Copy Link

Soles es gasta en Access, per lo tant es pot canviar el nom sense problem

Soles es gasta en Access, per lo tant es pot canviar el nom sense problem
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-04-11 07:29:25 +00:00
gitea/salix/pipeline/pr-dev Build queued... Details
b1dc5efc8b refactor: refs #7181 Requested changes
guillermo requested review from jgallego 2024-04-11 07:29:33 +00:00
guillermo added 1 commit 2024-04-11 07:29:34 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
c9b2bb5b5e Merge branch 'dev' into 7181-risk_vs_client_list
jgallego requested changes 2024-04-11 10:34:21 +00:00
Dismissed
db/routines/vn/procedures/riskAllClients.sql Outdated
@ -1,29 +0,0 @@
DELIMITER $$
jgallego commented 2024-04-11 10:34:18 +00:00
Owner
Copy Link

si borres este archiu vas a borrar també tot lo que fa referencia a ell? sense fer-ho retrocompatible, es correcte?

si borres este archiu vas a borrar també tot lo que fa referencia a ell? sense fer-ho retrocompatible, es correcte?
guillermo commented 2024-04-11 12:41:33 +00:00
Author
Member
Copy Link

Com te he comentat avanç, el proc es gasta únicamente en Access, per lo tant soles tinc que canviar la dependencia en ENT.

Com te he comentat avanç, el proc es gasta únicamente en Access, per lo tant soles tinc que canviar la dependencia en ENT.
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-04-11 12:41:40 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
f69acf3a05 Merge branch 'dev' into 7181-risk_vs_client_list
guillermo requested review from jgallego 2024-04-11 12:41:41 +00:00
jgallego approved these changes 2024-04-11 13:07:51 +00:00
guillermo merged commit d86bb6b004 into dev 2024-04-12 05:18:07 +00:00
guillermo deleted branch 7181-risk_vs_client_list 2024-04-12 05:18:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2283
No description provided.
Delete Branch "7181-risk_vs_client_list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?