verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#7108 - exchange-rate #2295

Merged
jgallego merged 11 commits from 7108-exchange-rate into dev 2024-04-26 05:00:07 +00:00
Conversation 0 Commits 11 Files Changed 9 +170 -3
jgallego commented 2024-04-12 08:27:29 +00:00
Owner
Copy Link
No description provided.
jgallego added 2 commits 2024-04-12 08:27:30 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
bb6ea31bf7 feat: funcional a falta de test
jgallego requested review from alexm 2024-04-12 08:27:46 +00:00
alexm changed title from 7108-exchange-rate to #7108 - exchange-rate 2024-04-12 08:30:17 +00:00
alexm requested changes 2024-04-12 08:37:31 +00:00
Dismissed
back/methods/collection/exchangeRateUpdate.js Outdated
@ -0,0 +11,4 @@
path: '/exchangeRateUpdate',
verb: 'post'
},
returns: {
alexm commented 2024-04-12 08:35:31 +00:00
Member
Copy Link

Si no retorna res, no cal ficar return (no estic segur)

Si no retorna res, no cal ficar return (no estic segur)
jgallego marked this conversation as resolved
back/methods/collection/exchangeRateUpdate.js Outdated
@ -0,0 +29,4 @@
const maxDateRecord = await models.ReferenceRate.findOne({order: 'dated DESC'});
const maxDate = maxDateRecord && maxDateRecord.dated ? new Date(maxDateRecord.dated) : null;
alexm commented 2024-04-12 08:36:29 +00:00
Member
Copy Link

Se pot simplificar en const maxDate = maxDateRecord?.dated ? new Date(maxDateRecord.dated) : null;

Se pot simplificar en `const maxDate = maxDateRecord?.dated ? new Date(maxDateRecord.dated) : null;`
jgallego commented 2024-04-13 06:44:53 +00:00
Author
Owner
Copy Link

const maxDate = maxDateRecord?.dated ? new Date(maxDateRecord.dated) : null;

Unhandled error for request POST /api/Collections/exchangeRateUpdate?access_token=YQ8SPYxYrHrY4veSEyY5q9YJD3AtcjEqcGXxyA5rweDZO92PLp0FB2WhBxlbTvUO: TypeError: Cannot read properties of null (reading 'dated')

Ahir em va fallar..ací t'he posat la conversa amb chatGpt...ara sí va..ho canvie de nou

const maxDate = maxDateRecord?.dated ? new Date(maxDateRecord.dated) : null; Unhandled error for request POST /api/Collections/exchangeRateUpdate?access_token=YQ8SPYxYrHrY4veSEyY5q9YJD3AtcjEqcGXxyA5rweDZO92PLp0FB2WhBxlbTvUO: TypeError: Cannot read properties of null (reading 'dated') Ahir em va fallar..ací t'he posat la conversa amb chatGpt...ara sí va..ho canvie de nou
jgallego marked this conversation as resolved
back/methods/collection/exchangeRateUpdate.js Outdated
@ -0,0 +31,4 @@
const maxDate = maxDateRecord && maxDateRecord.dated ? new Date(maxDateRecord.dated) : null;
for (let i = 0; i < cubes.length; i++) {
alexm commented 2024-04-12 08:34:44 +00:00
Member
Copy Link

Si no cal la "i" i la "j", vec mes legible fer:

for (const/let cube of cubes)

i lo mateix en el altre for

Si no cal la "i" i la "j", vec mes legible fer: ``` for (const/let cube of cubes) ``` i lo mateix en el altre for
jgallego commented 2024-04-13 06:52:40 +00:00
Author
Owner
Copy Link

no era iterable li he posat Array.from(

no era iterable li he posat Array.from(
jgallego marked this conversation as resolved
back/models/reference-rate.json
@ -0,0 +1,37 @@
{
"name": "ReferenceRate",
"base": "PersistedModel",
"idInjection": false,
alexm commented 2024-04-12 08:32:05 +00:00
Member
Copy Link

esta propietat no la havia vist mai

esta propietat no la havia vist mai
jgallego marked this conversation as resolved
loopback/locale/es.json Outdated
@ -356,0 +360,4 @@
"ValidationError: The `ReferenceRate` instance is not valid. Details: `currencyFk` can't be blank (value: NaN).": "ValidationError: The `ReferenceRate` instance is not valid. Details: `currencyFk` can't be blank (value: NaN).",
"ReferenceError: Currency is not defined": "ReferenceError: Currency is not defined",
"UserError: Currency not found for code: CNY": "UserError: Currency not found for code: CNY",
"Error: ER_DUP_ENTRY: Duplicate entry '2-2024-04-03' for key 'PRIMARY'": "Error: ER_DUP_ENTRY: Duplicate entry '2-2024-04-03' for key 'PRIMARY'",
alexm commented 2024-04-12 08:32:47 +00:00
Member
Copy Link

Hi han q se han colat, al fer proves

Hi han q se han colat, al fer proves
jgallego marked this conversation as resolved
jgallego added 1 commit 2024-04-13 07:06:15 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
e8001b72e4 feat: minor changes
jgallego added 1 commit 2024-04-16 06:45:14 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
77a1aa4de6 feat: @7108 test
jgallego requested review from alexm 2024-04-16 06:47:24 +00:00
jgallego changed title from #7108 - exchange-rate to WIP: #7108 - exchange-rate 2024-04-16 06:47:26 +00:00
jgallego requested review from juan 2024-04-16 06:47:31 +00:00
jgallego changed title from WIP: #7108 - exchange-rate to #7108 - exchange-rate 2024-04-16 06:48:04 +00:00
alexm approved these changes 2024-04-16 09:50:29 +00:00
Dismissed
jgallego added 1 commit 2024-04-16 12:23:33 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
58baa45e09 Merge branch 'dev' into 7108-exchange-rate
juan approved these changes 2024-04-19 12:15:26 +00:00
jgallego added 2 commits 2024-04-22 09:46:11 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
b0c4f7fd3c feat: moved files to invoiceIn
jgallego added 1 commit 2024-04-24 06:09:42 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
dcc46494bc Merge branch 'dev' into 7108-exchange-rate
jgallego requested review from alexm 2024-04-24 06:10:56 +00:00
jgallego added 1 commit 2024-04-24 06:14:17 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
73f7d09b0e feat: #7108 acl a invoiceIn
alexm requested changes 2024-04-25 11:03:44 +00:00
Dismissed
db/versions/10992-goldenIvy/00-acl.sql Outdated
@ -0,0 +1,2 @@
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`)
VALUES ('invoiceIn', 'exchangeRateUpdate', '*', 'ALLOW', 'ROLE', 'employee');
alexm commented 2024-04-25 11:03:02 +00:00
Member
Copy Link

'invoiceIn' deuria ser en PascalCase ns si aixina fallaria.

'invoiceIn' deuria ser en PascalCase ns si aixina fallaria.
jgallego added 1 commit 2024-04-25 11:12:12 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
a4f1183df6 feat: refs #7108 pascalCase
jgallego requested review from alexm 2024-04-25 12:36:31 +00:00
alexm approved these changes 2024-04-25 13:03:34 +00:00
jgallego added 1 commit 2024-04-26 04:46:50 +00:00
gitea/salix/pipeline/pr-dev This commit looks good Details
94e04c1c2f Merge branch 'dev' into 7108-exchange-rate
jgallego merged commit 63320af4c7 into dev 2024-04-26 05:00:07 +00:00
jgallego deleted branch 7108-exchange-rate 2024-04-26 05:00:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2295
No description provided.
Delete Branch "7108-exchange-rate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?